[Django] #33781: Timezone warning visual regression.

62 views
Skip to first unread message

Django

unread,
Jun 13, 2022, 6:53:18 AM6/13/22
to django-...@googlegroups.com
#33781: Timezone warning visual regression.
--------------------------------------------+------------------------
Reporter: Mariusz Felisiak | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: dev
Severity: Release blocker | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 1 |
--------------------------------------------+------------------------
Unfortunately, f3e2bb0833105f43efc0cc6f19c8465bc1b1a785 introduced a
regression in admin which still uses `<p>` for
[https://github.com/django/django/blob/main/django/contrib/admin/templates/admin/widgets/split_datetime.html
split datetimes].

--
Ticket URL: <https://code.djangoproject.com/ticket/33781>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Jun 13, 2022, 6:55:08 AM6/13/22
to django-...@googlegroups.com
#33781: Timezone warning visual regression.
----------------------------------+--------------------------------------

Reporter: Mariusz Felisiak | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: dev
Severity: Release blocker | Resolution:

Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
----------------------------------+--------------------------------------
Changes (by Mariusz Felisiak):

* Attachment "after.png" added.

Django

unread,
Jun 13, 2022, 6:55:14 AM6/13/22
to django-...@googlegroups.com
#33781: Timezone warning visual regression.
----------------------------------+--------------------------------------
Reporter: Mariusz Felisiak | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: dev
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
----------------------------------+--------------------------------------
Changes (by Mariusz Felisiak):

* Attachment "before.png" added.

Django

unread,
Jun 13, 2022, 6:56:37 AM6/13/22
to django-...@googlegroups.com
#33781: Timezone warning visual regression.
----------------------------------+--------------------------------------
Reporter: Mariusz Felisiak | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: dev
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
----------------------------------+--------------------------------------
Description changed by Mariusz Felisiak:

Old description:

> Unfortunately, f3e2bb0833105f43efc0cc6f19c8465bc1b1a785 introduced a
> regression in admin which still uses `<p>` for
> [https://github.com/django/django/blob/main/django/contrib/admin/templates/admin/widgets/split_datetime.html
> split datetimes].

New description:

Unfortunately, f3e2bb0833105f43efc0cc6f19c8465bc1b1a785 introduced a
regression in admin which still uses `<p>` for
[https://github.com/django/django/blob/main/django/contrib/admin/templates/admin/widgets/split_datetime.html
split datetimes].

Before:

[[Image(before.png)]]

----

After f3e2bb0833105f43efc0cc6f19c8465bc1b1a785:

[[Image(after.png)]]

--

--
Ticket URL: <https://code.djangoproject.com/ticket/33781#comment:1>

Django

unread,
Jun 14, 2022, 2:35:23 AM6/14/22
to django-...@googlegroups.com
#33781: Timezone warning visual regression.
----------------------------------+------------------------------------
Reporter: Mariusz Felisiak | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: dev
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
----------------------------------+------------------------------------
Changes (by Carlton Gibson):

* stage: Unreviewed => Accepted


--
Ticket URL: <https://code.djangoproject.com/ticket/33781#comment:2>

Django

unread,
Jun 16, 2022, 1:43:52 PM6/16/22
to django-...@googlegroups.com
#33781: Timezone warning visual regression.
----------------------------------+---------------------------------------
Reporter: Mariusz Felisiak | Owner: Zainab Amir
Type: Bug | Status: assigned

Component: contrib.admin | Version: dev
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
----------------------------------+---------------------------------------
Changes (by Zainab Amir):

* owner: nobody => Zainab Amir
* status: new => assigned


--
Ticket URL: <https://code.djangoproject.com/ticket/33781#comment:3>

Django

unread,
Jun 28, 2022, 3:59:56 AM6/28/22
to django-...@googlegroups.com
#33781: Timezone warning visual regression.
----------------------------------+------------------------------------
Reporter: Mariusz Felisiak | Owner: (none)
Type: Bug | Status: new

Component: contrib.admin | Version: dev
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
----------------------------------+------------------------------------
Changes (by Zainab Amir):

* owner: Zainab Amir => (none)
* status: assigned => new


--
Ticket URL: <https://code.djangoproject.com/ticket/33781#comment:4>

Django

unread,
Jun 28, 2022, 4:01:12 AM6/28/22
to django-...@googlegroups.com
#33781: Timezone warning visual regression.
----------------------------------+-------------------------------------
Reporter: Mariusz Felisiak | Owner: Yahyaali1
Type: Bug | Status: assigned

Component: contrib.admin | Version: dev
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
----------------------------------+-------------------------------------
Changes (by Yahyaali1):

* owner: nobody => Yahyaali1


* status: new => assigned


--
Ticket URL: <https://code.djangoproject.com/ticket/33781#comment:3>

Django

unread,
Jul 7, 2022, 4:58:59 AM7/7/22
to django-...@googlegroups.com
#33781: Timezone warning visual regression.
-------------------------------------+-------------------------------------
Reporter: Mariusz Felisiak | Owner: Carlton
| Gibson

Type: Bug | Status: assigned
Component: contrib.admin | Version: dev
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Carlton Gibson):

* owner: Yahya Ali => Carlton Gibson
* has_patch: 0 => 1


Comment:

[https://github.com/django/django/pull/15830 PR] adjusting the CSS.

--
Ticket URL: <https://code.djangoproject.com/ticket/33781#comment:4>

Django

unread,
Jul 7, 2022, 5:17:19 AM7/7/22
to django-...@googlegroups.com
#33781: Timezone warning visual regression.
-------------------------------------+-------------------------------------
Reporter: Mariusz Felisiak | Owner: Carlton
| Gibson
Type: Bug | Status: assigned
Component: contrib.admin | Version: dev
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Ready for
| checkin

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* stage: Accepted => Ready for checkin


--
Ticket URL: <https://code.djangoproject.com/ticket/33781#comment:5>

Django

unread,
Jul 7, 2022, 5:32:55 AM7/7/22
to django-...@googlegroups.com
#33781: Timezone warning visual regression.
-------------------------------------+-------------------------------------
Reporter: Mariusz Felisiak | Owner: Carlton
| Gibson
Type: Bug | Status: closed
Component: contrib.admin | Version: dev
Severity: Release blocker | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Carlton Gibson <carlton@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"6f80050496780e2f8a65e2a4374dd6375c9fbfa5" 6f80050]:
{{{
#!CommitTicketReference repository=""
revision="6f80050496780e2f8a65e2a4374dd6375c9fbfa5"
Fixed #33781 -- Restored alignment for admin split-field timezone
warnings.

Regression in f3e2bb0833105f43efc0cc6f19c8465bc1b1a785.
Refs #33750 and #27207.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/33781#comment:6>

Django

unread,
Mar 23, 2023, 5:33:35 AM3/23/23
to django-...@googlegroups.com
#33781: Timezone warning visual regression.
-------------------------------------+-------------------------------------
Reporter: Mariusz Felisiak | Owner: Carlton
| Gibson
Type: Bug | Status: closed
Component: contrib.admin | Version: dev
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------

Comment (by GitHub <noreply@…>):

In [changeset:"73ae8545ae620469550f1adcfe63fb9b9e4f3eb3" 73ae854]:
{{{
#!CommitTicketReference repository=""
revision="73ae8545ae620469550f1adcfe63fb9b9e4f3eb3"
Refs #33781 -- Restored alignment for admin split-field timezone warnings
for RTL languages.

Regression in f3e2bb0833105f43efc0cc6f19c8465bc1b1a785.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/33781#comment:7>

Django

unread,
Mar 23, 2023, 5:33:55 AM3/23/23
to django-...@googlegroups.com
#33781: Timezone warning visual regression.
-------------------------------------+-------------------------------------
Reporter: Mariusz Felisiak | Owner: Carlton
| Gibson
Type: Bug | Status: closed
Component: contrib.admin | Version: dev
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

In [changeset:"12561b70212cfc8035e4ea7c05bf23ca468d96a3" 12561b70]:
{{{
#!CommitTicketReference repository=""
revision="12561b70212cfc8035e4ea7c05bf23ca468d96a3"
[4.2.x] Refs #33781 -- Restored alignment for admin split-field timezone
warnings for RTL languages.

Regression in f3e2bb0833105f43efc0cc6f19c8465bc1b1a785.
Backport of 73ae8545ae620469550f1adcfe63fb9b9e4f3eb3 from main
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/33781#comment:8>

Reply all
Reply to author
Forward
0 new messages