Re: [Django] #34370: IntegerField validators don't work if the database is SQLite, leading to overflow errors

3 views
Skip to first unread message

Django

unread,
Feb 26, 2023, 10:30:46 PM2/26/23
to django-...@googlegroups.com
#34370: IntegerField validators don't work if the database is SQLite, leading to
overflow errors
-------------------------------------+-------------------------------------
Reporter: Alex Urbanowicz | Owner: Mohamed
Type: | Nabil Rady
Cleanup/optimization | Status: assigned
Component: Database layer | Version: 4.1
(models, ORM) |
Severity: Normal | Resolution:
Keywords: IntegerField SQLite | Triage Stage: Accepted
MaxValueValidator |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mohamed Nabil Rady):

* has_patch: 0 => 1


Comment:

I removed the sqlite implementation of `integer_field_range()` so it uses
the base implementation and I added a test, hope this
[https://github.com/django/django/pull/16601 PR] is helpful.

--
Ticket URL: <https://code.djangoproject.com/ticket/34370#comment:5>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Feb 26, 2023, 11:43:52 PM2/26/23
to django-...@googlegroups.com
#34370: IntegerField validators don't work if the database is SQLite, leading to
overflow errors
-------------------------------------+-------------------------------------
Reporter: Alex Urbanowicz | Owner: Mohamed
Type: | Nabil Rady
Cleanup/optimization | Status: assigned
Component: Database layer | Version: 4.1
(models, ORM) |
Severity: Normal | Resolution:
Keywords: IntegerField SQLite | Triage Stage: Accepted
MaxValueValidator |
Has patch: 1 | Needs documentation: 1
Needs tests: 1 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* needs_better_patch: 0 => 1
* needs_tests: 0 => 1
* needs_docs: 0 => 1


--
Ticket URL: <https://code.djangoproject.com/ticket/34370#comment:6>

Django

unread,
Mar 7, 2023, 11:42:56 PM3/7/23
to django-...@googlegroups.com
#34370: IntegerField validators don't work if the database is SQLite, leading to
overflow errors
-------------------------------------+-------------------------------------
Reporter: Alex Urbanowicz | Owner: Mohamed
Type: | Nabil Rady
Cleanup/optimization | Status: assigned
Component: Database layer | Version: 4.1
(models, ORM) |
Severity: Normal | Resolution:
Keywords: IntegerField SQLite | Triage Stage: Accepted
MaxValueValidator |
Has patch: 1 | Needs documentation: 1
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* cc: Sarah Boyce (added)
* needs_better_patch: 1 => 0
* needs_tests: 1 => 0


--
Ticket URL: <https://code.djangoproject.com/ticket/34370#comment:7>

Django

unread,
Mar 8, 2023, 6:26:53 AM3/8/23
to django-...@googlegroups.com
#34370: IntegerField validators don't work if the database is SQLite, leading to
overflow errors
-------------------------------------+-------------------------------------
Reporter: Alex Urbanowicz | Owner: Mohamed
Type: | Nabil Rady
Cleanup/optimization | Status: assigned
Component: Database layer | Version: 4.1
(models, ORM) |
Severity: Normal | Resolution:
Keywords: IntegerField SQLite | Triage Stage: Ready for
MaxValueValidator | checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* needs_docs: 1 => 0
* stage: Accepted => Ready for checkin


--
Ticket URL: <https://code.djangoproject.com/ticket/34370#comment:8>

Django

unread,
Mar 8, 2023, 7:00:44 AM3/8/23
to django-...@googlegroups.com
#34370: IntegerField validators don't work if the database is SQLite, leading to
overflow errors
-------------------------------------+-------------------------------------
Reporter: Alex Urbanowicz | Owner: Mohamed
Type: | Nabil Rady
Cleanup/optimization | Status: closed

Component: Database layer | Version: 4.1
(models, ORM) |
Severity: Normal | Resolution: fixed

Keywords: IntegerField SQLite | Triage Stage: Ready for
MaxValueValidator | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak <felisiak.mariusz@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"32d4b61c313be5169137047e9fb3668da20a5d89" 32d4b61c]:
{{{
#!CommitTicketReference repository=""
revision="32d4b61c313be5169137047e9fb3668da20a5d89"
Fixed #34370 -- Added integer fields validation as 64-bit on SQLite.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/34370#comment:9>

Reply all
Reply to author
Forward
0 new messages