Re: [Django] #34320: Renaming fields with truncated names don't remove old constraints on Oracle.

[Django]

#34320: Renaming fields with truncated names don't remove old constraints on
Oracle.
-------------------------------------+-------------------------------------
Reporter: Georgi Yanchev | Owner: Mohamed
| Nabil Rady
Type: Bug | Status: assigned
Component: Database layer | Version: 4.1
(models, ORM) |
Severity: Normal | Resolution:
Keywords: oracle | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mohamed Nabil Rady):

* owner: nobody => Mohamed Nabil Rady
* status: new => assigned

--
Ticket URL: <https://code.djangoproject.com/ticket/34320#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#34320: Renaming fields with truncated names don't remove old constraints on
Oracle.
-------------------------------------+-------------------------------------
Reporter: Georgi Yanchev | Owner: Mohamed
| Nabil Rady
Type: Bug | Status: assigned
Component: Database layer | Version: 4.1
(models, ORM) |
Severity: Normal | Resolution:
Keywords: oracle | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mohamed Nabil Rady):

* has_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/34320#comment:5>

[Django]

#34320: Renaming fields with truncated names don't remove old constraints on
Oracle.
-------------------------------------+-------------------------------------
Reporter: Georgi Yanchev | Owner: Mohamed
| Nabil Rady
Type: Bug | Status: assigned
Component: Database layer | Version: 4.1
(models, ORM) |
Severity: Normal | Resolution:
Keywords: oracle | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 1 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Mariusz Felisiak):

* needs_tests: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/34320#comment:6>

[Django]

#34320: Renaming fields with truncated names don't remove old constraints on
Oracle.
-------------------------------------+-------------------------------------
Reporter: Georgi Yanchev | Owner: Mohamed
| Nabil Rady
Type: Bug | Status: assigned
Component: Database layer | Version: 4.1
(models, ORM) |
Severity: Normal | Resolution:

Keywords: oracle | Triage Stage: Ready for
| checkin

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* needs_tests: 1 => 0
* stage: Accepted => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/34320#comment:7>

[Django]

#34320: Renaming fields with truncated names don't remove old constraints on
Oracle.
-------------------------------------+-------------------------------------
Reporter: Georgi Yanchev | Owner: Mohamed
| Nabil Rady

Type: Bug | Status: closed

Component: Database layer | Version: 4.1
(models, ORM) |

Severity: Normal | Resolution: fixed

Keywords: oracle | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Mariusz Felisiak <felisiak.mariusz@…>):

* status: assigned => closed
* resolution: => fixed

Comment:

In [changeset:"6bdc3c58b65eb32fd63cd41849f00a17a36b4473" 6bdc3c58]:
{{{
#!CommitTicketReference repository=""
revision="6bdc3c58b65eb32fd63cd41849f00a17a36b4473"
Fixed #34320 -- Make sure constraints names are obtained from truncated
columns names.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/34320#comment:8>

[Django]

#34320: Renaming fields with truncated names don't remove old constraints on
Oracle.
-------------------------------------+-------------------------------------
Reporter: Georgi Yanchev | Owner: Mohamed
| Nabil Rady
Type: Bug | Status: closed
Component: Database layer | Version: 4.1
(models, ORM) |
Severity: Normal | Resolution: fixed
Keywords: oracle | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

In [changeset:"3b09f3555859495ca0d130712d240fb61493739e" 3b09f355]:
{{{
#!CommitTicketReference repository=""
revision="3b09f3555859495ca0d130712d240fb61493739e"
[4.2.x] Fixed #34320 -- Make sure constraints names are obtained from
truncated columns names.

Backport of 6bdc3c58b65eb32fd63cd41849f00a17a36b4473 from main
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/34320#comment:9>

[Django]

#34320: Renaming fields with truncated names don't remove old constraints on
Oracle.
-------------------------------------+-------------------------------------
Reporter: Georgi Yanchev | Owner: Mohamed
| Nabil Rady
Type: Bug | Status: closed
Component: Database layer | Version: 4.1
(models, ORM) |
Severity: Normal | Resolution: fixed
Keywords: oracle | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by GitHub <noreply@…>):

In [changeset:"40e88ae8c899bcae3a9520f7a6519dd178185f85" 40e88ae]:
{{{
#!CommitTicketReference repository=""
revision="40e88ae8c899bcae3a9520f7a6519dd178185f85"
Refs #34320 -- Added skipIf for a test requiring check constraints.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/34320#comment:10>

[Django]

#34320: Renaming fields with truncated names don't remove old constraints on
Oracle.
-------------------------------------+-------------------------------------
Reporter: Georgi Yanchev | Owner: Mohamed
| Nabil Rady
Type: Bug | Status: closed
Component: Database layer | Version: 4.1
(models, ORM) |
Severity: Normal | Resolution: fixed
Keywords: oracle | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

In [changeset:"fae76b81ce6d13245abc42752f0a82f16a9ba35f" fae76b81]:
{{{
#!CommitTicketReference repository=""
revision="fae76b81ce6d13245abc42752f0a82f16a9ba35f"
[4.2.x] Refs #34320 -- Added skipIf for a test requiring check
constraints.

Backport of 40e88ae8c899bcae3a9520f7a6519dd178185f85 from main
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/34320#comment:11>

[Django]

#34320: Renaming fields with truncated names don't remove old constraints on
Oracle.
-------------------------------------+-------------------------------------
Reporter: Georgi Yanchev | Owner: Mohamed
| Nabil Rady
Type: Bug | Status: closed
Component: Database layer | Version: 4.1
(models, ORM) |
Severity: Normal | Resolution: fixed
Keywords: oracle | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by GitHub <noreply@…>):

In [changeset:"9953c804a9375956a542da94665662d306dff48d" 9953c804]:
{{{
#!CommitTicketReference repository=""
revision="9953c804a9375956a542da94665662d306dff48d"
Refs #34320 -- Stopped recreating check constraints when renaming fields.

This also fixes test_rename_field_with_check_to_truncated_name() on
MariaDB 10.5.2+ as ALTER TABLE ... RENAME COLUMN statement doesn't
rename inline constraints.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/34320#comment:12>

[Django]

#34320: Renaming fields with truncated names don't remove old constraints on
Oracle.
-------------------------------------+-------------------------------------
Reporter: Georgi Yanchev | Owner: Mohamed
| Nabil Rady
Type: Bug | Status: closed
Component: Database layer | Version: 4.1
(models, ORM) |
Severity: Normal | Resolution: fixed
Keywords: oracle | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by GitHub <noreply@…>):

In [changeset:"fec4ed0a250841f41066cbbc9581993ba378d268" fec4ed0a]:
{{{
#!CommitTicketReference repository=""
revision="fec4ed0a250841f41066cbbc9581993ba378d268"
[4.2.x] Refs #34320 -- Skipped
SchemaTests.test_rename_field_with_check_to_truncated_name on MariaBD
10.5.2+.

This crashes since MariaDB was bumped to 10.5 on Jenkins.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/34320#comment:13>