Re: [Django] #34325: Clarify PercentRank() description.

9 views
Skip to first unread message

Django

unread,
Feb 10, 2023, 6:35:48 AM2/10/23
to django-...@googlegroups.com
#34325: Clarify PercentRank() description.
--------------------------------------+------------------------------------
Reporter: dennisvang | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Documentation | Version: 4.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------

Comment (by dennisvang):

Replying to [comment:5 Mariusz Felisiak]:
> Agreed, "relative rank" is less confusing. Would you like to prepare a
patch?

Certainly. Please have a look at
https://github.com/django/django/pull/16539

I also replaced "Percent Rank" in the corresponding *table* by "Relative
Rank," but I'm not sure if that's necessary. An alternative would be to
use "PercentRank," without the space, to match the name of the function.

--
Ticket URL: <https://code.djangoproject.com/ticket/34325#comment:6>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Feb 10, 2023, 8:10:17 AM2/10/23
to django-...@googlegroups.com
#34325: Clarify PercentRank() description.
-------------------------------------+-------------------------------------
Reporter: dennisvang | Owner:
Type: | dennisvang
Cleanup/optimization | Status: assigned

Component: Documentation | Version: 4.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* owner: nobody => dennisvang
* status: new => assigned
* has_patch: 0 => 1
* stage: Accepted => Ready for checkin


--
Ticket URL: <https://code.djangoproject.com/ticket/34325#comment:7>

Django

unread,
Feb 10, 2023, 1:07:34 PM2/10/23
to django-...@googlegroups.com
#34325: Clarify PercentRank() description.
-------------------------------------+-------------------------------------
Reporter: dennisvang | Owner:
Type: | dennisvang
Cleanup/optimization | Status: closed
Component: Documentation | Version: 4.1
Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak <felisiak.mariusz@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"7bb741d787ba360a9f0d490db92e22e0d28204ed" 7bb741d7]:
{{{
#!CommitTicketReference repository=""
revision="7bb741d787ba360a9f0d490db92e22e0d28204ed"
Fixed #34325 -- Corrected wording in PercentRank() docs.

This is consistent with the terminology used for the percent_rank()
function in SQLite docs and PostgreSQL docs.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/34325#comment:8>

Django

unread,
Feb 10, 2023, 1:07:44 PM2/10/23
to django-...@googlegroups.com
#34325: Clarify PercentRank() description.
-------------------------------------+-------------------------------------
Reporter: dennisvang | Owner:
Type: | dennisvang
Cleanup/optimization | Status: closed
Component: Documentation | Version: 4.1
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

In [changeset:"4a89aa25c91e520c247aee428782274dcf10ffd0" 4a89aa25]:
{{{
#!CommitTicketReference repository=""
revision="4a89aa25c91e520c247aee428782274dcf10ffd0"
[4.2.x] Fixed #34325 -- Corrected wording in PercentRank() docs.

This is consistent with the terminology used for the percent_rank()
function in SQLite docs and PostgreSQL docs.

Backport of 7bb741d787ba360a9f0d490db92e22e0d28204ed from main
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/34325#comment:9>

Reply all
Reply to author
Forward
0 new messages