[Django] #34316: Visual regressions in admin's change password form
Django
--------------------------------------------+------------------------
Reporter: Mariusz Felisiak | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 4.2
Severity: Release blocker | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
--------------------------------------------+------------------------
I noticed two visual regressions in
96a598356a9ea8c2c05b22cadc12e256a3b295fd:
- There is no gap before the ''"this form"'' link on the ''"Change user"''
form:
- Inputs are in the wrong place (as far as I'm aware `<div>...</div>` is
missing around `<label>` and `<input>`) on the ''"Change password"'' form:
--
Ticket URL: <https://code.djangoproject.com/ticket/34316>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: Mariusz Felisiak | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 4.2
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Mariusz Felisiak):
* Attachment "this_form_after.png" added.
Django
----------------------------------+--------------------------------------
Reporter: Mariusz Felisiak | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 4.2
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
----------------------------------+--------------------------------------
Changes (by Mariusz Felisiak):
* Attachment "change_password_after.png" added.
Django
----------------------------------+--------------------------------------
Reporter: Mariusz Felisiak | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 4.2
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
----------------------------------+--------------------------------------
Changes (by Mariusz Felisiak):
* Attachment "password_change_after.png" added.
Django
----------------------------------+--------------------------------------
Reporter: Mariusz Felisiak | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 4.2
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
----------------------------------+--------------------------------------
Old description:
> I noticed two visual regressions in
> 96a598356a9ea8c2c05b22cadc12e256a3b295fd:
> - There is no gap before the ''"this form"'' link on the ''"Change
> user"'' form:
>
> - Inputs are in the wrong place (as far as I'm aware `<div>...</div>` is
> missing around `<label>` and `<input>`) on the ''"Change password"''
> form:
New description:
I noticed two visual regressions in
96a598356a9ea8c2c05b22cadc12e256a3b295fd:
- There is no gap before the ''"this form"'' link on the ''"Change user"''
form:
[[Image(this_form_after.png)]]
- Inputs are in the wrong place (as far as I'm aware `<div>...</div>` is
missing around `<label>` and `<input>`) on the ''"Change password"'' form:
[[Image(change_password_after.png)]]
- Inputs are in the wrong place (as far as I'm aware `<div>...</div>` is
missing around `<label>` and `<input>`) on the ''"Password change"'' form:
[[Image(password_change_after.png)]]
--
--
Ticket URL: <https://code.djangoproject.com/ticket/34316#comment:1>
Django
----------------------------------+--------------------------------------
Type: Bug | Status: assigned
Component: contrib.admin | Version: 4.2
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
----------------------------------+--------------------------------------
* owner: nobody => ulr0
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/34316#comment:2>
Django
----------------------------------+--------------------------------------
Reporter: Mariusz Felisiak | Owner: ulr0
Type: Bug | Status: assigned
Component: contrib.admin | Version: 4.2
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
----------------------------------+--------------------------------------
* cc: Sarah Boyce (added)
--
Ticket URL: <https://code.djangoproject.com/ticket/34316#comment:3>
Django
----------------------------------+------------------------------------
Type: Bug | Status: assigned
Component: contrib.admin | Version: 4.2
Severity: Release blocker | Resolution:
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
----------------------------------+------------------------------------
* stage: Unreviewed => Accepted
--
Ticket URL: <https://code.djangoproject.com/ticket/34316#comment:4>
Django
Reporter: Mariusz Felisiak | Owner: Sarah Boyce
Type: Bug | Status: assigned
Component: contrib.admin | Version: 4.2
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Sarah Boyce):
* owner: ulr0 => Sarah Boyce
* has_patch: 0 => 1
Comment:
https://github.com/django/django/pull/16548
--
Ticket URL: <https://code.djangoproject.com/ticket/34316#comment:5>
Django
----------------------------------+---------------------------------------
Reporter: Mariusz Felisiak | Owner: Sarah Boyce
Type: Bug | Status: assigned
Component: contrib.admin | Version: 4.2
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
----------------------------------+---------------------------------------
* needs_better_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/34316#comment:6>
Django
Reporter: Mariusz Felisiak | Owner: Sarah
| Boyce
Type: Bug | Status: assigned
Component: contrib.admin | Version: 4.2
Severity: Release blocker | Resolution:
| checkin
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Mariusz Felisiak):
* needs_better_patch: 1 => 0
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/34316#comment:7>
Django
-------------------------------------+-------------------------------------
Reporter: Mariusz Felisiak | Owner: Sarah
| Boyce
Component: contrib.admin | Version: 4.2
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"e67804668115fd388e7554c6a809bd409f70adfe" e6780466]:
{{{
#!CommitTicketReference repository=""
revision="e67804668115fd388e7554c6a809bd409f70adfe"
Fixed #34316 -- Fixed layout of admin password change forms and help
texts.
Regression in 96a598356a9ea8c2c05b22cadc12e256a3b295fd.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/34316#comment:8>
Django
-------------------------------------+-------------------------------------
Reporter: Mariusz Felisiak | Owner: Sarah
| Boyce
Type: Bug | Status: closed
Component: contrib.admin | Version: 4.2
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Mariusz Felisiak <felisiak.mariusz@…>):
In [changeset:"5510a12c90115e1a4ba7b4b8925c05a908855732" 5510a12c]:
{{{
#!CommitTicketReference repository=""
revision="5510a12c90115e1a4ba7b4b8925c05a908855732"
[4.2.x] Fixed #34316 -- Fixed layout of admin password change forms and
help texts.
Regression in 96a598356a9ea8c2c05b22cadc12e256a3b295fd.
Backport of e67804668115fd388e7554c6a809bd409f70adfe from main
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/34316#comment:9>
Django
-------------------------------------+-------------------------------------
Reporter: Mariusz Felisiak | Owner: Sarah
| Boyce
Type: Bug | Status: closed
Component: contrib.admin | Version: 4.2
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by GitHub <noreply@…>):
In [changeset:"39d1e45227e060746ed461fddde80fa2b6cf0dcd" 39d1e45]:
{{{
#!CommitTicketReference repository=""
revision="39d1e45227e060746ed461fddde80fa2b6cf0dcd"
Refs #34316 -- Fixed displaying error lists in admin password change forms
on small screens.
Follow up to e67804668115fd388e7554c6a809bd409f70adfe.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/34316#comment:10>
Django
-------------------------------------+-------------------------------------
Reporter: Mariusz Felisiak | Owner: Sarah
| Boyce
Type: Bug | Status: closed
Component: contrib.admin | Version: 4.2
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Mariusz Felisiak <felisiak.mariusz@…>):
In [changeset:"b85dd83194878cb520f1cb152db4e5f524ffbcf0" b85dd83]:
{{{
#!CommitTicketReference repository=""
revision="b85dd83194878cb520f1cb152db4e5f524ffbcf0"
[4.2.x] Refs #34316 -- Fixed displaying error lists in admin password
change forms on small screens.
Follow up to e67804668115fd388e7554c6a809bd409f70adfe.
Backport of 39d1e45227e060746ed461fddde80fa2b6cf0dcd from main
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/34316#comment:11>
Django
-------------------------------------+-------------------------------------
Reporter: Mariusz Felisiak | Owner: Sarah
| Boyce
Type: Bug | Status: closed
Component: contrib.admin | Version: 4.2
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by GitHub <noreply@…>):
In [changeset:"f5c5c571d3b87a78d005ea6f21959388d1747696" f5c5c57]:
{{{
#!CommitTicketReference repository=""
revision="f5c5c571d3b87a78d005ea6f21959388d1747696"
Refs #34316 -- Fixed layout of admin password change forms and help texts
for RTL languages.
Regression in 96a598356a9ea8c2c05b22cadc12e256a3b295fd.
Follow up to e67804668115fd388e7554c6a809bd409f70adfe and
39d1e45227e060746ed461fddde80fa2b6cf0dcd.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/34316#comment:12>
Django
-------------------------------------+-------------------------------------
Reporter: Mariusz Felisiak | Owner: Sarah
| Boyce
Type: Bug | Status: closed
Component: contrib.admin | Version: 4.2
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Mariusz Felisiak <felisiak.mariusz@…>):
In [changeset:"ded3334af6de74214ba3f985e68749e3c47ffd16" ded3334]:
{{{
#!CommitTicketReference repository=""
revision="ded3334af6de74214ba3f985e68749e3c47ffd16"
[4.2.x] Refs #34316 -- Fixed layout of admin password change forms and
help texts for RTL languages.
Regression in 96a598356a9ea8c2c05b22cadc12e256a3b295fd.
Follow up to e67804668115fd388e7554c6a809bd409f70adfe and
39d1e45227e060746ed461fddde80fa2b6cf0dcd.
Backport of f5c5c571d3b87a78d005ea6f21959388d1747696 from main
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/34316#comment:13>