[Django] #34307: Issue with min_num logic in InlineFormsets

11 views
Skip to first unread message

Django

unread,
Feb 1, 2023, 3:00:03 PM2/1/23
to django-...@googlegroups.com
#34307: Issue with min_num logic in InlineFormsets
--------------------------------------+------------------------
Reporter: GeekGawd | Owner: nobody
Type: Bug | Status: new
Component: Forms | Version: 4.1
Severity: Normal | Keywords: forms
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
--------------------------------------+------------------------
So, seeing the Django code there are two fields min_num and extra keyword.
There is a straightforward coorelation between the two that is, if min_num
is provided then extra should atleast be equal or greater than min_num.

This is causing [https://github.com/wagtail/wagtail/issues/9391 ordering
issue] in Wagtail Admin Form page, where initial extra forms are not
created because extra is None but min_num arguement is passed, this leads
to ordering issue in the inline formsets.

I would like to work on this issue but would like some guidance, thank
you!

--
Ticket URL: <https://code.djangoproject.com/ticket/34307>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Feb 1, 2023, 3:51:16 PM2/1/23
to django-...@googlegroups.com
#34307: Issue with min_num logic in InlineFormsets
--------------------------+--------------------------------------

Reporter: GeekGawd | Owner: nobody
Type: Bug | Status: new
Component: Forms | Version: 4.1
Severity: Normal | Resolution:

Keywords: forms | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------+--------------------------------------

Comment (by Tim Graham):

I didn't read the linked issue, but from what's here, I'm not sure you've
described the problem sufficiently. Can you flesh it out with some example
code that doesn't involve Wagtail?

--
Ticket URL: <https://code.djangoproject.com/ticket/34307#comment:1>

Django

unread,
Feb 1, 2023, 4:06:02 PM2/1/23
to django-...@googlegroups.com
#34307: Issue with min_num logic in InlineFormsets
--------------------------+-----------------------------------------
Reporter: GeekGawd | Owner: Rahmat Faisal
Type: Bug | Status: assigned

Component: Forms | Version: 4.1
Severity: Normal | Resolution:
Keywords: forms | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------+-----------------------------------------
Changes (by Rahmat Faisal):

* owner: nobody => Rahmat Faisal
* status: new => assigned


--
Ticket URL: <https://code.djangoproject.com/ticket/34307#comment:2>

Django

unread,
Feb 1, 2023, 4:08:02 PM2/1/23
to django-...@googlegroups.com
#34307: Issue with min_num logic in InlineFormsets
--------------------------+--------------------------------------
Reporter: GeekGawd | Owner: (none)
Type: Bug | Status: new

Component: Forms | Version: 4.1
Severity: Normal | Resolution:
Keywords: forms | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------+--------------------------------------
Changes (by Rahmat Faisal):

* owner: Rahmat Faisal => (none)
* status: assigned => new


--
Ticket URL: <https://code.djangoproject.com/ticket/34307#comment:3>

Django

unread,
Feb 1, 2023, 4:09:27 PM2/1/23
to django-...@googlegroups.com
#34307: Issue with min_num logic in InlineFormsets
--------------------------+--------------------------------------
Reporter: GeekGawd | Owner: (none)
Type: Bug | Status: new
Component: Forms | Version: 4.1
Severity: Normal | Resolution:
Keywords: forms | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------+--------------------------------------

Comment (by Rahmat Faisal):

can u put example code from django/wagtail

--
Ticket URL: <https://code.djangoproject.com/ticket/34307#comment:4>

Django

unread,
Feb 2, 2023, 12:40:38 AM2/2/23
to django-...@googlegroups.com
#34307: Issue with min_num logic in InlineFormsets
--------------------------+--------------------------------------
Reporter: GeekGawd | Owner: nobody
Type: Bug | Status: closed
Component: Forms | Version: 4.1
Severity: Normal | Resolution: needsinfo

Keywords: forms | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------+--------------------------------------
Changes (by Mariusz Felisiak):

* status: new => closed
* resolution: => needsinfo


Comment:

Please reopen the ticket if you can provide a sample project (without
Wagtail) which reproduces the issue.
The ordering field is only pre-filled for initial forms from
a19ed8aea395e8e07164ff7d85bd7dff2f24edca (2008).

--
Ticket URL: <https://code.djangoproject.com/ticket/34307#comment:2>

Reply all
Reply to author
Forward
0 new messages