Re: [Django] #34294: File locking fails if argtypes redefined on Windows.

[Django]

#34294: File locking fails if argtypes redefined on Windows.
-------------------------------------+-------------------------------------
Reporter: Simon Sawicki | Owner: Simon
Type: | Sawicki
Cleanup/optimization | Status: assigned
Component: File | Version: dev
uploads/storage |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Simon Sawicki):

This caused https://github.com/ytdl-org/youtube-dl/issues/21545 for
example, since yt-dl (possibly also other projects) also mutates that
global instance. I will open a PR asap, thank you for the quick triage!

--
Ticket URL: <https://code.djangoproject.com/ticket/34294#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#34294: File locking fails if argtypes redefined on Windows.
-------------------------------------+-------------------------------------
Reporter: Simon Sawicki | Owner: Simon
Type: | Sawicki
Cleanup/optimization | Status: assigned
Component: File | Version: dev
uploads/storage |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Simon Sawicki):

* has_patch: 0 => 1

Comment:

Relevant [https://github.com/django/django/pull/16503 PR].

--
Ticket URL: <https://code.djangoproject.com/ticket/34294#comment:4>

[Django]

#34294: File locking fails if argtypes redefined on Windows.
-------------------------------------+-------------------------------------
Reporter: Simon Sawicki | Owner: Simon
Type: | Sawicki
Cleanup/optimization | Status: assigned
Component: File | Version: dev
uploads/storage |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Keryn Knight):

For historic cross-referencing purposes, the aforementioned youtube-dl
issue ultimately ended up tracked as #30603.

--
Ticket URL: <https://code.djangoproject.com/ticket/34294#comment:5>

[Django]

#34294: File locking fails if argtypes redefined on Windows.
-------------------------------------+-------------------------------------
Reporter: Simon Sawicki | Owner: Simon
Type: | Sawicki

Cleanup/optimization | Status: closed

Component: File | Version: dev
uploads/storage |

Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by GitHub <noreply@…>):

* status: assigned => closed
* resolution: => fixed

Comment:

In [changeset:"7eb5391b71f473dd13abdaaef143a5509160487f" 7eb5391b]:
{{{
#!CommitTicketReference repository=""
revision="7eb5391b71f473dd13abdaaef143a5509160487f"
Fixed #34294 -- Protected django.core.files.locks against argtypes
redefinition on Windows.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/34294#comment:6>

[Django]

#34294: File locking fails if argtypes redefined on Windows.
-------------------------------------+-------------------------------------
Reporter: Simon Sawicki | Owner: Simon

| Sawicki
Type: Bug | Status: closed

Component: File | Version: dev
uploads/storage |
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Mariusz Felisiak):

* type: Cleanup/optimization => Bug

--
Ticket URL: <https://code.djangoproject.com/ticket/34294#comment:7>

[Django]

#34294: File locking fails if argtypes redefined on Windows.
-------------------------------------+-------------------------------------
Reporter: Simon Sawicki | Owner: Simon
| Sawicki
Type: Bug | Status: closed
Component: File | Version: dev
uploads/storage |
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

In [changeset:"9eae81724d80b3b2901377f63ee560f9c56ffd63" 9eae817]:
{{{
#!CommitTicketReference repository=""
revision="9eae81724d80b3b2901377f63ee560f9c56ffd63"
[4.2.x] Fixed #34294 -- Protected django.core.files.locks against argtypes
redefinition on Windows.

Backport of 7eb5391b71f473dd13abdaaef143a5509160487f from main
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/34294#comment:8>