[Django] #34287: JavaScript code blocks in the documentation have poor contrast when light theme is enabled

7 views
Skip to first unread message

Django

unread,
Jan 23, 2023, 9:38:47 PM1/23/23
to django-...@googlegroups.com
#34287: JavaScript code blocks in the documentation have poor contrast when light
theme is enabled
---------------------------------------------+------------------------
Reporter: Hrushikesh Vaidya | Owner: nobody
Type: Uncategorized | Status: new
Component: Documentation | Version: 4.1
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 1 |
---------------------------------------------+------------------------
For JavaScript code blocks in the documentation, even when the theme is
set to "light" using the theme button in the navbar,
`@media(prefers-color-scheme: dark)` styles are applied.

When the theme is explicitly set to dark, `html[data-theme="dark"]` styles
are applied (as expected), and when the theme is
set to system preference, and the system preference is dark, `@media
(prefers-color-scheme: dark)` styles are applied (as expected),
but when the theme is switched to be light, the applied styles don't
change.

--
Ticket URL: <https://code.djangoproject.com/ticket/34287>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Jan 23, 2023, 9:39:34 PM1/23/23
to django-...@googlegroups.com
#34287: JavaScript code blocks in the documentation have poor contrast when light
theme is enabled
-----------------------------------+--------------------------------------

Reporter: Hrushikesh Vaidya | Owner: nobody
Type: Uncategorized | Status: new
Component: Documentation | Version: 4.1
Severity: Normal | Resolution:

Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-----------------------------------+--------------------------------------
Changes (by Hrushikesh Vaidya):

* Attachment "docs-light-theme.jpg" added.

When theme is set to be light

Django

unread,
Jan 23, 2023, 9:40:12 PM1/23/23
to django-...@googlegroups.com
#34287: JavaScript code blocks in the documentation have poor contrast when light
theme is enabled
-----------------------------------+--------------------------------------
Reporter: Hrushikesh Vaidya | Owner: nobody
Type: Uncategorized | Status: new
Component: Documentation | Version: 4.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-----------------------------------+--------------------------------------
Changes (by Hrushikesh Vaidya):

* Attachment "docs-dark-theme.jpg" added.

When theme is set to be dark

Django

unread,
Jan 23, 2023, 11:24:19 PM1/23/23
to django-...@googlegroups.com
#34287: JavaScript code blocks in the documentation have poor contrast when light
theme is enabled
-----------------------------------+--------------------------------------
Reporter: Hrushikesh Vaidya | Owner: nobody
Type: Uncategorized | Status: closed
Component: Documentation | Version: 4.1
Severity: Normal | Resolution: invalid

Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-----------------------------------+--------------------------------------
Changes (by Mariusz Felisiak):

* status: new => closed
* resolution: => invalid


Comment:

Thanks for this report. First of all, it works for me (on Firefox).
Secondly docs CSS styling issues should be reported on the
[https://github.com/django/djangoproject.com/issues djangoproject.com
issue tracker].

--
Ticket URL: <https://code.djangoproject.com/ticket/34287#comment:1>

Reply all
Reply to author
Forward
0 new messages