[Django] #34281: select filter javascript uses gettext when it should use ngettext

3 views
Skip to first unread message

Django

unread,
Jan 22, 2023, 11:37:17 AM1/22/23
to django-...@googlegroups.com
#34281: select filter javascript uses gettext when it should use ngettext
---------------------------------------------+------------------------
Reporter: Florian Apolloner | Owner: nobody
Type: Bug | Status: new
Component: Uncategorized | Version: 4.0
Severity: Release blocker | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 1
UI/UX: 0 |
---------------------------------------------+------------------------
I just stumbled upon this during updating translations:

https://github.com/django/django/blob/e1a093f8cba66574ce516a7510ded5196cdc6416/django/contrib/admin/static/admin/js/SelectFilter2.js#L210

I think this should use `ngettext` in case the count is 1. I am marking
this as a release blocker since it was introduced in 4.2

--
Ticket URL: <https://code.djangoproject.com/ticket/34281>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Jan 22, 2023, 11:46:43 AM1/22/23
to django-...@googlegroups.com
#34281: select filter javascript uses gettext when it should use ngettext
-----------------------------------+--------------------------------------

Reporter: Florian Apolloner | Owner: nobody
Type: Bug | Status: closed
Component: Uncategorized | Version: 4.0
Severity: Release blocker | Resolution: duplicate

Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-----------------------------------+--------------------------------------
Changes (by Florian Apolloner):

* status: new => closed
* resolution: => duplicate


Comment:

Dupe of #34278

--
Ticket URL: <https://code.djangoproject.com/ticket/34281#comment:1>

Reply all
Reply to author
Forward
0 new messages