[Django] #34278: Missing ngettext call in SelectFilter2.js

12 views
Skip to first unread message

Django

unread,
Jan 21, 2023, 11:14:29 AM1/21/23
to django-...@googlegroups.com
#34278: Missing ngettext call in SelectFilter2.js
------------------------------------------------+------------------------
Reporter: Claude Paroz | Owner: nobody
Type: Bug | Status: new
Component: Internationalization | Version: 4.2
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------------------+------------------------
The new translatable string `'%s selected options not visible'` should be
ngettextized (nice word!).

--
Ticket URL: <https://code.djangoproject.com/ticket/34278>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Jan 21, 2023, 11:18:05 AM1/21/23
to django-...@googlegroups.com
#34278: Missing ngettext call in SelectFilter2.js
-------------------------------------+-------------------------------------

Reporter: Claude Paroz | Owner: nobody
Type: Bug | Status: new
Component: | Version: 4.2
Internationalization |
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Claude Paroz):

* has_patch: 0 => 1


Comment:

[https://github.com/django/django/pull/16494 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/34278#comment:1>

Django

unread,
Jan 21, 2023, 2:01:27 PM1/21/23
to django-...@googlegroups.com
#34278: Missing ngettext call in SelectFilter2.js
-------------------------------------+-------------------------------------
Reporter: Claude Paroz | Owner: Claude
| Paroz
Type: Bug | Status: assigned
Component: | Version: 4.2
Internationalization |
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* owner: nobody => Claude Paroz
* status: new => assigned
* severity: Normal => Release blocker
* stage: Unreviewed => Accepted


Comment:

Good catch +1

--
Ticket URL: <https://code.djangoproject.com/ticket/34278#comment:2>

Django

unread,
Jan 23, 2023, 12:12:39 AM1/23/23
to django-...@googlegroups.com
#34278: Missing ngettext call in SelectFilter2.js
-------------------------------------+-------------------------------------
Reporter: Claude Paroz | Owner: Claude
| Paroz
Type: Bug | Status: assigned
Component: | Version: 4.2
Internationalization |
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Ready for
| checkin

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* stage: Accepted => Ready for checkin


--
Ticket URL: <https://code.djangoproject.com/ticket/34278#comment:3>

Django

unread,
Jan 23, 2023, 12:38:43 AM1/23/23
to django-...@googlegroups.com
#34278: Missing ngettext call in SelectFilter2.js
-------------------------------------+-------------------------------------
Reporter: Claude Paroz | Owner: Claude
| Paroz
Type: Bug | Status: closed
Component: | Version: 4.2
Internationalization |
Severity: Release blocker | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak <felisiak.mariusz@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"e3a4cee081cf60650b8824f0646383b79cb110e7" e3a4cee]:
{{{
#!CommitTicketReference repository=""
revision="e3a4cee081cf60650b8824f0646383b79cb110e7"
Fixed #34278 -- Made translatable string plural-aware in SelectFilter2.js.

Bug in be63c78760924e1335603c36babd0ad6cfaea3c4.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/34278#comment:4>

Django

unread,
Jan 23, 2023, 12:39:21 AM1/23/23
to django-...@googlegroups.com
#34278: Missing ngettext call in SelectFilter2.js
-------------------------------------+-------------------------------------
Reporter: Claude Paroz | Owner: Claude
| Paroz
Type: Bug | Status: closed
Component: | Version: 4.2
Internationalization |
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

In [changeset:"0fd5d16c222583dd68128b70b17e461d4decda8c" 0fd5d16c]:
{{{
#!CommitTicketReference repository=""
revision="0fd5d16c222583dd68128b70b17e461d4decda8c"
[4.2.x] Fixed #34278 -- Made translatable string plural-aware in
SelectFilter2.js.

Bug in be63c78760924e1335603c36babd0ad6cfaea3c4.

Backport of e3a4cee081cf60650b8824f0646383b79cb110e7 from main
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/34278#comment:5>

Reply all
Reply to author
Forward
0 new messages