Re: [Django] #34272: floatformat() crashes on "0.00".

0 views
Skip to first unread message

Django

unread,
Jan 18, 2023, 5:04:33 PM1/18/23
to django-...@googlegroups.com
#34272: floatformat() crashes on "0.00".
---------------------------------+-----------------------------------------
Reporter: Andrii Lahuta | Owner: David Wobrock
Type: Bug | Status: assigned
Component: Template system | Version: 4.2
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+-----------------------------------------
Changes (by David Wobrock):

* cc: David Wobrock (added)
* owner: nobody => David Wobrock
* has_patch: 0 => 1
* status: new => assigned


Comment:

[https://github.com/django/django/pull/16485 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/34272#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Jan 19, 2023, 2:51:25 AM1/19/23
to django-...@googlegroups.com
#34272: floatformat() crashes on "0.00".
---------------------------------+-----------------------------------------
Reporter: Andrii Lahuta | Owner: David Wobrock
Type: Bug | Status: assigned
Component: Template system | Version: 4.2
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
---------------------------------+-----------------------------------------
Changes (by Mariusz Felisiak):

* needs_better_patch: 0 => 1


--
Ticket URL: <https://code.djangoproject.com/ticket/34272#comment:3>

Django

unread,
Jan 19, 2023, 4:17:05 AM1/19/23
to django-...@googlegroups.com
#34272: floatformat() crashes on "0.00".
-------------------------------------+-------------------------------------

Reporter: Andrii Lahuta | Owner: David
| Wobrock
Type: Bug | Status: assigned
Component: Template system | Version: 4.2
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Ready for
| checkin

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* needs_better_patch: 1 => 0
* stage: Accepted => Ready for checkin


--
Ticket URL: <https://code.djangoproject.com/ticket/34272#comment:4>

Django

unread,
Jan 19, 2023, 4:47:51 AM1/19/23
to django-...@googlegroups.com
#34272: floatformat() crashes on "0.00".
-------------------------------------+-------------------------------------
Reporter: Andrii Lahuta | Owner: David
| Wobrock
Type: Bug | Status: closed

Component: Template system | Version: 4.2
Severity: Release blocker | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak <felisiak.mariusz@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"4b066bde692078b194709d517b27e55defae787c" 4b066bd]:
{{{
#!CommitTicketReference repository=""
revision="4b066bde692078b194709d517b27e55defae787c"
Fixed #34272 -- Fixed floatformat crash on zero with trailing zeros to
zero decimal places.

Regression in 08c5a787262c1ae57f6517d4574b54a5fcaad124.

Thanks Andrii Lahuta for the report.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/34272#comment:5>

Django

unread,
Jan 19, 2023, 4:48:17 AM1/19/23
to django-...@googlegroups.com
#34272: floatformat() crashes on "0.00".
-------------------------------------+-------------------------------------
Reporter: Andrii Lahuta | Owner: David
| Wobrock
Type: Bug | Status: closed
Component: Template system | Version: 4.2
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

In [changeset:"3b6f3073444dd4fdfc769f995f920a4d5336fcf3" 3b6f3073]:
{{{
#!CommitTicketReference repository=""
revision="3b6f3073444dd4fdfc769f995f920a4d5336fcf3"
[4.2.x] Fixed #34272 -- Fixed floatformat crash on zero with trailing


zeros to zero decimal places.

Regression in 08c5a787262c1ae57f6517d4574b54a5fcaad124.

Thanks Andrii Lahuta for the report.

Backport of 4b066bde692078b194709d517b27e55defae787c from main
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/34272#comment:6>

Reply all
Reply to author
Forward
0 new messages