[Django] #34266: Add ClosestPoint function to GeoDjango
Django
-----------------------------------------+------------------------
Reporter: Niccolò Mineo | Owner: nobody
Type: New feature | Status: new
Component: GIS | Version: 4.1
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 1
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-----------------------------------------+------------------------
I'd like to suggest adding the ClosestPoint function to the bunch to
encourage people to prefer its use in a number of situations over
cumbersome solutions.
[https://github.com/django/django/pull/16449]
--
Ticket URL: <https://code.djangoproject.com/ticket/34266>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: Niccolò Mineo | Owner: nobody
Type: New feature | Status: new
Component: GIS | Version: 4.1
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Carlton Gibson):
* cc: Paolo Melchiorre (added)
* stage: Unreviewed => Accepted
Comment:
OK, I'll accept this.
At the general level we try include only those function that have wide
utility, in order to keep the scope manageable. (It's normally quite easy
to add a needed function wrapper to a user's project.)
This seems quite handy to me, so +1, but I'm not a big GeoDjango user up
to now, so CCing Paolo (since you are and you already commented on the
PR.)
--
Ticket URL: <https://code.djangoproject.com/ticket/34266#comment:1>
Django
-------------------------------+------------------------------------
Reporter: Niccolò Mineo | Owner: nobody
Type: New feature | Status: new
Component: GIS | Version: 4.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+------------------------------------
Comment (by Paolo Melchiorre):
It's fine for me to continue reviewing this PR, I wait for Nicco to
integrate the documentation and proceed to review again.
--
Ticket URL: <https://code.djangoproject.com/ticket/34266#comment:2>
Django
-------------------------------+------------------------------------
Reporter: Niccolò Mineo | Owner: nobody
Type: New feature | Status: new
Component: GIS | Version: 4.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+------------------------------------
Old description:
> I'd like to suggest adding the ClosestPoint function to the bunch to
> encourage people to prefer its use in a number of situations over
> cumbersome solutions.
>
> [https://github.com/django/django/pull/16449]
New description:
I've just integrated the change in the release log:
[https://github.com/django/django/pull/16449]. Thanks to you both.
--
--
Ticket URL: <https://code.djangoproject.com/ticket/34266#comment:3>
Django
-------------------------------+------------------------------------
Reporter: Niccolò Mineo | Owner: nobody
Type: New feature | Status: new
Component: GIS | Version: 4.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+------------------------------------
Comment (by Niccolò Mineo):
Replying to [comment:3 Niccolò Mineo]:
I've just integrated the change in the release log:
https://github.com/django/django/pull/16449. Thanks to you both.
--
Ticket URL: <https://code.djangoproject.com/ticket/34266#comment:4>
Django
-------------------------------+------------------------------------
Reporter: Niccolò Mineo | Owner: nobody
Type: New feature | Status: new
Component: GIS | Version: 4.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+------------------------------------
Old description:
> I've just integrated the change in the release log:
> [https://github.com/django/django/pull/16449]. Thanks to you both.
New description:
I'd like to suggest adding this function to the bunch to encourage people
to prefer its use in a number of situations over cumbersome solutions.
[https://github.com/django/django/pull/16449]
--
--
Ticket URL: <https://code.djangoproject.com/ticket/34266#comment:5>
Django
-------------------------------+------------------------------------
Reporter: Niccolò Mineo | Owner: nobody
Type: New feature | Status: new
Component: GIS | Version: 4.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+------------------------------------
Description changed by Niccolò Mineo:
Old description:
> I'd like to suggest adding this function to the bunch to encourage people
> to prefer its use in a number of situations over cumbersome solutions.
>
> [https://github.com/django/django/pull/16449]
New description:
I'd like to suggest adding this function to the bunch to encourage people
to prefer its use in a number of situations over cumbersome solutions.
https://github.com/django/django/pull/16449
--
--
Ticket URL: <https://code.djangoproject.com/ticket/34266#comment:6>
Django
Reporter: Niccolò Mineo | Owner: Paolo
| Melchiorre
Type: New feature | Status: assigned
Component: GIS | Version: dev
Severity: Normal | Resolution:
Keywords: geodjango, function | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Paolo Melchiorre):
* keywords: => geodjango, function
* owner: nobody => Paolo Melchiorre
* version: 4.1 => dev
* status: new => assigned
* stage: Accepted => Ready for checkin
Comment:
The PR looks to me ready for squash commits and merge.
--
Ticket URL: <https://code.djangoproject.com/ticket/34266#comment:7>
Django
-------------------------------------+-------------------------------------
Reporter: Niccolò Mineo | Owner: Paolo
| Melchiorre
Component: GIS | Version: dev
Severity: Normal | Resolution: fixed
Keywords: geodjango, function | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"79c298c9ceb8e386f172330236f04bb0ae4f7fdd" 79c298c]:
{{{
#!CommitTicketReference repository=""
revision="79c298c9ceb8e386f172330236f04bb0ae4f7fdd"
Fixed #34266 -- Added ClosestPoint GIS database functions.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/34266#comment:8>