[Django] #32375: Sitemap.protocol change default to 'https'?
Django
--------------------------------------------+------------------------
Reporter: Thomas Güttler | Owner: nobody
Type: New feature | Status: new
Component: contrib.sitemaps | Version: 3.1
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
--------------------------------------------+------------------------
I think it is time to change the default of Sitemap.protocol to https.
https://docs.djangoproject.com/en/3.1/ref/contrib/sitemaps/#django.contrib.sitemaps.Sitemap.protocol
Of course slowly with a clear deprecation timeline.
What do you think?
--
Ticket URL: <https://code.djangoproject.com/ticket/32375>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
--------------------------------------+------------------------------------
Reporter: Thomas Güttler | Owner: nobody
Component: contrib.sitemaps | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Mariusz Felisiak):
* type: New feature => Cleanup/optimization
* version: 3.1 => master
* stage: Unreviewed => Accepted
Comment:
Sounds reasonable. We can add a warning for changing the default and
switch it when the deprecation ends (as in
9a30acad8a1996c914351bad981d937de4db29a4). Would you like to provide a
patch?
--
Ticket URL: <https://code.djangoproject.com/ticket/32375#comment:1>
Django
Reporter: Thomas Güttler | Owner: Jerin
Type: | Peter George
Cleanup/optimization | Status: assigned
Component: contrib.sitemaps | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Jerin Peter George):
* cc: Jerin Peter George (added)
* owner: nobody => Jerin Peter George
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/32375#comment:2>
Django
-------------------------------------+-------------------------------------
Reporter: Thomas Güttler | Owner: Jerin
Type: | Peter George
Cleanup/optimization | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
Changes (by David Smith):
* easy: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/32375#comment:3>
Django
-------------------------------------+-------------------------------------
Type: | R
Cleanup/optimization | Status: assigned
Component: contrib.sitemaps | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
* owner: Jerin Peter George => Rohith P R
* has_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/32375#comment:4>
Django
-------------------------------------+-------------------------------------
Reporter: Thomas Güttler | Owner: Rohith P
Type: | R
Cleanup/optimization | Status: assigned
Component: contrib.sitemaps | Version: dev
Severity: Normal | Resolution:
https |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
* keywords: => sitemap, protocol, https
* needs_better_patch: 0 => 1
Comment:
[https://github.com/django/django/pull/14396 PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/32375#comment:5>
Django
-------------------------------------+-------------------------------------
Reporter: Thomas Güttler | Owner: Rohith P
Type: | R
Cleanup/optimization | Status: assigned
Component: contrib.sitemaps | Version: dev
Severity: Normal | Resolution:
Keywords: sitemap, protocol, | Triage Stage: Accepted
https |
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
* needs_better_patch: 1 => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/32375#comment:6>
Django
-------------------------------------+-------------------------------------
Reporter: Thomas Güttler | Owner: Rohith P
Type: | R
Cleanup/optimization | Status: assigned
Component: contrib.sitemaps | Version: dev
Severity: Normal | Resolution:
Keywords: sitemap, protocol, | Triage Stage: Accepted
https |
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
* needs_better_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/32375#comment:7>
Django
-------------------------------------+-------------------------------------
Reporter: Thomas Güttler | Owner: Rohith P
Type: | R
Cleanup/optimization | Status: assigned
Component: contrib.sitemaps | Version: dev
Severity: Normal | Resolution:
https | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):
* needs_better_patch: 1 => 0
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/32375#comment:8>
Django
-------------------------------------+-------------------------------------
Reporter: Thomas Güttler | Owner: Rohith P
Type: | R
Component: contrib.sitemaps | Version: dev
Severity: Normal | Resolution: fixed
Keywords: sitemap, protocol, | Triage Stage: Ready for
https | checkin
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"7cca22964c09e8dafc313a400c428242404d527a" 7cca2296]:
{{{
#!CommitTicketReference repository=""
revision="7cca22964c09e8dafc313a400c428242404d527a"
Fixed #32375 -- Started deprecation toward changing the default sitemap
protocol to https.
The default sitemap protocol, when it is built outside the context of
a request, will be changed from 'http' to 'https' in Django 5.0.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/32375#comment:9>
Django
-------------------------------------+-------------------------------------
Reporter: Thomas Güttler | Owner: Rohith P
Type: | R
Cleanup/optimization | Status: closed
Component: contrib.sitemaps | Version: dev
Severity: Normal | Resolution: fixed
Keywords: sitemap, protocol, | Triage Stage: Ready for
https | checkin
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
Comment (by Mariusz Felisiak <felisiak.mariusz@…>):
In [changeset:"4eb97a90f0b4484fb13dd2166a61f9fe7256e9d0" 4eb97a90]:
{{{
#!CommitTicketReference repository=""
revision="4eb97a90f0b4484fb13dd2166a61f9fe7256e9d0"
Refs #32375 -- Changed default sitemap protocol to https.
Per deprecation timeline.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/32375#comment:10>