Re: [Django] #34220: Cannot import csrf_input_lazy from partially initialized module.
Django
-------------------------------------+-------------------------------------
Reporter: thommy | Owner: nobody
Type: Bug | Status: new
Component: Template system | Version: 4.1
Severity: Normal | Resolution:
Keywords: Jinja2 TemplateView | Triage Stage: Accepted
ImportError csrf_input_lazy |
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by thommy):
Hi Mariusz,
thanks for the quick response. I'll give it a try.
However it might take a couple of days to be sure because the problem
happens so rarely.
Best regards
Thommy
--
Ticket URL: <https://code.djangoproject.com/ticket/34220#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
-------------------------------------+-------------------------------------
Reporter: thommy | Owner: nobody
Type: Bug | Status: new
Component: Template system | Version: 4.1
Severity: Normal | Resolution:
Keywords: Jinja2 TemplateView | Triage Stage: Accepted
ImportError csrf_input_lazy |
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by thommy):
Hi Mariusz,
happy new year!
So far the exception hasn't occured again.
It would be great to see this patch in one of the next bugfix releases :-)
Best regards
Thommy
--
Ticket URL: <https://code.djangoproject.com/ticket/34220#comment:3>
Django
-------------------------------------+-------------------------------------
Reporter: thommy | Owner: nobody
Type: Bug | Status: new
Component: Template system | Version: 4.1
Severity: Normal | Resolution:
Keywords: Jinja2 TemplateView | Triage Stage: Accepted
ImportError csrf_input_lazy |
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Mariusz Felisiak):
Replying to [comment:3 thommy]:
> Hi Mariusz,
>
> happy new year!
The same to you!
> So far the exception hasn't occured again.
That's great! Would you like to prepare PR?
> It would be great to see this patch in one of the next bugfix releases
:-)
Per our backporting policy it doesn't qualify for a backport, so it can be
fixed in Django 4.2, see
[https://docs.djangoproject.com/en/stable/internals/release-process/
Django’s release process] for more details.
--
Ticket URL: <https://code.djangoproject.com/ticket/34220#comment:4>
Django
-------------------------------------+-------------------------------------
Reporter: thommy | Owner: nobody
Type: Bug | Status: new
Component: Template system | Version: 4.1
Severity: Normal | Resolution:
Keywords: Jinja2 TemplateView | Triage Stage: Accepted
ImportError csrf_input_lazy |
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by rajdesai24):
hey Mariusz would love to draft a PR
--
Ticket URL: <https://code.djangoproject.com/ticket/34220#comment:5>
Django
-------------------------------------+-------------------------------------
Reporter: thommy | Owner: nobody
Type: Bug | Status: new
Component: Template system | Version: 4.1
Severity: Normal | Resolution:
Keywords: Jinja2 TemplateView | Triage Stage: Accepted
ImportError csrf_input_lazy |
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Mariusz Felisiak):
Replying to [comment:5 rajdesai24]:
> hey Mariusz would love to draft a PR
Thanks, please prepare PR, see my
[https://code.djangoproject.com/ticket/34220#comment:1 comment]. There is
nothing more to do, IMO.
--
Ticket URL: <https://code.djangoproject.com/ticket/34220#comment:6>
Django
-------------------------------------+-------------------------------------
Reporter: thommy | Owner:
Type: Bug | Status: assigned
Component: Template system | Version: 4.1
Severity: Normal | Resolution:
Keywords: Jinja2 TemplateView | Triage Stage: Accepted
ImportError csrf_input_lazy |
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* owner: nobody => rajdesai24
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/34220#comment:7>
Django
-------------------------------------+-------------------------------------
Reporter: thommy | Owner:
| rajdesai24
Type: Bug | Status: assigned
Component: Template system | Version: 4.1
Severity: Normal | Resolution:
Keywords: Jinja2 TemplateView | Triage Stage: Accepted
ImportError csrf_input_lazy |
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by rajdesai24):
Please find the [https://github.com/django/django/pull/16433 PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/34220#comment:8>
Django
-------------------------------------+-------------------------------------
Reporter: thommy | Owner:
| rajdesai24
Type: Bug | Status: assigned
Component: Template system | Version: 4.1
Severity: Normal | Resolution:
ImportError csrf_input_lazy | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* has_patch: 0 => 1
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/34220#comment:9>
Django
-------------------------------------+-------------------------------------
Reporter: thommy | Owner:
| rajdesai24
Type: Bug | Status: assigned
Component: Template system | Version: 4.1
Severity: Normal | Resolution:
Keywords: Jinja2 TemplateView | Triage Stage: Ready for
ImportError csrf_input_lazy | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by thommy):
Thank you :-)
--
Ticket URL: <https://code.djangoproject.com/ticket/34220#comment:10>
Django
-------------------------------------+-------------------------------------
Reporter: thommy | Owner:
| rajdesai24
Component: Template system | Version: 4.1
Keywords: Jinja2 TemplateView | Triage Stage: Ready for
ImportError csrf_input_lazy | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"d5f892d873c6f98178121214f3c00d284ae1296d" d5f892d8]:
{{{
#!CommitTicketReference repository=""
revision="d5f892d873c6f98178121214f3c00d284ae1296d"
Fixed #34220 -- Moved csrf_input_lazy, csrf_token_lazy imports to the
toplevel.
This prevents random errors with partially initialized modules.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/34220#comment:11>