Re: [Django] #34205: Validation of constraints with __len lookup crashes for ArrayFields.

8 views
Skip to first unread message

Django

unread,
Dec 10, 2022, 10:35:00 AM12/10/22
to django-...@googlegroups.com
#34205: Validation of constraints with __len lookup crashes for ArrayFields.
-------------------------------------+-------------------------------------
Reporter: James Gillard | Owner: James
| Gillard
Type: Bug | Status: assigned
Component: Database layer | Version: 4.1
(models, ORM) |
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by James Gillard):

* owner: nobody => James Gillard
* status: new => assigned


--
Ticket URL: <https://code.djangoproject.com/ticket/34205#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Dec 10, 2022, 11:19:06 AM12/10/22
to django-...@googlegroups.com
#34205: Validation of constraints with __len lookup crashes for ArrayFields.
-------------------------------------+-------------------------------------
Reporter: James Gillard | Owner: James
| Gillard
Type: Bug | Status: assigned
Component: Database layer | Version: 4.1
(models, ORM) |
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by James Gillard):

* has_patch: 0 => 1


Comment:

Thanks for the quick feedback and suggested change, that was very helpful
for a someone who's new here :)

I've submitted a ​[https://github.com/django/django/pull/16376 pull
request] for this.

--
Ticket URL: <https://code.djangoproject.com/ticket/34205#comment:5>

Django

unread,
Dec 10, 2022, 11:55:57 AM12/10/22
to django-...@googlegroups.com
#34205: Validation of constraints with __len lookup crashes for ArrayFields.
-------------------------------------+-------------------------------------
Reporter: James Gillard | Owner: James
| Gillard
Type: Bug | Status: assigned
Component: Database layer | Version: 4.1
(models, ORM) |
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Ready for
| checkin

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* stage: Accepted => Ready for checkin


--
Ticket URL: <https://code.djangoproject.com/ticket/34205#comment:6>

Django

unread,
Dec 10, 2022, 1:38:35 PM12/10/22
to django-...@googlegroups.com
#34205: Validation of constraints with __len lookup crashes for ArrayFields.
-------------------------------------+-------------------------------------
Reporter: James Gillard | Owner: James
| Gillard
Type: Bug | Status: closed

Component: Database layer | Version: 4.1
(models, ORM) |
Severity: Release blocker | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak <felisiak.mariusz@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"c5ed884eabf3b2b67581c55bf6c87e721f69157f" c5ed884]:
{{{
#!CommitTicketReference repository=""
revision="c5ed884eabf3b2b67581c55bf6c87e721f69157f"
Fixed #34205 -- Fixed Meta.constraints validation crash with ArrayField
and __len lookup.

Regression in 88fc9e2826044110b7b22577a227f122fe9c1fb5 that began
manifesting in Django 4.1.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/34205#comment:7>

Django

unread,
Dec 10, 2022, 1:40:17 PM12/10/22
to django-...@googlegroups.com
#34205: Validation of constraints with __len lookup crashes for ArrayFields.
-------------------------------------+-------------------------------------
Reporter: James Gillard | Owner: James
| Gillard
Type: Bug | Status: closed
Component: Database layer | Version: 4.1
(models, ORM) |
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

In [changeset:"af3cfc863095e70f752c6b1875ed5c5dbaac2c4a" af3cfc8]:
{{{
#!CommitTicketReference repository=""
revision="af3cfc863095e70f752c6b1875ed5c5dbaac2c4a"
[4.1.x] Fixed #34205 -- Fixed Meta.constraints validation crash with
ArrayField and __len lookup.

Regression in 88fc9e2826044110b7b22577a227f122fe9c1fb5 that began
manifesting in Django 4.1.

Backport of c5ed884eabf3b2b67581c55bf6c87e721f69157f from main.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/34205#comment:8>

Reply all
Reply to author
Forward
0 new messages