Re: [Django] #33662: Choose which items are displayed per language in Sitemap
Django
----------------------------------+----------------------------------------
Reporter: roxanebellot | Owner: roxanebellot
Type: New feature | Status: assigned
Component: contrib.sitemaps | Version: 4.0
Severity: Normal | Resolution:
Keywords: sitemap | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
----------------------------------+----------------------------------------
Changes (by roxanebellot):
* owner: nobody => roxanebellot
* status: new => assigned
* has_patch: 0 => 1
Comment:
Sorry for the delay, I did not at all see any of your comments sooner !
I have in my project a model Article which could be summed up in four
fields (url_en, url_fr, content_en and content_fr). Some of these article
are only written in one language. With no content, the page is empty. Even
if it exists, I don't want this empty page to be in my sitemap.
My idea was to add a method in Sitemap to return a boolean indicating
whether the item should be displayed in the sitemap given a language.
I made a first draft for a patch
([https://github.com/django/django/compare/main...roxanebellot:django:ticket_33662]).
I wait for a green light on the feature before submitting it as a PR.
--
Ticket URL: <https://code.djangoproject.com/ticket/33662#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
----------------------------------+----------------------------------------
Reporter: roxanebellot | Owner: roxanebellot
Type: New feature | Status: assigned
Component: contrib.sitemaps | Version: 4.0
Severity: Normal | Resolution:
Keywords: sitemap | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
----------------------------------+----------------------------------------
* has_patch: 1 => 0
Comment:
@roxanebellot Please open a PR and add it here when you've done so.
Thanks.
--
Ticket URL: <https://code.djangoproject.com/ticket/33662#comment:5>
Django
----------------------------------+------------------------------------
Type: New feature | Status: assigned
Component: contrib.sitemaps | Version: 4.0
Severity: Normal | Resolution:
Keywords: sitemap | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
----------------------------------+------------------------------------
* has_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/33662#comment:6>
Django
----------------------------------+------------------------------------
Reporter: Roxane | Owner: Roxane
Type: New feature | Status: assigned
Component: contrib.sitemaps | Version: 4.0
Severity: Normal | Resolution:
Keywords: sitemap | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
----------------------------------+------------------------------------
* needs_better_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/33662#comment:7>
Django
Reporter: Roxane | Owner: Roxane
Type: New feature | Status: assigned
Component: contrib.sitemaps | Version: 4.0
Severity: Normal | Resolution:
| checkin
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Mariusz Felisiak):
* needs_better_patch: 1 => 0
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/33662#comment:8>
Django
-------------------------------------+-------------------------------------
Reporter: Roxane | Owner: Roxane
Component: contrib.sitemaps | Version: 4.0
Severity: Normal | Resolution: fixed
Keywords: sitemap | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"289e9a75afb52918a3efbdaf5e72f45a54089083" 289e9a7]:
{{{
#!CommitTicketReference repository=""
revision="289e9a75afb52918a3efbdaf5e72f45a54089083"
Fixed #33662 -- Allowed Sitemap to customize languages for each item.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/33662#comment:9>
Django
-------------------------------------+-------------------------------------
Reporter: Roxane | Owner: Roxane
Type: New feature | Status: closed
Component: contrib.sitemaps | Version: 4.0
Severity: Normal | Resolution: fixed
Keywords: sitemap | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by GitHub <noreply@…>):
In [changeset:"5c456a879300e5f51010d3f6aa7449302413efed" 5c456a8]:
{{{
#!CommitTicketReference repository=""
revision="5c456a879300e5f51010d3f6aa7449302413efed"
Refs #33662 -- Corrected Sitemap.get_languages_for_item() signature in
docs.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/33662#comment:10>
Django
-------------------------------------+-------------------------------------
Reporter: Roxane | Owner: Roxane
Type: New feature | Status: closed
Component: contrib.sitemaps | Version: 4.0
Severity: Normal | Resolution: fixed
Keywords: sitemap | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Mariusz Felisiak <felisiak.mariusz@…>):
In [changeset:"88f23b6b8158d3830589dce8787677cdb7d33404" 88f23b6b]:
{{{
#!CommitTicketReference repository=""
revision="88f23b6b8158d3830589dce8787677cdb7d33404"
[4.2.x] Refs #33662 -- Corrected Sitemap.get_languages_for_item()
signature in docs.
Backport of 5c456a879300e5f51010d3f6aa7449302413efed from main
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/33662#comment:11>