[Django] #34064: USE_THOUSAND_SEPARATOR docs clarification of override by locale
Django
-----------------------------------------+------------------------
Reporter: Tibor Leupold | Owner: nobody
Type: Uncategorized | Status: new
Component: Uncategorized | Version: 4.0
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-----------------------------------------+------------------------
I think there is currently some ambiguity in the last sentence of the docs
for `USE_THOUSAND_SEPARATOR`. It is not clear (at least to me) wether the
phrase "[t]hese settings" refers to `NUMBER_GROUPING` and
`THOUSAND_SEPARATOR` only, or to `NUMBER_GROUPING`, `THOUSAND_SEPARATOR`
and `USE_THOUSAND_SEPARATOR`.
> USE_THOUSAND_SEPARATOR¶
>
> Default: False
>
> A boolean that specifies whether to display numbers using a thousand
separator. When set to True and USE_L10N is also True, Django will format
numbers using the NUMBER_GROUPING and THOUSAND_SEPARATOR settings. These
settings may also be dictated by the locale, which takes precedence.
--
Ticket URL: <https://code.djangoproject.com/ticket/34064>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: Tibor Leupold | Owner: nobody
Cleanup/optimization |
Component: Documentation | Version: 4.0
Severity: Normal | Resolution: wontfix
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Mariusz Felisiak):
* status: new => closed
* resolution: => wontfix
* component: Uncategorized => Documentation
* type: Uncategorized => Cleanup/optimization
Comment:
''"these settings"'' refers to `NUMBER_GROUPING` and `THOUSAND_SEPARATOR`.
TBH, I'm not sure how we could clarify this sentence further. It has
already been rewritten/improved multiple times (the most recently in
80f92177eb2a175579f4a6907ef5a358863bddca). Closing as "wontix", but we may
reconsider this decision after submitting a concrete proposal for changes.
Tickets are not required for small cleanups, by the way.
--
Ticket URL: <https://code.djangoproject.com/ticket/34064#comment:1>
Django
-------------------------------------+-------------------------------------
Reporter: Tibor Leupold | Owner: nobody
Type: | Status: closed
Cleanup/optimization |
Component: Documentation | Version: 4.0
Severity: Normal | Resolution: wontfix
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Tibor Leupold):
Sorry. I did not know that PRs without tickets are fine for small changes.
I have created this small PR, which I think removes the ambiguity without
much other changes being necessary:
https://github.com/django/django/pull/16141
--
Ticket URL: <https://code.djangoproject.com/ticket/34064#comment:2>
Django
-------------------------------------+-------------------------------------
Reporter: Tibor Leupold | Owner: nobody
Cleanup/optimization |
Component: Documentation | Version: 4.0
Severity: Normal | Resolution:
| checkin
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* status: closed => new
* resolution: wontfix =>
* stage: Unreviewed => Ready for checkin
Comment:
[https://github.com/django/django/pull/16141 PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/34064#comment:3>
Django
-------------------------------------+-------------------------------------
Type: | Leupold
Cleanup/optimization | Status: assigned
Component: Documentation | Version: 4.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Carlton Gibson):
* owner: nobody => Tibor Leupold
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/34064#comment:4>
Django
-------------------------------------+-------------------------------------
Reporter: Tibor Leupold | Owner: Tibor
Type: | Leupold
Cleanup/optimization | Status: assigned
Component: Documentation | Version: 4.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Carlton Gibson):
* has_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/34064#comment:5>
Django
-------------------------------------+-------------------------------------
Reporter: Tibor Leupold | Owner: Tibor
Type: | Leupold
Component: Documentation | Version: 4.0
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"33f4de34e63c00616ed1624acdf9cd8adfaf33a6" 33f4de34]:
{{{
#!CommitTicketReference repository=""
revision="33f4de34e63c00616ed1624acdf9cd8adfaf33a6"
Fixed #34064 -- Adjusted locale override wording in settings docs.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/34064#comment:6>
Django
-------------------------------------+-------------------------------------
Reporter: Tibor Leupold | Owner: Tibor
Type: | Leupold
Cleanup/optimization | Status: closed
Component: Documentation | Version: 4.0
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Carlton Gibson <carlton.gibson@…>):
In [changeset:"754c0c5c6cbabddbe2a8480f95e4dd8273ca6fa4" 754c0c5]:
{{{
#!CommitTicketReference repository=""
revision="754c0c5c6cbabddbe2a8480f95e4dd8273ca6fa4"
[4.1.x] Fixed #34064 -- Adjusted locale override wording in settings docs.
Backport of 33f4de34e63c00616ed1624acdf9cd8adfaf33a6 from main
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/34064#comment:7>