Re: [Django] #34088: Sitemaps without items raise ValueError on callable lastmod.
Django
----------------------------------+------------------------------------
Reporter: Michal Čihař | Owner: Piyush
Type: Bug | Status: assigned
Component: contrib.sitemaps | Version: 4.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
----------------------------------+------------------------------------
Changes (by Piyush):
* owner: nobody => Piyush
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/34088#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
----------------------------------+------------------------------------
Reporter: Michal Čihař | Owner: Piyush
Type: Bug | Status: assigned
Component: contrib.sitemaps | Version: 4.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
----------------------------------+------------------------------------
Comment (by Adam Johnson):
The `default` argument of `max()` can be used.
--
Ticket URL: <https://code.djangoproject.com/ticket/34088#comment:3>
Django
----------------------------------+------------------------------------
Reporter: Michal Čihař | Owner: Piyush
Type: Bug | Status: assigned
Component: contrib.sitemaps | Version: 4.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
----------------------------------+------------------------------------
Changes (by Mariusz Felisiak):
* easy: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/34088#comment:4>
Django
----------------------------------+------------------------------------
Reporter: Michal Čihař | Owner: Piyush
Type: Bug | Status: assigned
Component: contrib.sitemaps | Version: 4.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
----------------------------------+------------------------------------
Comment (by Daniel Ivanov):
Prepared a patch in this [https://github.com/django/django/pull/16255 PR].
PLMK if I should reassign the ticket to myself.
--
Ticket URL: <https://code.djangoproject.com/ticket/34088#comment:5>
Django
----------------------------------+------------------------------------
Reporter: Michal Čihař | Owner: Piyush
Type: Bug | Status: assigned
Component: contrib.sitemaps | Version: 4.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
----------------------------------+------------------------------------
* has_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/34088#comment:6>
Django
Reporter: Michal Čihař | Owner: Daniel
| Ivanov
Type: Bug | Status: assigned
Component: contrib.sitemaps | Version: 4.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by Mariusz Felisiak):
* owner: Piyush => Daniel Ivanov
--
Ticket URL: <https://code.djangoproject.com/ticket/34088#comment:7>
Django
-------------------------------------+-------------------------------------
Reporter: Michal Čihař | Owner: Daniel
| Ivanov
Type: Bug | Status: assigned
Component: contrib.sitemaps | Version: 4.1
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):
* severity: Normal => Release blocker
Comment:
It's a bug in the new feature introduced in Django 4.1, see #25916 and
480191244d12fefbf95854b2b117c71ffe44749a.
--
Ticket URL: <https://code.djangoproject.com/ticket/34088#comment:8>
Django
-------------------------------------+-------------------------------------
Reporter: Michal Čihař | Owner: Daniel
| Ivanov
Type: Bug | Status: assigned
Component: contrib.sitemaps | Version: 4.1
Severity: Release blocker | Resolution:
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/34088#comment:9>
Django
-------------------------------------+-------------------------------------
Reporter: Michal Čihař | Owner: Daniel
| Ivanov
Component: contrib.sitemaps | Version: 4.1
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"eca526eab09b34a8190b591812ab99646cb1f34a" eca526ea]:
{{{
#!CommitTicketReference repository=""
revision="eca526eab09b34a8190b591812ab99646cb1f34a"
[4.1.x] Fixed #34088 -- Fixed Sitemap.get_latest_lastmod() crash with
empty items.
Bug in 480191244d12fefbf95854b2b117c71ffe44749a.
Thanks Michal Čihař for the report.
Backport of 5eab4d1924613a5506e517f157054b4852ae7dc2 from main
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/34088#comment:10>
Django
-------------------------------------+-------------------------------------
Reporter: Michal Čihař | Owner: Daniel
| Ivanov
Type: Bug | Status: closed
Component: contrib.sitemaps | Version: 4.1
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Mariusz Felisiak <felisiak.mariusz@…>):
In [changeset:"5eab4d1924613a5506e517f157054b4852ae7dc2" 5eab4d19]:
{{{
#!CommitTicketReference repository=""
revision="5eab4d1924613a5506e517f157054b4852ae7dc2"
Fixed #34088 -- Fixed Sitemap.get_latest_lastmod() crash with empty items.
Bug in 480191244d12fefbf95854b2b117c71ffe44749a.
Thanks Michal Čihař for the report.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/34088#comment:11>