[Django] #34102: Admin list view `word-break: break-word;`

1 view
Skip to first unread message

Django

unread,
Oct 17, 2022, 2:12:06 PM10/17/22
to django-...@googlegroups.com
#34102: Admin list view `word-break: break-word;`
-------------------------------------------+------------------------
Reporter: Collin Anderson | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: dev
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------------+------------------------
Hi All,

15682cb0034242fcdfe333cf399d62ab70c3a978 /
https://github.com/django/django/pull/16164 (Fixed wrapping of long model
names in the admin, Oct 10, 2022) put `word-break: break-word;` on all
`td, th` table cells in the entire admin.

That kinda messes up admin list view when there's a lot of columns, where
it's now breaking data mid-word or mid-email, etc. It might "break" other
things too. I'd suggest sticking to the browser default `word-break` for
most tables, and maybe limit `word-break: break-word;` to just the index
page.

Thanks,
Collin

--
Ticket URL: <https://code.djangoproject.com/ticket/34102>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Oct 17, 2022, 2:25:47 PM10/17/22
to django-...@googlegroups.com
#34102: Admin list view `word-break: break-word;`
---------------------------------+------------------------------------

Reporter: Collin Anderson | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: dev
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+------------------------------------
Changes (by Mariusz Felisiak):

* severity: Normal => Release blocker
* stage: Unreviewed => Accepted


Comment:

Thanks for the report! Visual regression in
15682cb0034242fcdfe333cf399d62ab70c3a978.

> I'd suggest sticking to the browser default `word-break` for most
tables, and maybe limit `word-break: break-word;` to just the index page.

Sounds good. Would you like to prepare a patch?

--
Ticket URL: <https://code.djangoproject.com/ticket/34102#comment:1>

Django

unread,
Oct 17, 2022, 2:47:44 PM10/17/22
to django-...@googlegroups.com
#34102: Admin list view `word-break: break-word;`
---------------------------------+------------------------------------
Reporter: Collin Anderson | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: dev
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+------------------------------------
Changes (by Collin Anderson):

* has_patch: 0 => 1


Comment:

Ok here's a patch: https://github.com/django/django/pull/16190

--
Ticket URL: <https://code.djangoproject.com/ticket/34102#comment:2>

Django

unread,
Oct 17, 2022, 5:08:15 PM10/17/22
to django-...@googlegroups.com
#34102: Admin list view `word-break: break-word;`
-------------------------------------+-------------------------------------
Reporter: Collin Anderson | Owner: Collin
| Anderson
Type: Bug | Status: assigned

Component: contrib.admin | Version: dev
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* owner: nobody => Collin Anderson
* status: new => assigned


--
Ticket URL: <https://code.djangoproject.com/ticket/34102#comment:3>

Django

unread,
Oct 18, 2022, 3:17:37 PM10/18/22
to django-...@googlegroups.com
#34102: Admin list view `word-break: break-word;`
-------------------------------------+-------------------------------------
Reporter: Collin Anderson | Owner: Collin
| Anderson
Type: Bug | Status: closed
Component: contrib.admin | Version: dev
Severity: Release blocker | Resolution: fixed

Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by GitHub <noreply@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"78470043ae4b8def7914badcd05bb1877c8a0aa4" 7847004]:
{{{
#!CommitTicketReference repository=""
revision="78470043ae4b8def7914badcd05bb1877c8a0aa4"
Fixed #34102 -- Limited wrapping long names to admin dashboard.

Regression in 15682cb0034242fcdfe333cf399d62ab70c3a978.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/34102#comment:4>

Reply all
Reply to author
Forward
0 new messages