[Django] #34092: Admin theme switcher icon should resize according to browser font size

2 views
Skip to first unread message

Django

unread,
Oct 13, 2022, 1:03:43 PM10/13/22
to django-...@googlegroups.com
#34092: Admin theme switcher icon should resize according to browser font size
-------------------------------------+-------------------------------------
Reporter: Thibaud | Owner: nobody
Colas |
Type: Bug | Status: new
Component: | Version: dev
contrib.admin | Keywords: accessibility, ux,
Severity: Normal | font size, dark mode
Triage Stage: | Has patch: 0
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 1
UI/UX: 1 |
-------------------------------------+-------------------------------------
The new admin theme switcher’s icon is a fixed 16x16px, regardless of the
browser’s configured font size. It would be better for users requiring
larger text if icons resized as well.

This seems to be due to the icons’ SVG symbols having hard-coded `width`
and `height` attributes, which prevents resizing with CSS. I believe the
`width` and `height` should either be removed, or set on the inline SVG
(which can be a bit tedious).

Screenshot:

Relevant code:
https://github.com/django/django/blob/da8fa764134980ee1079f790cda6616f32cf9c44/django/contrib/admin/templates/admin/base.html#L118-L122

--
Ticket URL: <https://code.djangoproject.com/ticket/34092>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Oct 13, 2022, 1:28:05 PM10/13/22
to django-...@googlegroups.com
#34092: Admin theme switcher icon should resize according to browser font size
-------------------------------------+-------------------------------------
Reporter: Thibaud Colas | Owner: nobody
Type: Bug | Status: closed
Component: contrib.admin | Version: dev
Severity: Normal | Resolution: duplicate
Keywords: accessibility, ux, | Triage Stage:
font size, dark mode | Unreviewed
Has patch: 0 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* status: new => closed
* resolution: => duplicate


Comment:

Duplicate of #34093.

--
Ticket URL: <https://code.djangoproject.com/ticket/34092#comment:1>

Reply all
Reply to author
Forward
0 new messages