[Django] #34094: RTL alignment is off in admin header area
Django
-----------------------------------------+------------------------
Reporter: Thibaud Colas | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 4.1
Severity: Normal | Keywords: rtl
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 1
UI/UX: 1 |
-----------------------------------------+------------------------
There are two RTL spacing / alignment issues in the admin header area
which are unrelated but should be straightforward to address at the same
time:
- The h1 "branding" has a left margin, which should be switched to the
right for RTL languages
- The theme switcher’s `.theme-toggle`’s `margin-left` should also switch
to the right.
Both margins can be switched to use `margin-inline-start`, so the correct
spacing is used in RTL languages. No need to add to the separate RTL-only
stylesheet.
--
Ticket URL: <https://code.djangoproject.com/ticket/34094>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: Thibaud Colas | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 4.1
Keywords: rtl | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
Changes (by Thibaud Colas):
* Attachment "Screenshot 2022-10-13 at 17.51.52.png" added.
Django
-------------------------------+------------------------------------
Type: Bug | Status: new
Component: contrib.admin | Version: 4.1
Severity: Normal | Resolution:
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------+------------------------------------
* cc: Sarah Abderemane, Shai Berger (added)
* stage: Unreviewed => Accepted
Comment:
Thanks for the report!
--
Ticket URL: <https://code.djangoproject.com/ticket/34094#comment:1>
Django
Reporter: Thibaud Colas | Owner: 1twalters01
Type: Bug | Status: assigned
Component: contrib.admin | Version: 4.1
Severity: Normal | Resolution:
Keywords: rtl | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
Changes (by 1twalters01):
* owner: nobody => 1twalters01
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/34094#comment:2>
Django
-------------------------------+---------------------------------------
Reporter: Thibaud Colas | Owner: 1twalters01
Type: Bug | Status: assigned
Component: contrib.admin | Version: 4.1
Severity: Normal | Resolution:
Keywords: rtl | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------+---------------------------------------
* cc: Amine Zyad (added)
Comment:
Anyone working on this?
--
Ticket URL: <https://code.djangoproject.com/ticket/34094#comment:3>
Django
Reporter: Thibaud Colas | Owner: (none)
Type: Bug | Status: new
Component: contrib.admin | Version: 4.1
Severity: Normal | Resolution:
Keywords: rtl | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
Changes (by Mariusz Felisiak):
* owner: 1twalters01 => (none)
* status: assigned => new
Comment:
Amine, feel-free to work on this.
--
Ticket URL: <https://code.djangoproject.com/ticket/34094#comment:4>
Django
-------------------------------+------------------------------------
Type: Bug | Status: assigned
Component: contrib.admin | Version: 4.1
Severity: Normal | Resolution:
Keywords: rtl | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------+------------------------------------
* owner: (none) => panicofr
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/34094#comment:5>
Django
Reporter: Thibaud Colas | Owner: Francesco
| Panico
Type: Bug | Status: assigned
Component: contrib.admin | Version: 4.1
Severity: Normal | Resolution:
Keywords: rtl | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
Comment (by Francesco Panico):
Is the margin on `div#branding h1` a right margin, that should be turned
into a left margin for RTL languages?
--
Ticket URL: <https://code.djangoproject.com/ticket/34094#comment:6>
Django
-------------------------------------+-------------------------------------
Reporter: Thibaud Colas | Owner: Francesco
| Panico
Type: Bug | Status: assigned
Component: contrib.admin | Version: 4.1
Severity: Normal | Resolution:
Keywords: rtl | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------
* Attachment "Schermata 2022-10-30 alle 02.12.03.png" added.
--
Ticket URL: <https://code.djangoproject.com/ticket/34094>
Django
-------------------------------------+-------------------------------------
Reporter: Thibaud Colas | Owner: Francesco
| Panico
Type: Bug | Status: assigned
Component: contrib.admin | Version: 4.1
Severity: Normal | Resolution:
Keywords: rtl | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Francesco Panico):
* cc: Francesco Panico (added)
* has_patch: 0 => 1
Comment:
[https://github.com/django/django/pull/16240 PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/34094#comment:7>
Django
-------------------------------------+-------------------------------------
Reporter: Thibaud Colas | Owner: Francesco
| Panico
Component: contrib.admin | Version: 4.1
Severity: Normal | Resolution: fixed
Keywords: rtl | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------
* status: assigned => closed
* resolution: => fixed
Comment:
Fixed in c01e76c95caa1bd2995f1b6c186cbe8726c92ef9.
--
Ticket URL: <https://code.djangoproject.com/ticket/34094#comment:8>