Re: [Django] #34010: Parallel tests don't work with spawn.
Django
-----------------------------------+--------------------------------------
Reporter: Kevin Renskers | Owner: nobody
Type: Bug | Status: closed
Component: Testing framework | Version: 4.1
Severity: Normal | Resolution: needsinfo
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-----------------------------------+--------------------------------------
Comment (by Kevin Renskers):
Replying to [comment:3 Mariusz Felisiak]:
> We also confirmed that #33891 is fixed so it must be something
different. You can send a sample project to me or Carlton to emails from
GitHub profiles. Thanks.
Yep I sent a project to Carlton on the 15th. Not sure why this ticket got
closed though, since I have a reproducible problem running parallel tests?
--
Ticket URL: <https://code.djangoproject.com/ticket/34010#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
-----------------------------------+--------------------------------------
Reporter: Kevin Renskers | Owner: nobody
Type: Bug | Status: closed
Component: Testing framework | Version: 4.1
Severity: Normal | Resolution: needsinfo
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-----------------------------------+--------------------------------------
Comment (by Mariusz Felisiak):
> Yep I sent a project to Carlton on the 15th. Not sure why this ticket
got closed though, since I have a reproducible problem running parallel
tests?
Don't worry, we will reopen the ticket as soon as Carlton confirms it's an
issue in Django. Django Con Europe starts today so it might take a little
longer but it's on the radar.
--
Ticket URL: <https://code.djangoproject.com/ticket/34010#comment:5>
Django
-----------------------------------+--------------------------------------
Reporter: Kevin Renskers | Owner: nobody
Component: Testing framework | Version: 4.1
Severity: Normal | Resolution:
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-----------------------------------+--------------------------------------
* status: closed => new
* resolution: needsinfo =>
--
Ticket URL: <https://code.djangoproject.com/ticket/34010#comment:6>
Django
-----------------------------------+--------------------------------------
Reporter: Kevin Renskers | Owner: nobody
Type: Bug | Status: new
Component: Testing framework | Version: 4.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-----------------------------------+--------------------------------------
Comment (by Carlton Gibson):
Yes, confirming that. I’m currently reducing the example project to work
out exactly what the issue is. Thanks.
--
Ticket URL: <https://code.djangoproject.com/ticket/34010#comment:7>
Django
-----------------------------------+------------------------------------
Type: Bug | Status: new
Component: Testing framework | Version: 4.1
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-----------------------------------+------------------------------------
* cc: David Smith (added)
* severity: Normal => Release blocker
* stage: Unreviewed => Accepted
Comment:
OK, thanks for the report Kevin. We're not setting the
`ParallelTestSuite.process_setup` and `process_setup_args` correctly,
instead being the `_process_setup_stub` no-op. We'll need an
implementation for that.
(If your — i.e. my — test project doesn't come out of
`partition_suite_by_case()` the right way you don't trigger this. I shall
upload a minimal project later.)
This was an issue in the original patch
3b3f38b3b09b0f2373e51406ecb8c9c45d36aebc, rather than the other referenced
issues.
--
Ticket URL: <https://code.djangoproject.com/ticket/34010#comment:8>
Django
-----------------------------------+------------------------------------
Reporter: Kevin Renskers | Owner: nobody
Type: Bug | Status: new
Component: Testing framework | Version: 4.1
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-----------------------------------+------------------------------------
Changes (by Carlton Gibson):
* Attachment "parallel_tests.zip" added.
Minimal reproduce. Install Django and manage.py test --parallel on macOS
(and presumably Windows)
--
Ticket URL: <https://code.djangoproject.com/ticket/34010>
Django
Reporter: Kevin Renskers | Owner: Carlton
| Gibson
Type: Bug | Status: assigned
Component: Testing framework | Version: 4.1
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Carlton Gibson):
* owner: nobody => Carlton Gibson
* status: new => assigned
* has_patch: 0 => 1
Comment:
[https://github.com/django/django/pull/16128 PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/34010#comment:9>
Django
-------------------------------------+-------------------------------------
| Johnson
Type: Bug | Status: assigned
Component: Testing framework | Version: 4.1
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Carlton Gibson):
* owner: Carlton Gibson => Adam Johnson
Comment:
[https://github.com/django/django/pull/16129 Better PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/34010#comment:10>
Django
-------------------------------------+-------------------------------------
Reporter: Kevin Renskers | Owner: Adam
| Johnson
Type: Bug | Status: assigned
Component: Testing framework | Version: 4.1
Severity: Release blocker | Resolution:
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/34010#comment:11>
Django
-------------------------------------+-------------------------------------
Reporter: Kevin Renskers | Owner: Adam
| Johnson
Component: Testing framework | Version: 4.1
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Mariusz Felisiak <felisiak.mariusz@…>):
In [changeset:"0f5b11eca0ba199501941fa244b276aaa10353c8" 0f5b11ec]:
{{{
#!CommitTicketReference repository=""
revision="0f5b11eca0ba199501941fa244b276aaa10353c8"
Refs #34010 -- Made --debug-mode work for parallel tests using spawn.
Bug in 3b3f38b3b09b0f2373e51406ecb8c9c45d36aebc.
Thanks Kevin Renskers for the report.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/34010#comment:13>
Django
-------------------------------------+-------------------------------------
Reporter: Kevin Renskers | Owner: Adam
| Johnson
Type: Bug | Status: closed
Component: Testing framework | Version: 4.1
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"4a910f3de35338df7d4fcd8b7729fd1e31edaad0" 4a910f3d]:
{{{
#!CommitTicketReference repository=""
revision="4a910f3de35338df7d4fcd8b7729fd1e31edaad0"
Fixed #34010 -- Made parallel tests using spawn set up Django.
Bug in 3b3f38b3b09b0f2373e51406ecb8c9c45d36aebc.
Thanks Kevin Renskers for the report.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/34010#comment:12>
Django
-------------------------------------+-------------------------------------
Reporter: Kevin Renskers | Owner: Adam
| Johnson
Type: Bug | Status: closed
Component: Testing framework | Version: 4.1
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Mariusz Felisiak <felisiak.mariusz@…>):
In [changeset:"5630a6ca2942590180fe0b5890af33515d28d91d" 5630a6ca]:
{{{
#!CommitTicketReference repository=""
revision="5630a6ca2942590180fe0b5890af33515d28d91d"
[4.1.x] Fixed #34010 -- Made parallel tests using spawn set up Django.
Bug in 3b3f38b3b09b0f2373e51406ecb8c9c45d36aebc.
Thanks Kevin Renskers for the report.
Backport of 4a910f3de35338df7d4fcd8b7729fd1e31edaad0 from main
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/34010#comment:14>
Django
-------------------------------------+-------------------------------------
Reporter: Kevin Renskers | Owner: Adam
| Johnson
Type: Bug | Status: closed
Component: Testing framework | Version: 4.1
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Mariusz Felisiak <felisiak.mariusz@…>):
In [changeset:"b826b38847a170067a414658ca97ac07a413ae65" b826b388]:
{{{
#!CommitTicketReference repository=""
revision="b826b38847a170067a414658ca97ac07a413ae65"
[4.1.x] Refs #34010 -- Made --debug-mode work for parallel tests using
spawn.
Bug in 3b3f38b3b09b0f2373e51406ecb8c9c45d36aebc.
Thanks Kevin Renskers for the report.
Backport of 0f5b11eca0ba199501941fa244b276aaa10353c8 from main
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/34010#comment:15>