[Django] #34046: tox.ini contains version pinnings at the wrong places

9 views
Skip to first unread message

Django

unread,
Sep 24, 2022, 7:41:13 AM9/24/22
to django-...@googlegroups.com
#34046: tox.ini contains version pinnings at the wrong places
-------------------------------------+-------------------------------------
Reporter: Michael | Owner: Michael Howitz
Howitz |
Type: Bug | Status: assigned
Component: Testing | Version: dev
framework |
Severity: Normal | Keywords:
Triage Stage: | Has patch: 0
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 1
UI/UX: 0 |
-------------------------------------+-------------------------------------
Currently the minimum version numbers are added the section names but they
belong inside the sections.
So the `flake8` environment does not run flake8 checks but the Django test
suite.

--
Ticket URL: <https://code.djangoproject.com/ticket/34046>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Sep 24, 2022, 7:55:10 AM9/24/22
to django-...@googlegroups.com
#34046: tox.ini contains version pinnings at the wrong places
--------------------------------+------------------------------------------
Reporter: Michael Howitz | Owner: Michael Howitz
Type: Bug | Status: assigned
Component: Core (Other) | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
--------------------------------+------------------------------------------
Changes (by Mariusz Felisiak):

* component: Testing framework => Core (Other)
* stage: Unreviewed => Accepted


Comment:

Agreed, version restrictions should be move to `deps`.

--
Ticket URL: <https://code.djangoproject.com/ticket/34046#comment:1>

Django

unread,
Sep 24, 2022, 7:56:34 AM9/24/22
to django-...@googlegroups.com
#34046: tox.ini contains version pinnings at the wrong places
--------------------------------+------------------------------------------
Reporter: Michael Howitz | Owner: Michael Howitz
Type: Bug | Status: assigned
Component: Core (Other) | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
--------------------------------+------------------------------------------
Changes (by Michael Howitz):

* has_patch: 0 => 1


--
Ticket URL: <https://code.djangoproject.com/ticket/34046#comment:2>

Django

unread,
Sep 24, 2022, 10:06:24 AM9/24/22
to django-...@googlegroups.com
#34046: tox.ini contains version pinnings at the wrong places
--------------------------------+------------------------------------------
Reporter: Michael Howitz | Owner: Michael Howitz
Type: Bug | Status: assigned
Component: Core (Other) | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 1 | UI/UX: 0
--------------------------------+------------------------------------------
Changes (by Mariusz Felisiak):

* needs_better_patch: 0 => 1


--
Ticket URL: <https://code.djangoproject.com/ticket/34046#comment:3>

Django

unread,
Sep 24, 2022, 10:31:58 AM9/24/22
to django-...@googlegroups.com
#34046: tox.ini contains version pinnings at the wrong places
--------------------------------+------------------------------------------
Reporter: Michael Howitz | Owner: Michael Howitz
Type: Bug | Status: assigned
Component: Core (Other) | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 0
--------------------------------+------------------------------------------
Changes (by Michael Howitz):

* needs_better_patch: 1 => 0


--
Ticket URL: <https://code.djangoproject.com/ticket/34046#comment:4>

Django

unread,
Sep 24, 2022, 12:01:40 PM9/24/22
to django-...@googlegroups.com
#34046: tox.ini contains version pinnings at the wrong places
-------------------------------------+-------------------------------------

Reporter: Michael Howitz | Owner: Michael
| Howitz
Type: Bug | Status: assigned
Component: Core (Other) | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* stage: Accepted => Ready for checkin


--
Ticket URL: <https://code.djangoproject.com/ticket/34046#comment:5>

Django

unread,
Sep 24, 2022, 12:32:57 PM9/24/22
to django-...@googlegroups.com
#34046: tox.ini contains version pinnings at the wrong places
-------------------------------------+-------------------------------------
Reporter: Michael Howitz | Owner: Michael
| Howitz
Type: Bug | Status: closed

Component: Core (Other) | Version: dev
Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by GitHub <noreply@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"8eed30aec606ff70eee920af84e880ea19da481b" 8eed30a]:
{{{
#!CommitTicketReference repository=""
revision="8eed30aec606ff70eee920af84e880ea19da481b"
Fixed #34046 -- Fixed pinning flake8 and isort versions in tox.ini.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/34046#comment:6>

Reply all
Reply to author
Forward
0 new messages