Re: [Django] #34023: inlines variable not bound in loop in ModelAdmin._create_formsets (was: ``inlines`` variable not bound in loop in ModelAdmin._create_formsets)

8 views
Skip to first unread message

Django

unread,
Sep 19, 2022, 2:36:17 AM9/19/22
to django-...@googlegroups.com
#34023: inlines variable not bound in loop in ModelAdmin._create_formsets
--------------------------------------+------------------------------------
Reporter: Michał Pasternak | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by Mariusz Felisiak):

* type: Uncategorized => Cleanup/optimization
* component: Uncategorized => contrib.admin
* stage: Unreviewed => Accepted


Comment:

Thanks for the report. As far as I'm aware it's not a bug in this
particular case as `user_deleted_form` is created and used immediately
inside a loop. However I agree that we can pass `inline` to
`user_deleted_form()` to avoid a bug in the future. Would you like to
prepare a patch?

Ticket are not required for small cleanups, by the way.

--
Ticket URL: <https://code.djangoproject.com/ticket/34023#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Reply all
Reply to author
Forward
0 new messages