[Django] #33983: Unused html code in: password_reset_confirm.html

20 views
Skip to first unread message

Django

unread,
Sep 5, 2022, 1:47:30 PM9/5/22
to django-...@googlegroups.com
#33983: Unused html code in: password_reset_confirm.html
-------------------------------------+-------------------------------------
Reporter: Jakob | Owner: nobody
Damgaard Møller |
Type: | Status: new
Cleanup/optimization |
Component: Template | Version: 4.0
system | Keywords: template, cleanup,
Severity: Normal | password_reset_confirm
Triage Stage: | Has patch: 0
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
Hello, when working on a django site, I was implementing password reset
function and used your examples.
I came across this template:
https://github.com/django/django/blob/main/django/contrib/admin/templates/registration/password_reset_confirm.html#L20

And for me, I see no use of line 20 in the template.
And if I do a post with the current html, the username is not posted
anyways. So unless the username is for informational usage for the user,
it could make sense.
But the input has a class="hidden" and no name is assigned the input.

Am I wrong or right?

--
Ticket URL: <https://code.djangoproject.com/ticket/33983>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Sep 5, 2022, 1:56:18 PM9/5/22
to django-...@googlegroups.com
#33983: Unused html code in: password_reset_confirm.html
-------------------------------------+-------------------------------------
Reporter: Jakob Damgaard | Owner: nobody
Møller |
Type: | Status: closed
Cleanup/optimization |
Component: Template system | Version: 4.0
Severity: Normal | Resolution: invalid
Keywords: template, cleanup, | Triage Stage:
password_reset_confirm | Unreviewed
Has patch: 0 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Claude Paroz):

* status: new => closed
* resolution: => invalid


Comment:

This was added as part of #31978 (hint for password managers).

--
Ticket URL: <https://code.djangoproject.com/ticket/33983#comment:1>

Reply all
Reply to author
Forward
0 new messages