[Django] #24179: FilteredSelectMultiple widget - add filter field to the right column.
Django
-------------------------+-------------------------------------------------
Reporter: gdmka | Owner: nobody
Type: New | Status: new
feature |
Component: Forms | Version: 1.7
Severity: Normal | Keywords: FilteredSelectMultiple,
Triage Stage: | filter_horizontal, UI
Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 1
-------------------------+-------------------------------------------------
I found that working with large datasets using ''filter_horizontal'' and
thus FilteredSelectMultiple widget can be painful if you need to filter
out `selected` entries.
As, the UI is builded dynamically it is pretty easy to achieve the result
you see below. I believe this feature is small but important.
[[Image(http://i.imgur.com/E2qGjLf.png)]]
I have a patch for that, should i attach it to the ticket or i can simply
make a Pull request on Github referring this particular ticket?
--
Ticket URL: <https://code.djangoproject.com/ticket/24179>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: gdmka | Owner: nobody
Type: New feature | Status: new
Component: Forms | Version: 1.7
Severity: Normal | Resolution:
Keywords: | Triage Stage:
FilteredSelectMultiple, | Unreviewed
filter_horizontal, UI |
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
Changes (by gdmka):
* needs_better_patch: => 0
* needs_tests: => 0
* needs_docs: => 0
Old description:
> I found that working with large datasets using ''filter_horizontal'' and
> thus FilteredSelectMultiple widget can be painful if you need to filter
> out `selected` entries.
>
> As, the UI is builded dynamically it is pretty easy to achieve the
> result you see below. I believe this feature is small but important.
> [[Image(http://i.imgur.com/E2qGjLf.png)]]
>
> I have a patch for that, should i attach it to the ticket or i can
> simply make a Pull request on Github referring this particular ticket?
New description:
I found that working with large datasets using ''filter_horizontal'' and
thus FilteredSelectMultiple widget can be painful if you need to filter
out selected entries.
As, the UI is builded dynamically it is pretty easy to achieve the result
you see below. I believe this feature is small but important.
[[Image(http://i.imgur.com/E2qGjLf.png)]]
I have a patch for that, should i attach it to the ticket or i can simply
make a Pull request on Github referring this particular ticket?
--
--
Ticket URL: <https://code.djangoproject.com/ticket/24179#comment:1>
Django
Reporter: gdmka | Owner: nobody
Type: New feature | Status: new
Component: Forms | Version: 1.7
Severity: Normal | Resolution:
Keywords: | Triage Stage:
FilteredSelectMultiple, | Unreviewed
filter_horizontal, UI |
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
Changes (by gdmka):
* cc: gdmka (added)
* easy: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/24179#comment:2>
Django
Reporter: gdmka | Owner: nobody
Type: New feature | Status: new
Component: Forms | Version: 1.7
Severity: Normal | Resolution:
Keywords: | Triage Stage:
FilteredSelectMultiple, | Unreviewed
filter_horizontal, UI |
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 1
Changes (by timgraham):
* easy: 1 => 0
Comment:
The tricky thing I have seen with this type of UI is determining what the
proper behavior is when a search term is entered in the right hand search
box and the form is saved. Do we save only the values that appear due to
the search or do we save all the "hidden" values as well?
--
Ticket URL: <https://code.djangoproject.com/ticket/24179#comment:3>
Django
Reporter: gdmka | Owner: nobody
Type: New feature | Status: new
Component: Forms | Version: 1.7
Severity: Normal | Resolution:
Keywords: | Triage Stage:
FilteredSelectMultiple, | Unreviewed
filter_horizontal, UI |
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 1
Comment (by gdmka):
>> Do we save only the values that appear due to the search or do we save
all the "hidden" values as well?
Great question!
I believe that ''filtering out'' values that do not match search criteria
is what should be default upon form submission. So we move the filtered
out back to the "available" column. The rest of the logic: eg doubleclick
on filtered results, stays the same.
--
Ticket URL: <https://code.djangoproject.com/ticket/24179#comment:4>
Django
Reporter: gdmka | Owner: gdmka
Type: New feature | Status: assigned
Component: Forms | Version: 1.7
Severity: Normal | Resolution:
Keywords: | Triage Stage:
FilteredSelectMultiple, | Unreviewed
filter_horizontal, UI |
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 1
Changes (by gdmka):
* owner: nobody => gdmka
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/24179#comment:5>
Django
Reporter: gdmka | Owner: gdmka
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage:
FilteredSelectMultiple, | Unreviewed
filter_horizontal, UI |
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 1
Comment (by charettes):
Replying to [comment:4 gdmka]:
> >> Do we save only the values that appear due to the search or do we
save all the "hidden" values as well?
> Great question!
>
> I believe that ''filtering out'' values that do not match search
criteria is what should be default upon form submission.
I would expect the opposite since the filter on the left side doesn't work
this way.
--
Ticket URL: <https://code.djangoproject.com/ticket/24179#comment:6>
Django
Reporter: gdmka | Owner: gdmka
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
FilteredSelectMultiple, |
filter_horizontal, UI |
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 1
Changes (by timgraham):
* version: 1.7 => master
* component: Forms => contrib.admin
* stage: Unreviewed => Accepted
--
Ticket URL: <https://code.djangoproject.com/ticket/24179#comment:7>
Django
Reporter: gdmka | Owner: Anton
| Samarchyan
Type: New feature | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
FilteredSelectMultiple, |
filter_horizontal, UI |
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 1
Changes (by Anton Samarchyan):
* owner: gdmka => Anton Samarchyan
--
Ticket URL: <https://code.djangoproject.com/ticket/24179#comment:8>
Django
Reporter: gdmka | Owner: Anton
| Samarchyan
Type: New feature | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
FilteredSelectMultiple, |
filter_horizontal, UI |
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
Changes (by Anton Samarchyan):
* has_patch: 0 => 1
Comment:
I have submitted a [https://github.com/django/django/pull/8277 PR]. It's
currently for 1.8 version. Please see if the functionality is correct and
I will update it for the master branch. Please don't review the code
itself. It will need refactoring after the functionality is confirmed.
--
Ticket URL: <https://code.djangoproject.com/ticket/24179#comment:9>
Django
Reporter: gdmka | Owner: Anton
| Samarchyan
Type: New feature | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
FilteredSelectMultiple, |
filter_horizontal, UI |
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 1
Changes (by Tim Graham):
* needs_better_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/24179#comment:10>
Django
Reporter: gdmka | Owner: (none)
Type: New feature | Status: new
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
FilteredSelectMultiple, |
filter_horizontal, UI |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Changes (by Anton Samarchyan):
* status: assigned => new
* owner: Anton Samarchyan => (none)
--
Ticket URL: <https://code.djangoproject.com/ticket/24179#comment:11>
Django
Reporter: gdmka | Owner: (none)
Type: New feature | Status: new
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
FilteredSelectMultiple, |
filter_horizontal, UI |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Changes (by Mariusz Felisiak):
* owner: Anton Samarchyan => (none)
* status: assigned => new
--
Ticket URL: <https://code.djangoproject.com/ticket/24179#comment:11>
Django
Reporter: gdmka | Owner: Gav
| O'Connor
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
FilteredSelectMultiple, |
filter_horizontal, UI |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Changes (by Gav O'Connor):
* owner: (none) => Gav O'Connor
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/24179#comment:12>
Django
Reporter: gdmka | Owner: Gav
| O'Connor
Type: New feature | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
FilteredSelectMultiple, |
filter_horizontal, UI |
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 1
Changes (by Gav O'Connor):
* needs_better_patch: 1 => 0
Comment:
PR created to allow the "Selected" column to be filtered in the same was
as the "Available" column.
The fix is purely for displaying the results, and the value passed to the
server/saved to the DB is not affected by what options are visible due to
the search terms.
[https://github.com/django/django/pull/15926 PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/24179#comment:13>
Django
Reporter: gdmka | Owner: Gav
| O'Connor
Type: New feature | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
FilteredSelectMultiple, |
filter_horizontal, UI |
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 1
Changes (by Carlton Gibson):
* needs_tests: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/24179#comment:14>
Django
Reporter: gdmka | Owner: Gav
| O'Connor
Type: New feature | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
FilteredSelectMultiple, |
filter_horizontal, UI |
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 1
Changes (by Gav O'Connor):
* needs_tests: 1 => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/24179#comment:15>
Django
Reporter: gdmka | Owner: Gav
| O'Connor
Type: New feature | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
FilteredSelectMultiple, |
filter_horizontal, UI |
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 1
Changes (by Mariusz Felisiak):
* needs_better_patch: 0 => 1
Comment:
Pending
[https://github.com/django/django/pull/15926#issuecomment-1211611445 the
design decision].
--
Ticket URL: <https://code.djangoproject.com/ticket/24179#comment:16>
Django
Reporter: gdmka | Owner: Gav
| O'Connor
Type: New feature | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
FilteredSelectMultiple, |
filter_horizontal, UI |
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 1
Changes (by Gav O'Connor):
* needs_better_patch: 1 => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/24179#comment:17>
Django
Reporter: gdmka | Owner: Gav
| O'Connor
Type: New feature | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
FilteredSelectMultiple, | checkin
filter_horizontal, UI |
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 1
Changes (by Carlton Gibson):
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/24179#comment:18>
Django
Reporter: gdmka | Owner: Gav
| O'Connor
Type: New feature | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
FilteredSelectMultiple, |
filter_horizontal, UI |
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 1
Changes (by Mariusz Felisiak):
* needs_better_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/24179#comment:18>
Django
Reporter: gdmka | Owner: Gav
| O'Connor
Type: New feature | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
FilteredSelectMultiple, |
filter_horizontal, UI |
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 1
Changes (by Gav O'Connor):
* needs_better_patch: 1 => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/24179#comment:19>
Django
Reporter: gdmka | Owner: Gav
| O'Connor
Type: New feature | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
FilteredSelectMultiple, | checkin
filter_horizontal, UI |
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 1
Changes (by Mariusz Felisiak):
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/24179#comment:20>
Django
Reporter: gdmka | Owner: Gav
| O'Connor
Type: New feature | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
FilteredSelectMultiple, | checkin
filter_horizontal, UI |
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 1
Comment (by Carlton Gibson <carlton.gibson@…>):
In [changeset:"fc220d27c624ba5e78988d0545bb241e2c0a8c22" fc220d27]:
{{{
#!CommitTicketReference repository=""
revision="fc220d27c624ba5e78988d0545bb241e2c0a8c22"
Refs #24179 -- Added extra JS tests for admin vertical/horizontal filters.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/24179#comment:21>
Django
Reporter: gdmka | Owner: Gav
| O'Connor
Component: contrib.admin | Version: dev
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
FilteredSelectMultiple, | checkin
filter_horizontal, UI |
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 1
Changes (by Carlton Gibson <carlton.gibson@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"be63c78760924e1335603c36babd0ad6cfaea3c4" be63c787]:
{{{
#!CommitTicketReference repository=""
revision="be63c78760924e1335603c36babd0ad6cfaea3c4"
Fixed #24179 -- Added filtering to selected side of vertical/horizontal
filters.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/24179#comment:22>
Django
Reporter: gdmka | Owner: Gav
| O'Connor
Type: New feature | Status: closed
Component: contrib.admin | Version: dev
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
FilteredSelectMultiple, | checkin
filter_horizontal, UI |
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 1
Comment (by GitHub <noreply@…>):
In [changeset:"a2e580acf62a3de4f9108cc1af061a02b94b1064" a2e580ac]:
{{{
#!CommitTicketReference repository=""
revision="a2e580acf62a3de4f9108cc1af061a02b94b1064"
Refs #24179 -- Fixed selenium tests for offset of admin selector boxes in
fieldset.
Regression in be63c78760924e1335603c36babd0ad6cfaea3c4.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/24179#comment:23>