Re: [Django] #33825: Stop allowing 'django.db.backends.postgresql_psycopg2' in DATABASES

[Django]

#33825: Stop allowing 'django.db.backends.postgresql_psycopg2' in DATABASES
-------------------------------------+-------------------------------------
Reporter: Maxim Danilov | Owner: nobody
Type: | Status: closed
Cleanup/optimization |
Component: Database layer | Version: 4.0
(models, ORM) |
Severity: Normal | Resolution: wontfix
Keywords: db.backend | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Carlton Gibson):

* status: new => closed
* resolution: => wontfix

Comment:

OK, I'm going to say `wontfix` for now. I don't see the value of the
disruption — I suspect a lot of people would need to update their settings
if we removed the shim. That seems needlessly disruptive.

Happy if someone wants to argue differently. (I'm a bit -0)

I think reviewing this again for cleanup as a part of #33308 makes sense.
(When adding Psycopg3 there's some gain to pay for the disruption so...
🤷‍♀️)

--
Ticket URL: <https://code.djangoproject.com/ticket/33825#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#33825: Stop allowing 'django.db.backends.postgresql_psycopg2' in DATABASES
-------------------------------------+-------------------------------------
Reporter: Maxim Danilov | Owner: nobody
Type: | Status: closed
Cleanup/optimization |
Component: Database layer | Version: 4.0
(models, ORM) |
Severity: Normal | Resolution: wontfix
Keywords: db.backend | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Maxim Danilov):

Replying to [comment:2 Carlton Gibson]:

> OK, I'm going to say `wontfix` for now. I don't see the value of the
disruption — I suspect a lot of people would need to update their settings
if we removed the shim. That seems needlessly disruptive.
>
> Happy if someone wants to argue differently. (I'm a bit -0)
>
> I think reviewing this again for cleanup as a part of #33308 makes
sense. (When adding Psycopg3 there's some gain to pay for the disruption
so... 🤷‍♀️)

if you suspect "a lot of people would need to update their settings if we
removed the shim" - probably we can add warning in backend:

{{{
if backend_name == "django.db.backends.postgresql_psycopg2":
# here we can put output warning for wrong named backend
backend_name = "django.db.backends.postgresql"
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/33825#comment:3>

[Django]

#33825: Stop allowing 'django.db.backends.postgresql_psycopg2' in DATABASES
-------------------------------------+-------------------------------------
Reporter: Maxim Danilov | Owner: nobody
Type: | Status: closed
Cleanup/optimization |
Component: Database layer | Version: 4.0
(models, ORM) |
Severity: Normal | Resolution: wontfix
Keywords: db.backend | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Carlton Gibson):

Yes. Absolutely. And that would be the the deprecation path, if we decided
to go that way.

My point was more, I don't think this is worth the disruption at this
stage, prior to #33308.
(If there's a consensus to remove it then fair enough, otherwise I'd say
let's revisit when adding Psycopg3 support.)

--
Ticket URL: <https://code.djangoproject.com/ticket/33825#comment:4>