[Django] #33833: Close button styling issues in admin forms’ submit row
Django
-----------------------------------------+-------------------------------
Reporter: Thibaud Colas | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 4.0
Severity: Normal | Keywords: button, focus
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 1 |
-----------------------------------------+-------------------------------
Picked up as part of reviewing #33728 /
[https://github.com/django/django/pull/15734 PR #15734] – in the admin’s
`submit_line.html` / `submit-row`, the Close button is misaligned:
And it has an unexpected underline on focus:
The misalignment & other spacing issues are particularly visible when
there are multiple buttons displayed, though it’s not clear to me whether
this actually happens in practice:
---
To reproduce this, access a model form with a user who only has "View"
permissions.
--
Ticket URL: <https://code.djangoproject.com/ticket/33833>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: Thibaud Colas | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 4.0
Keywords: button, focus | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
Changes (by Thibaud Colas):
* Attachment "close-button-admin.png" added.
Django
-------------------------------+--------------------------------------
Reporter: Thibaud Colas | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 4.0
Severity: Normal | Resolution:
Keywords: button, focus | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------+--------------------------------------
Changes (by Thibaud Colas):
* Attachment "close-button-focus.png" added.
Django
-------------------------------+--------------------------------------
Reporter: Thibaud Colas | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 4.0
Severity: Normal | Resolution:
Keywords: button, focus | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------+--------------------------------------
Changes (by Thibaud Colas):
* Attachment "close-button-group.png" added.
Django
-------------------------------+--------------------------------------
Reporter: Thibaud Colas | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 4.0
Severity: Normal | Resolution:
Keywords: button, focus | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------+--------------------------------------
Old description:
> Picked up as part of reviewing #33728 /
> [https://github.com/django/django/pull/15734 PR #15734] – in the admin’s
> `submit_line.html` / `submit-row`, the Close button is misaligned:
>
> And it has an unexpected underline on focus:
>
>
> The misalignment & other spacing issues are particularly visible when
> there are multiple buttons displayed, though it’s not clear to me whether
> this actually happens in practice:
>
> ---
>
> To reproduce this, access a model form with a user who only has "View"
> permissions.
New description:
Picked up as part of reviewing #33728 /
[https://github.com/django/django/pull/15734 PR #15734] – in the admin’s
`submit_line.html` / `submit-row`, the Close button is misaligned:
[[Image(https://code.djangoproject.com/raw-attachment/ticket/33833/close-
button-admin.png)]]
And it has an unexpected underline on focus:
[[Image(https://code.djangoproject.com/raw-attachment/ticket/33833/close-
button-focus.png)]]
The misalignment & other spacing issues are particularly visible when
there are multiple buttons displayed, though it’s not clear to me whether
this actually happens in practice:
[[Image(https://code.djangoproject.com/raw-attachment/ticket/33833/close-
button-group.png)]]
This is also the case when buttons are displayed vertically in the
"mobile" viewports.
---
To reproduce this, access a model form with a user who only has "View"
permissions.
--
--
Ticket URL: <https://code.djangoproject.com/ticket/33833#comment:1>
Django
-------------------------------+------------------------------------
Type: Bug | Status: new
Component: contrib.admin | Version: 4.0
Severity: Normal | Resolution:
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------+------------------------------------
* stage: Unreviewed => Accepted
Comment:
Thanks for the report.
--
Ticket URL: <https://code.djangoproject.com/ticket/33833#comment:2>
Django
Reporter: Thibaud Colas | Owner: Leonid Podriz
Type: Bug | Status: assigned
Component: contrib.admin | Version: 4.0
Severity: Normal | Resolution:
Keywords: button, focus | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
-------------------------------+-----------------------------------------
Changes (by Leonid Podriz):
* owner: nobody => Leonid Podriz
* status: new => assigned
* easy: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/33833#comment:3>
Django
-------------------------------+-----------------------------------------
Reporter: Thibaud Colas | Owner: Leonid Podriz
Type: Bug | Status: assigned
Component: contrib.admin | Version: 4.0
Severity: Normal | Resolution:
Keywords: button, focus | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 1 | UI/UX: 1
-------------------------------+-----------------------------------------
* needs_better_patch: 0 => 1
* has_patch: 0 => 1
Comment:
[https://github.com/django/django/pull/15860 PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/33833#comment:4>
Django
Reporter: Thibaud Colas | Owner: Leonid
| Podriz
Type: Bug | Status: assigned
Component: contrib.admin | Version: 4.0
Severity: Normal | Resolution:
| checkin
Has patch: 1 | Needs documentation: 0
Easy pickings: 1 | UI/UX: 1
Changes (by Mariusz Felisiak):
* needs_better_patch: 1 => 0
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/33833#comment:5>
Django
-------------------------------------+-------------------------------------
Reporter: Thibaud Colas | Owner: Leonid
| Podriz
Component: contrib.admin | Version: 4.0
Severity: Normal | Resolution: fixed
Keywords: button, focus | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"eae973df6671568a79f3e55b0c971078236100d4" eae973df]:
{{{
#!CommitTicketReference repository=""
revision="eae973df6671568a79f3e55b0c971078236100d4"
Fixed #33833 -- Corrected .closelink admin CSS.
Co-authored-by: Leonid Podriz <leonid...@pm.me>
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/33833#comment:6>