Re: [Django] #33829: BaseConstraint.deconstruct() and __eq__ operators don't take violation_error_message into account.

[Django]

#33829: BaseConstraint.deconstruct() and __eq__ operators don't take
violation_error_message into account.
-------------------------------------+-------------------------------------
Reporter: Mariusz Felisiak | Owner: twidi
Type: Bug | Status: assigned
Component: Database layer | Version: 4.1
(models, ORM) |
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* needs_better_patch: 0 => 1
* needs_tests: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/33829#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#33829: BaseConstraint.deconstruct() and __eq__ operators don't take
violation_error_message into account.
-------------------------------------+-------------------------------------
Reporter: Mariusz Felisiak | Owner: twidi
Type: Bug | Status: assigned
Component: Database layer | Version: 4.1
(models, ORM) |
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by twidi):

Here is the [https://github.com/django/django/pull/15828 Pull request]

--
Ticket URL: <https://code.djangoproject.com/ticket/33829#comment:4>

[Django]

#33829: BaseConstraint.deconstruct() and __eq__ operators don't take
violation_error_message into account.
-------------------------------------+-------------------------------------

Reporter: Mariusz Felisiak | Owner: Stéphane
| "Twidi" Angel

Type: Bug | Status: assigned
Component: Database layer | Version: 4.1
(models, ORM) |
Severity: Release blocker | Resolution:

Keywords: | Triage Stage: Ready for
| checkin

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Mariusz Felisiak):

* needs_better_patch: 1 => 0
* needs_tests: 1 => 0
* stage: Accepted => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/33829#comment:5>

[Django]

#33829: BaseConstraint.deconstruct() and __eq__ operators don't take
violation_error_message into account.
-------------------------------------+-------------------------------------
Reporter: Mariusz Felisiak | Owner: Stéphane
| "Twidi" Angel

Type: Bug | Status: closed

Component: Database layer | Version: 4.1
(models, ORM) |

Severity: Release blocker | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Mariusz Felisiak <felisiak.mariusz@…>):

* status: assigned => closed
* resolution: => fixed

Comment:

In [changeset:"ccbf714ebeff51d1370789e5e487a978d0e2dbfb" ccbf714]:
{{{
#!CommitTicketReference repository=""
revision="ccbf714ebeff51d1370789e5e487a978d0e2dbfb"
Fixed #33829 -- Made BaseConstraint.deconstruct() and equality handle
violation_error_message.

Regression in 667105877e6723c6985399803a364848891513cc.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/33829#comment:6>

[Django]

#33829: BaseConstraint.deconstruct() and __eq__ operators don't take
violation_error_message into account.
-------------------------------------+-------------------------------------
Reporter: Mariusz Felisiak | Owner: Stéphane
| "Twidi" Angel
Type: Bug | Status: closed
Component: Database layer | Version: 4.1
(models, ORM) |
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

In [changeset:"a3d35af26ab96598a38e9b16beac541ddb7f5aba" a3d35af]:
{{{
#!CommitTicketReference repository=""
revision="a3d35af26ab96598a38e9b16beac541ddb7f5aba"
[4.1.x] Fixed #33829 -- Made BaseConstraint.deconstruct() and equality
handle violation_error_message.

Regression in 667105877e6723c6985399803a364848891513cc.

Backport of ccbf714ebeff51d1370789e5e487a978d0e2dbfb from main
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/33829#comment:7>

[Django]

#33829: BaseConstraint.deconstruct() and __eq__ operators don't take
violation_error_message into account.
-------------------------------------+-------------------------------------
Reporter: Mariusz Felisiak | Owner: Stéphane
| "Twidi" Angel
Type: Bug | Status: closed
Component: Database layer | Version: 4.1
(models, ORM) |
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

In [changeset:"51c9bb7cd16081133af4f0ab6d06572660309730" 51c9bb7]:
{{{
#!CommitTicketReference repository=""
revision="51c9bb7cd16081133af4f0ab6d06572660309730"
Refs #33829 -- Added violation_error_message to constraints' __repr__().
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/33829#comment:8>