Re: [Django] #33823: inspectdb should generate related_name on same relation links.

[Django]

#33823: inspectdb should generate related_name on same relation links.
-------------------------------------+-------------------------------------
Reporter: whysage | Owner: whysage
Type: | Status: assigned
Cleanup/optimization |
Component: Core (Management | Version: dev
commands) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by whysage):

Replying to [comment:4 Mariusz Felisiak]:
> Sounds reasonable. Tests are required.

Hi Mariusz Felisiak!

Thank you for reply.

Now I should add some unit tests?

--
Ticket URL: <https://code.djangoproject.com/ticket/33823#comment:5>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#33823: inspectdb should generate related_name on same relation links.
-------------------------------------+-------------------------------------
Reporter: whysage | Owner: whysage
Type: | Status: assigned
Cleanup/optimization |
Component: Core (Management | Version: dev
commands) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak):

> Now I should add some unit tests?

Yes, please.

--
Ticket URL: <https://code.djangoproject.com/ticket/33823#comment:6>

[Django]

#33823: inspectdb should generate related_name on same relation links.
-------------------------------------+-------------------------------------
Reporter: whysage | Owner: whysage
Type: | Status: assigned
Cleanup/optimization |
Component: Core (Management | Version: dev
commands) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by whysage):

Replying to [comment:6 Mariusz Felisiak]:

> > Now I should add some unit tests?
>
> Yes, please.

ok

--
Ticket URL: <https://code.djangoproject.com/ticket/33823#comment:7>

[Django]

#33823: inspectdb should generate related_name on same relation links.
-------------------------------------+-------------------------------------
Reporter: whysage | Owner: whysage
Type: | Status: assigned
Cleanup/optimization |
Component: Core (Management | Version: dev
commands) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by whysage):

Replying to [comment:6 Mariusz Felisiak]:
> > Now I should add some unit tests?
>
> Yes, please.

Test added:
https://github.com/django/django/pull/15819/commits/085896099ba04e86ed8cd54779e1daf5079dacd5

--
Ticket URL: <https://code.djangoproject.com/ticket/33823#comment:8>

[Django]

#33823: inspectdb should generate related_name on same relation links.
-------------------------------------+-------------------------------------
Reporter: whysage | Owner: whysage
Type: | Status: assigned
Cleanup/optimization |
Component: Core (Management | Version: dev
commands) |
Severity: Normal | Resolution:

Keywords: | Triage Stage: Ready for
| checkin

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Mariusz Felisiak):

* needs_tests: 1 => 0
* stage: Accepted => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/33823#comment:9>

[Django]

#33823: inspectdb should generate related_name on same relation links.
-------------------------------------+-------------------------------------
Reporter: whysage | Owner: whysage

Type: | Status: closed

Cleanup/optimization |
Component: Core (Management | Version: dev
commands) |

Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Mariusz Felisiak <felisiak.mariusz@…>):

* status: assigned => closed
* resolution: => fixed

Comment:

In [changeset:"3926e35aa8c947b4c87aea33546b2e45347eaaa3" 3926e35a]:
{{{
#!CommitTicketReference repository=""
revision="3926e35aa8c947b4c87aea33546b2e45347eaaa3"
Fixed #33823 -- Made inspectdb generate unique related_name when reverse
accessor clashes.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/33823#comment:10>