[Django] #27620: Add a TransactionMiddleware
Django
----------------------------------------+------------------------
Reporter: Tim Graham | Owner: nobody
Type: New feature | Status: new
Component: Core (Other) | Version: master
Severity: Normal | Keywords:
Triage Stage: Accepted | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
----------------------------------------+------------------------
With new-style middleware, it should be feasible to write a
`TransactionMiddleware` that works properly (as opposed to the version in
Django 1.7 and older).
--
Ticket URL: <https://code.djangoproject.com/ticket/27620>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
------------------------------+-------------------------------------
Reporter: Tim Graham | Owner: luojiebin
Type: New feature | Status: assigned
Component: Core (Other) | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by luojiebin):
* owner: nobody => luojiebin
* status: new => assigned
Comment:
Do this middleware want to do the same thing as the one in Django 1.7
except that it applies only to view functions, not including those
middleware modules coming after it? Can you explain it in more detail?
Thanks.
--
Ticket URL: <https://code.djangoproject.com/ticket/27620#comment:1>
Django
------------------------------+-------------------------------------
Reporter: Tim Graham | Owner: luojiebin
Type: New feature | Status: assigned
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by luojiebin):
Do this middleware want to do the same thing as the one in Django 1.7
except that it applies only to view functions, not including those
middleware modules coming after it? Can you explain it in more detail?
Thanks.
to [ticket:27620 Tim Graham]:
> With new-style middleware, it should be feasible to write a
`TransactionMiddleware` that works properly (as opposed to the version in
Django 1.7 and older).
--
Ticket URL: <https://code.djangoproject.com/ticket/27620#comment:2>
Django
------------------------------+-------------------------------------
Reporter: Tim Graham | Owner: luojiebin
Type: New feature | Status: assigned
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Tim Graham):
* cc: Florian Apolloner (added)
Comment:
Florian (apollo13) mentioned this idea in #django-dev IRC but later
indicated there may be some problems with it.
--
Ticket URL: <https://code.djangoproject.com/ticket/27620#comment:3>
Django
------------------------------+-------------------------------------
Reporter: Tim Graham | Owner: luojiebin
Type: New feature | Status: assigned
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Florian Apolloner):
@luojiebin That is to be decided, the main issue here - as you noted - is
supporting
[https://docs.djangoproject.com/en/1.10/topics/db/transactions/#django.db.transaction.non_atomic_requests
non_atomic_requests]. Any ideas welcome :D
--
Ticket URL: <https://code.djangoproject.com/ticket/27620#comment:4>
Django
------------------------------+-------------------------------------
Reporter: Tim Graham | Owner: luojiebin
Type: New feature | Status: assigned
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by luojiebin):
But why the previous TransactionMiddleware was deprecated? Only because
ATOMIC_REQUESTS can do the same thing as it? But it can not noly apply to
views, but also other middleware, which ATOMIC_REQUESTS can't do. So, does
the previous TransactionMiddleware cause any problem so that we have to
deprecate it? With the new-style middleware, we can handle the previous
problem, or we can add new feature to TransactionMiddlware with it?
to [comment:4 Florian Apolloner]:
> @luojiebin That is to be decided, the main issue here - as you noted -
is supporting
[https://docs.djangoproject.com/en/1.10/topics/db/transactions/#django.db.transaction.non_atomic_requests
non_atomic_requests]. Any ideas welcome :D
--
Ticket URL: <https://code.djangoproject.com/ticket/27620#comment:5>
Django
------------------------------+------------------------------------
Reporter: Tim Graham | Owner: (none)
Type: New feature | Status: new
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Mariusz Felisiak):
* owner: luojiebin => (none)
* status: assigned => new
--
Ticket URL: <https://code.djangoproject.com/ticket/27620#comment:6>
Django
------------------------------+------------------------------------
Reporter: Tim Graham | Owner: (none)
Severity: Normal | Resolution:
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Ülgen Sarıkavak):
* cc: Ülgen Sarıkavak (added)
--
Ticket URL: <https://code.djangoproject.com/ticket/27620#comment:7>