[Django] #33800: check_for_template_tags_with_the_same_name with libraries in TEMPLATES

118 views
Skip to first unread message

Django

unread,
Jun 23, 2022, 6:25:12 AM6/23/22
to django-...@googlegroups.com
#33800: check_for_template_tags_with_the_same_name with libraries in TEMPLATES
-----------------------------------------+------------------------
Reporter: Claude Paroz | Owner: nobody
Type: Bug | Status: new
Component: Uncategorized | Version: 4.1
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-----------------------------------------+------------------------
I didn't explore this thoroughly, but I think there might be an issue with
the `check_for_template_tags_with_the_same_name` when you add a template
tag library into `TEMPLATES['OPTIONS']['librairies']`.

I'm getting an error like:
(templates.E003) 'my_tags' is used for multiple template tag modules:
'someapp.templatetags.my_tags', 'someapp.templatetags.my_tags'

--
Ticket URL: <https://code.djangoproject.com/ticket/33800>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Jun 23, 2022, 6:58:24 AM6/23/22
to django-...@googlegroups.com
#33800: check_for_template_tags_with_the_same_name with libraries in TEMPLATES
-------------------------------------+-------------------------------------
Reporter: Claude Paroz | Owner: Mariusz
| Felisiak
Type: Bug | Status: assigned
Component: Template system | Version: 4.1
Severity: Release blocker | Resolution:

Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* owner: nobody => Mariusz Felisiak
* status: new => assigned
* component: Uncategorized => Template system
* severity: Normal => Release blocker


Comment:

Thanks for the report. It's a bug in the new system check (see
004b4620f6f4ad87261e149898940f2dcd5757ef and #32987).

--
Ticket URL: <https://code.djangoproject.com/ticket/33800#comment:1>

Django

unread,
Jun 23, 2022, 7:02:31 AM6/23/22
to django-...@googlegroups.com
#33800: check_for_template_tags_with_the_same_name with libraries in TEMPLATES
-------------------------------------+-------------------------------------
Reporter: Claude Paroz | Owner: Mariusz
| Felisiak
Type: Bug | Status: assigned
Component: Template system | Version: 4.1
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* has_patch: 0 => 1
* stage: Unreviewed => Accepted


Comment:

[https://github.com/django/django/pull/15790 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/33800#comment:2>

Django

unread,
Jun 23, 2022, 2:23:30 PM6/23/22
to django-...@googlegroups.com
#33800: check_for_template_tags_with_the_same_name with libraries in TEMPLATES
-------------------------------------+-------------------------------------
Reporter: Claude Paroz | Owner: Mariusz
| Felisiak
Type: Bug | Status: closed

Component: Template system | Version: 4.1
Severity: Release blocker | Resolution: fixed

Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by GitHub <noreply@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"083bfca6b6c00d0f45837a65c2db721eaf46bc07" 083bfca6]:
{{{
#!CommitTicketReference repository=""
revision="083bfca6b6c00d0f45837a65c2db721eaf46bc07"
Fixed #33800 -- Fixed system check for the same template tag module in
installed apps and template tag libraries.

Thanks Claude Paroz for the report.

Regression in 004b4620f6f4ad87261e149898940f2dcd5757ef.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/33800#comment:3>

Django

unread,
Jun 23, 2022, 2:24:54 PM6/23/22
to django-...@googlegroups.com
#33800: check_for_template_tags_with_the_same_name with libraries in TEMPLATES
-------------------------------------+-------------------------------------
Reporter: Claude Paroz | Owner: Mariusz
| Felisiak
Type: Bug | Status: closed
Component: Template system | Version: 4.1
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

In [changeset:"b37a4affcd0e28ed9266e96c04ceadd2b3396aea" b37a4af]:
{{{
#!CommitTicketReference repository=""
revision="b37a4affcd0e28ed9266e96c04ceadd2b3396aea"
[4.1.x] Fixed #33800 -- Fixed system check for the same template tag


module in installed apps and template tag libraries.

Thanks Claude Paroz for the report.

Regression in 004b4620f6f4ad87261e149898940f2dcd5757ef.
Backport of 083bfca6b6c00d0f45837a65c2db721eaf46bc07 from main
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/33800#comment:4>

Reply all
Reply to author
Forward
0 new messages