Re: [Django] #33799: abulk_create() doesn't accept upsert parameters (update_conflicts, update_fields, unique_fields)

34 views
Skip to first unread message

Django

unread,
Jun 23, 2022, 3:36:11 AM6/23/22
to django-...@googlegroups.com
#33799: abulk_create() doesn't accept upsert parameters (update_conflicts,
update_fields, unique_fields)
-------------------------------------+-------------------------------------
Reporter: Dhruva Patil | Owner: Dhruva
| Patil
Type: Bug | Status: assigned
Component: Database layer | Version: 4.1
(models, ORM) |
Severity: Release blocker | Resolution:
Keywords: async orm | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* stage: Accepted => Ready for checkin


--
Ticket URL: <https://code.djangoproject.com/ticket/33799#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Jun 23, 2022, 3:37:10 AM6/23/22
to django-...@googlegroups.com
#33799: abulk_create() doesn't accept upsert parameters (update_conflicts,
update_fields, unique_fields)
-------------------------------------+-------------------------------------
Reporter: Dhruva Patil | Owner: Dhruva
| Patil
Type: Bug | Status: assigned
Component: Database layer | Version: 4.1
(models, ORM) |
Severity: Release blocker | Resolution:
Keywords: async orm | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Dhruva Patil):

Replying to [comment:2 Mariusz Felisiak]:
> Thanks for the report.

No worries!

I've raised a PR for the same: https://github.com/django/django/pull/15788

Let me know if any changes are required.

--
Ticket URL: <https://code.djangoproject.com/ticket/33799#comment:4>

Django

unread,
Jun 23, 2022, 6:16:43 AM6/23/22
to django-...@googlegroups.com
#33799: abulk_create() doesn't accept upsert parameters (update_conflicts,
update_fields, unique_fields)
-------------------------------------+-------------------------------------
Reporter: Dhruva Patil | Owner: Dhruva
| Patil
Type: Bug | Status: closed

Component: Database layer | Version: 4.1
(models, ORM) |
Severity: Release blocker | Resolution: fixed

Keywords: async orm | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak <felisiak.mariusz@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"c627226d05dd52aef59447dcfb29cec2c2b11b8a" c627226d]:
{{{
#!CommitTicketReference repository=""
revision="c627226d05dd52aef59447dcfb29cec2c2b11b8a"
Fixed #33799, Refs #31685 -- Added parameters for updating conflicts to
QuerySeta.abulk_create().
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/33799#comment:5>

Django

unread,
Jun 23, 2022, 6:17:09 AM6/23/22
to django-...@googlegroups.com
#33799: abulk_create() doesn't accept upsert parameters (update_conflicts,
update_fields, unique_fields)
-------------------------------------+-------------------------------------
Reporter: Dhruva Patil | Owner: Dhruva
| Patil
Type: Bug | Status: closed
Component: Database layer | Version: 4.1
(models, ORM) |
Severity: Release blocker | Resolution: fixed
Keywords: async orm | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

In [changeset:"531c96de34d746a58b9b7320378296730312c016" 531c96de]:
{{{
#!CommitTicketReference repository=""
revision="531c96de34d746a58b9b7320378296730312c016"
[4.1.x] Fixed #33799, Refs #31685 -- Added parameters for updating
conflicts to QuerySeta.abulk_create().

Backport of c627226d05dd52aef59447dcfb29cec2c2b11b8a from main
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/33799#comment:6>

Reply all
Reply to author
Forward
0 new messages