[Django] #33754: Request body is closed prematurely by the ASGI handler

27 views
Skip to first unread message

Django

unread,
May 30, 2022, 4:43:41 PM5/30/22
to django-...@googlegroups.com
#33754: Request body is closed prematurely by the ASGI handler
-------------------------------------------+------------------------
Reporter: Jonas Lundberg | Owner: nobody
Type: Uncategorized | Status: new
Component: HTTP handling | Version: 4.1
Severity: Release blocker | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------------+------------------------
The following PR [https://github.com/django/django/pull/15675/] introduces
{{{I/O operation on closed file.}}}, due to closing the ASGI request body
before getting the response, e.g. accessing request.body in a view.

--
Ticket URL: <https://code.djangoproject.com/ticket/33754>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
May 30, 2022, 4:52:50 PM5/30/22
to django-...@googlegroups.com
#33754: Request body is closed prematurely by the ASGI handler
---------------------------------+--------------------------------------

Reporter: Jonas Lundberg | Owner: nobody
Type: Uncategorized | Status: new
Component: HTTP handling | Version: 4.1
Severity: Release blocker | Resolution:

Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+--------------------------------------

Comment (by Jonas Lundberg):

[https://github.com/django/django/pull/15744]

--
Ticket URL: <https://code.djangoproject.com/ticket/33754#comment:1>

Django

unread,
May 30, 2022, 4:55:32 PM5/30/22
to django-...@googlegroups.com
#33754: Request body is closed prematurely by the ASGI handler
-------------------------------------+-------------------------------------
Reporter: Jonas Lundberg | Owner: Jonas
| Lundberg
Type: Uncategorized | Status: assigned

Component: HTTP handling | Version: 4.1
Severity: Release blocker | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Jonas Lundberg):

* owner: nobody => Jonas Lundberg
* status: new => assigned
* has_patch: 0 => 1


--
Ticket URL: <https://code.djangoproject.com/ticket/33754#comment:2>

Django

unread,
May 31, 2022, 2:08:51 AM5/31/22
to django-...@googlegroups.com
#33754: Request body is closed prematurely by the ASGI handler
-------------------------------------+-------------------------------------
Reporter: Jonas Lundberg | Owner: Jonas
| Lundberg
Type: Bug | Status: assigned

Component: HTTP handling | Version: 4.1
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* type: Uncategorized => Bug
* stage: Unreviewed => Accepted


Comment:

Thanks!

Regression in 441103a04d1d167dc870eaaf90e3fba974f67c93.

--
Ticket URL: <https://code.djangoproject.com/ticket/33754#comment:3>

Django

unread,
May 31, 2022, 2:39:54 AM5/31/22
to django-...@googlegroups.com
#33754: Request body is closed prematurely by the ASGI handler
-------------------------------------+-------------------------------------
Reporter: Jonas Lundberg | Owner: Jonas
| Lundberg
Type: Bug | Status: assigned
Component: HTTP handling | Version: 4.1
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Ready for
| checkin

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* stage: Accepted => Ready for checkin


--
Ticket URL: <https://code.djangoproject.com/ticket/33754#comment:4>

Django

unread,
May 31, 2022, 3:35:46 AM5/31/22
to django-...@googlegroups.com
#33754: Request body is closed prematurely by the ASGI handler
-------------------------------------+-------------------------------------
Reporter: Jonas Lundberg | Owner: Jonas
| Lundberg
Type: Bug | Status: closed

Component: HTTP handling | Version: 4.1
Severity: Release blocker | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

In [changeset:"f1e0fc645bb0b2c15d1510c9a8501743297dec9d" f1e0fc6]:
{{{
#!CommitTicketReference repository=""
revision="f1e0fc645bb0b2c15d1510c9a8501743297dec9d"
Fixed #33754 -- Fixed crash with prematurely closed ASGI request body.

Regression in 441103a04d1d167dc870eaaf90e3fba974f67c93.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/33754#comment:6>

Django

unread,
May 31, 2022, 3:35:47 AM5/31/22
to django-...@googlegroups.com
#33754: Request body is closed prematurely by the ASGI handler
-------------------------------------+-------------------------------------
Reporter: Jonas Lundberg | Owner: Jonas
| Lundberg
Type: Bug | Status: closed
Component: HTTP handling | Version: 4.1
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak <felisiak.mariusz@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"6df6c1b9704f6b22d23b3b4c5813bd9e0ab719c1" 6df6c1b]:
{{{
#!CommitTicketReference repository=""
revision="6df6c1b9704f6b22d23b3b4c5813bd9e0ab719c1"
[4.1.x] Fixed #33754 -- Fixed crash with prematurely closed ASGI request
body.

Regression in 441103a04d1d167dc870eaaf90e3fba974f67c93.

Backport of f1e0fc645bb0b2c15d1510c9a8501743297dec9d from main
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/33754#comment:5>

Reply all
Reply to author
Forward
0 new messages