Re: [Django] #33725: Admin sidebar’s filter field should not receive focus when sidebar is closed.
Django
closed.
-------------------------------------+-------------------------------------
Reporter: Thibaud Colas | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 4.0
Severity: Release blocker | Resolution:
Keywords: accessibility, | Triage Stage: Accepted
keyboard, tab stop |
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):
* easy: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/33725#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
closed.
-------------------------------------+-------------------------------------
Type: Bug | Status: assigned
Component: contrib.admin | Version: 4.0
Severity: Release blocker | Resolution:
Keywords: accessibility, | Triage Stage: Accepted
keyboard, tab stop |
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------
* owner: nobody => Sankalp
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/33725#comment:4>
Django
closed.
-------------------------------------+-------------------------------------
Reporter: Thibaud Colas | Owner: Sankalp
Type: Bug | Status: assigned
Component: contrib.admin | Version: 4.0
Severity: Release blocker | Resolution:
Keywords: accessibility, | Triage Stage: Accepted
keyboard, tab stop |
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------
Comment (by Mariusz Felisiak):
Toggling `tabIndex` on `<input id="nav-filter" ...>` should do the trick
here (see a similar solution for links in the sidebar,
780473d75625d014cbe9b0acdea40b7a5970d5d8.)
--
Ticket URL: <https://code.djangoproject.com/ticket/33725#comment:5>
Django
closed.
-------------------------------------+-------------------------------------
Reporter: Thibaud Colas | Owner: Sankalp
Type: Bug | Status: assigned
Component: contrib.admin | Version: 4.0
Severity: Release blocker | Resolution:
Keywords: accessibility, | Triage Stage: Accepted
keyboard, tab stop |
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------
Comment (by Sankalp):
https://github.com/django/django/pull/15716
--
Ticket URL: <https://code.djangoproject.com/ticket/33725#comment:6>
Django
closed.
-------------------------------------+-------------------------------------
Reporter: Thibaud Colas | Owner: Sankalp
Type: Bug | Status: assigned
Component: contrib.admin | Version: 4.0
Severity: Release blocker | Resolution:
Keywords: accessibility, | Triage Stage: Accepted
keyboard, tab stop |
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------
* has_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/33725#comment:7>
Django
closed.
-------------------------------------+-------------------------------------
Reporter: Thibaud Colas | Owner: Sankalp
Type: Bug | Status: assigned
Component: contrib.admin | Version: 4.0
Severity: Release blocker | Resolution:
keyboard, tab stop | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/33725#comment:8>
Django
closed.
-------------------------------------+-------------------------------------
Reporter: Thibaud Colas | Owner: Sankalp
Component: contrib.admin | Version: 4.0
Severity: Release blocker | Resolution: fixed
Keywords: accessibility, | Triage Stage: Ready for
keyboard, tab stop | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"90dcf271147693a8897f644c4c8943c5b73c02f8" 90dcf27]:
{{{
#!CommitTicketReference repository=""
revision="90dcf271147693a8897f644c4c8943c5b73c02f8"
Fixed #33725 -- Made hidden quick filter in admin's navigation sidebar not
focusable.
Regression in d915dd1c5809d7c2bb3679751cd5277571dcd9f7.
Follow up to 780473d75625d014cbe9b0acdea40b7a5970d5d8.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/33725#comment:9>
Django
closed.
-------------------------------------+-------------------------------------
Reporter: Thibaud Colas | Owner: Sankalp
Type: Bug | Status: closed
Component: contrib.admin | Version: 4.0
Severity: Release blocker | Resolution: fixed
Keywords: accessibility, | Triage Stage: Ready for
keyboard, tab stop | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------
Comment (by Mariusz Felisiak <felisiak.mariusz@…>):
In [changeset:"170793f0b0bc753db7565034223110a25adcf753" 170793f0]:
{{{
#!CommitTicketReference repository=""
revision="170793f0b0bc753db7565034223110a25adcf753"
[4.1.x] Fixed #33725 -- Made hidden quick filter in admin's navigation
sidebar not focusable.
Regression in d915dd1c5809d7c2bb3679751cd5277571dcd9f7.
Follow up to 780473d75625d014cbe9b0acdea40b7a5970d5d8.
Backport of 90dcf271147693a8897f644c4c8943c5b73c02f8 from main
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/33725#comment:10>
Django
closed.
-------------------------------------+-------------------------------------
Reporter: Thibaud Colas | Owner: Sankalp
Type: Bug | Status: closed
Component: contrib.admin | Version: 4.0
Severity: Release blocker | Resolution: fixed
Keywords: accessibility, | Triage Stage: Ready for
keyboard, tab stop | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------
Comment (by Mariusz Felisiak <felisiak.mariusz@…>):
In [changeset:"fe2e1478464846638082219c933a4302e5cf3037" fe2e1478]:
{{{
#!CommitTicketReference repository=""
revision="fe2e1478464846638082219c933a4302e5cf3037"
[4.0.x] Fixed #33725 -- Made hidden quick filter in admin's navigation
sidebar not focusable.
Regression in d915dd1c5809d7c2bb3679751cd5277571dcd9f7.
Follow up to 780473d75625d014cbe9b0acdea40b7a5970d5d8.
Backport of 90dcf271147693a8897f644c4c8943c5b73c02f8 from main.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/33725#comment:11>
Django
closed.
-------------------------------------+-------------------------------------
Reporter: Thibaud Colas | Owner: Sankalp
Type: Bug | Status: closed
Component: contrib.admin | Version: 4.0
Severity: Release blocker | Resolution: fixed
Keywords: accessibility, | Triage Stage: Ready for
keyboard, tab stop | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------
Comment (by GitHub <noreply@…>):
In [changeset:"1733c888f4928e91889e4ae5baf6badbd073e08c" 1733c888]:
{{{
#!CommitTicketReference repository=""
revision="1733c888f4928e91889e4ae5baf6badbd073e08c"
Refs #33725 -- Replaced deprecated find_element_by_css_selector() with
find_elements(By.CSS_SELECTOR, …).
Follow up to 90dcf271147693a8897f644c4c8943c5b73c02f8 and
2ccc0b22db6730ba0950b10bbc5238ae575e4a45.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/33725#comment:12>
Django
closed.
-------------------------------------+-------------------------------------
Reporter: Thibaud Colas | Owner: Sankalp
Type: Bug | Status: closed
Component: contrib.admin | Version: 4.0
Severity: Release blocker | Resolution: fixed
Keywords: accessibility, | Triage Stage: Ready for
keyboard, tab stop | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------
Comment (by Mariusz Felisiak <felisiak.mariusz@…>):
In [changeset:"9fc56af0fbd77253bd8e90b8478e32b0d30fc6b9" 9fc56af0]:
{{{
#!CommitTicketReference repository=""
revision="9fc56af0fbd77253bd8e90b8478e32b0d30fc6b9"
[4.1.x] Refs #33725 -- Replaced deprecated find_element_by_css_selector()
with find_elements(By.CSS_SELECTOR, …).
Follow up to 90dcf271147693a8897f644c4c8943c5b73c02f8 and
2ccc0b22db6730ba0950b10bbc5238ae575e4a45.
Backport of 1733c888f4928e91889e4ae5baf6badbd073e08c from main
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/33725#comment:13>