Re: [Django] #33653: Templates crash when calling methods for built-in types.

[Django]

#33653: Templates crash when calling methods for built-in types.
---------------------------------+--------------------------------------
Reporter: Daniel | Owner: Cheng Yuan
Type: Bug | Status: assigned
Component: Template system | Version: 3.2
Severity: Normal | Resolution:
Keywords: template | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+--------------------------------------
Changes (by Cheng Yuan):

* owner: nobody => Cheng Yuan
* status: new => assigned

--
Ticket URL: <https://code.djangoproject.com/ticket/33653#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#33653: Templates crash when calling methods for built-in types.
---------------------------------+--------------------------------------
Reporter: Daniel | Owner: Cheng Yuan
Type: Bug | Status: assigned
Component: Template system | Version: 3.2
Severity: Normal | Resolution:
Keywords: template | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+--------------------------------------
Changes (by Cheng Yuan):

* has_patch: 0 => 1

Comment:

https://github.com/django/django/pull/15698

--
Ticket URL: <https://code.djangoproject.com/ticket/33653#comment:5>

[Django]

#33653: Templates crash when calling methods for built-in types.
---------------------------------+--------------------------------------
Reporter: Daniel | Owner: Cheng Yuan
Type: Bug | Status: assigned
Component: Template system | Version: 3.2
Severity: Normal | Resolution:
Keywords: template | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 1 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
---------------------------------+--------------------------------------

Changes (by Mariusz Felisiak):

* needs_better_patch: 0 => 1
* needs_tests: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/33653#comment:6>

[Django]

#33653: Templates crash when calling methods for built-in types.
---------------------------------+--------------------------------------
Reporter: Daniel | Owner: Cheng Yuan
Type: Bug | Status: assigned
Component: Template system | Version: 3.2
Severity: Normal | Resolution:
Keywords: template | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
---------------------------------+--------------------------------------

Comment (by Cheng Yuan):

Hi Mariusz,

Just saw the flag `Patch needs improvement` is checked. How exactly should
I improve the patch, besides that I need to add tests (or only tests need
to be added)?
I'm a first-time Django contributor any help is appreciated!

Cheng

--
Ticket URL: <https://code.djangoproject.com/ticket/33653#comment:7>

[Django]

#33653: Templates crash when calling methods for built-in types.

-------------------------------------+-------------------------------------

Reporter: Daniel | Owner: Cheng
| Yuan
Type: Bug | Status: assigned
Component: Template system | Version: 3.2
Severity: Normal | Resolution:

Keywords: template | Triage Stage: Ready for
| checkin

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0

-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* needs_better_patch: 1 => 0
* needs_tests: 1 => 0
* stage: Accepted => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/33653#comment:8>

[Django]

#33653: Templates crash when calling methods for built-in types.
-------------------------------------+-------------------------------------
Reporter: Daniel | Owner: Cheng
| Yuan

Type: Bug | Status: closed

Component: Template system | Version: 3.2

Severity: Normal | Resolution: fixed

Keywords: template | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Mariusz Felisiak <felisiak.mariusz@…>):

* status: assigned => closed
* resolution: => fixed

Comment:

In [changeset:"0dd29209091280ccf34e07c9468746c396b7778e" 0dd29209]:
{{{
#!CommitTicketReference repository=""
revision="0dd29209091280ccf34e07c9468746c396b7778e"
Fixed #33653 -- Fixed template crash when calling methods for built-in
types without required arguments.

Regression in 09341856ed9008875c1cc883dc0c287670131458.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/33653#comment:9>