[Django] #27550: add version of GEOSGeometry.normalize() that returns new geometry
Django
-------------------------------------------+------------------------
Reporter: Sergey Fedoseev | Owner: nobody
Type: New feature | Status: new
Component: GIS | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------------+------------------------
GEOSGeometry.normalize() normalizes geometry in-place. In some cases it
would be more convenient to have a cloned normalized geometry for the code
conciseness.
We could add `clone` kwarg to this method similarly to
[https://docs.djangoproject.com/en/1.10/ref/contrib/gis/geos/#django.contrib.gis.geos.GEOSGeometry.clone
GEOSGeometry.clone()] or we could add the `normalized` property.
--
Ticket URL: <https://code.djangoproject.com/ticket/27550>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: Sergey Fedoseev | Owner: Sergey
| Fedoseev
Type: New feature | Status: assigned
Component: GIS | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Sergey Fedoseev):
* status: new => assigned
* owner: nobody => Sergey Fedoseev
--
Ticket URL: <https://code.djangoproject.com/ticket/27550#comment:1>
Django
Reporter: Sergey Fedoseev | Owner: Sergey
| Fedoseev
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Description changed by Sergey Fedoseev:
Old description:
> GEOSGeometry.normalize() normalizes geometry in-place. In some cases it
> would be more convenient to have a cloned normalized geometry for the
> code conciseness.
> We could add `clone` kwarg to this method similarly to
> [https://docs.djangoproject.com/en/1.10/ref/contrib/gis/geos/#django.contrib.gis.geos.GEOSGeometry.clone
> GEOSGeometry.clone()] or we could add the `normalized` property.
New description:
GEOSGeometry.normalize() normalizes geometry in-place. In some cases it
would be more convenient to have a cloned normalized geometry for the code
conciseness.
We could add `clone` kwarg to this method similarly to
[https://docs.djangoproject.com/en/1.10/ref/contrib/gis/geos/#django.contrib.gis.geos.GEOSGeometry.transform
GEOSGeometry.transform()] or we could add the `normalized` property.
--
--
Ticket URL: <https://code.djangoproject.com/ticket/27550#comment:2>
Django
Reporter: Sergey Fedoseev | Owner: Sergey
| Fedoseev
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Claude Paroz):
I'm not sure. Could you audit other methods and tell us if the use case
could be applied to other methods? Then we might better recommend using
the `clone()` method before normalizing the geometry.
--
Ticket URL: <https://code.djangoproject.com/ticket/27550#comment:3>
Django
Reporter: Sergey Fedoseev | Owner: Sergey
| Fedoseev
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Tim Graham):
* stage: Unreviewed => Accepted
Comment:
Accepting the problem, even if the solution is undecided.
--
Ticket URL: <https://code.djangoproject.com/ticket/27550#comment:4>
Django
Reporter: Sergey Fedoseev | Owner: (none)
Type: New feature | Status: new
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Mariusz Felisiak):
* owner: Sergey Fedoseev => (none)
* status: assigned => new
--
Ticket URL: <https://code.djangoproject.com/ticket/27550#comment:5>
Django
Reporter: Sergey Fedoseev | Owner: (none)
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Marcelo Galigniana):
Could I go for the "add `clone` kwarg to this method similarly to
[https://docs.djangoproject.com/en/1.10/ref/contrib/gis/geos/#django.contrib.gis.geos.GEOSGeometry.transform
GEOSGeometry.transform()]" approach?"
Or should I post in the developer email group to define the best solution?
--
Ticket URL: <https://code.djangoproject.com/ticket/27550#comment:6>
Django
Reporter: Sergey Fedoseev | Owner: (none)
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Claude Paroz):
Yes, I think having a patch with the `clone` argument should be welcome.
--
Ticket URL: <https://code.djangoproject.com/ticket/27550#comment:7>
Django
Reporter: Sergey Fedoseev | Owner: Marcelo
| Galigniana
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Marcelo Galigniana):
* owner: (none) => Marcelo Galigniana
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/27550#comment:8>
Django
Reporter: Sergey Fedoseev | Owner: Marcelo
| Galigniana
Type: New feature | Status: assigned
Component: GIS | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Marcelo Galigniana):
* has_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/27550#comment:9>
Django
Reporter: Sergey Fedoseev | Owner: Marcelo
| Galigniana
Type: New feature | Status: assigned
Component: GIS | Version: dev
Severity: Normal | Resolution:
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Mariusz Felisiak):
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/27550#comment:10>
Django
Reporter: Sergey Fedoseev | Owner: Marcelo
| Galigniana
Component: GIS | Version: dev
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Mariusz Felisiak <felisiak.mariusz@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"76af861356eda3b08bc5e15ad1973f980c7604a3" 76af8613]:
{{{
#!CommitTicketReference repository=""
revision="76af861356eda3b08bc5e15ad1973f980c7604a3"
Fixed #27550 -- Allowed GEOSGeometry.normalize() to return a normalized
clone.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/27550#comment:11>