[Django] #33654: Missed function in __all__ in timezone.py

[Django]

#33654: Missed function in __all__ in timezone.py
-------------------------------------+-------------------------------------
Reporter: Andrey | Owner: Andrey Otto
Otto |
Type: | Status: assigned
Cleanup/optimization |
Component: Utilities | Version: 4.0
Severity: Normal | Keywords:
Triage Stage: | Has patch: 0
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 1
UI/UX: 0 |
-------------------------------------+-------------------------------------
In some reason in timezone.py file missed `localdate()` function in
`__all__` list. Because of this PyCharm (for example) highlights import of
`localdate`.

[[Image(file:///home/ray/files_for_projects/django_pycharm.png)]]

--
Ticket URL: <https://code.djangoproject.com/ticket/33654>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#33654: Missed function in __all__ in timezone.py
-------------------------------------+-------------------------------------

Reporter: Andrey Otto | Owner: Andrey
Type: | Otto
Cleanup/optimization | Status: assigned
Component: Utilities | Version: 4.0
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Andrey Otto):

* Attachment "django_pycharm.png" added.

[Django]

#33654: Missed function in __all__ in timezone.py
-------------------------------------+-------------------------------------

Reporter: Andrey Otto | Owner: Carlton
Type: | Gibson

Cleanup/optimization | Status: assigned
Component: Utilities | Version: 4.0
Severity: Normal | Resolution:

Keywords: | Triage Stage: Accepted

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Carlton Gibson):

* owner: Andrey Otto => Carlton Gibson
* stage: Unreviewed => Accepted

Comment:

OK, yep, it's documented, so should likely be included in `__all__`.
Thanks

--
Ticket URL: <https://code.djangoproject.com/ticket/33654#comment:1>

[Django]

#33654: Missed function in __all__ in timezone.py
-------------------------------------+-------------------------------------
Reporter: Andrey Otto | Owner: Carlton
Type: | Gibson
Cleanup/optimization | Status: assigned
Component: Utilities | Version: 4.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Carlton Gibson):

* has_patch: 0 => 1

Comment:

[https://github.com/django/django/pull/15616 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/33654#comment:2>

[Django]

#33654: Missed function in __all__ in timezone.py
-------------------------------------+-------------------------------------
Reporter: Andrey Otto | Owner: Carlton
Type: | Gibson
Cleanup/optimization | Status: assigned
Component: Utilities | Version: 4.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Carlton Gibson):

Already there Andrey. [https://github.com/django/django/pull/15615 PR] 🙂

--
Ticket URL: <https://code.djangoproject.com/ticket/33654#comment:3>

[Django]

#33654: Missed function in __all__ in timezone.py
-------------------------------------+-------------------------------------

Reporter: Andrey Otto | Owner: Andrey
Type: | Otto

Cleanup/optimization | Status: assigned
Component: Utilities | Version: 4.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Carlton Gibson):

* owner: Carlton Gibson => Andrey Otto

--
Ticket URL: <https://code.djangoproject.com/ticket/33654#comment:4>

[Django]

#33654: Missed function in __all__ in timezone.py
-------------------------------------+-------------------------------------
Reporter: Andrey Otto | Owner: Andrey
Type: | Otto
Cleanup/optimization | Status: assigned
Component: Utilities | Version: 4.0
Severity: Normal | Resolution:

Keywords: | Triage Stage: Ready for
| checkin

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Carlton Gibson):

* stage: Accepted => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/33654#comment:5>

[Django]

#33654: Missed function in __all__ in timezone.py
-------------------------------------+-------------------------------------
Reporter: Andrey Otto | Owner: Andrey
Type: | Otto
Cleanup/optimization | Status: assigned
Component: Utilities | Version: 4.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Description changed by Carlton Gibson:

Old description:

> In some reason in timezone.py file missed `localdate()` function in
> `__all__` list. Because of this PyCharm (for example) highlights import
> of `localdate`.
>

> [[Image(file:///home/ray/files_for_projects/django_pycharm.png)]]

New description:

In some reason in timezone.py file missed `localdate()` function in
`__all__` list. Because of this PyCharm (for example) highlights import of
`localdate`.

[[Image(https://code.djangoproject.com/raw-
attachment/ticket/33654/django_pycharm.png)]]

--

--
Ticket URL: <https://code.djangoproject.com/ticket/33654#comment:6>

[Django]

#33654: Missed function in __all__ in timezone.py
-------------------------------------+-------------------------------------
Reporter: Andrey Otto | Owner: Andrey
Type: | Otto

Cleanup/optimization | Status: closed
Component: Utilities | Version: 4.0
Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by GitHub <noreply@…>):

* status: assigned => closed
* resolution: => fixed

Comment:

In [changeset:"420d13edeed8d2848b52f37144fe5edb7baff0cc" 420d13e]:
{{{
#!CommitTicketReference repository=""
revision="420d13edeed8d2848b52f37144fe5edb7baff0cc"
Fixed #33654 -- Added localdate to utils.timezone.__all__.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/33654#comment:7>