Re: [Django] #33588: @never_cache and @cache_page decorators are applied out of order for TemplateResponse. (was: never_cache and cache_page applied out of order for TemplateResponse)

8 views
Skip to first unread message

Django

unread,
Mar 21, 2022, 7:32:09 AM3/21/22
to django-...@googlegroups.com
#33588: @never_cache and @cache_page decorators are applied out of order for
TemplateResponse.
-------------------------------------+-------------------------------------
Reporter: Jacek Wojna | Owner: nobody
Type: Bug | Status: new
Component: Core (Cache system) | Version: 4.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
cache,never_cache,cache_page,TemplateResponse,make_middleware_decorator|
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* cc: Carlton Gibson (added)
* stage: Unreviewed => Accepted


Comment:

Thanks, sounds valid. Unfortunately other decorators are probably also
affected e.g. `@cache_control` (see also #11479 about `@last_modified`).
As far as I'm aware, we could fix both tickets by adding a few hooks to
`FetchFromCacheMiddleware` and `UpdateCacheMiddleware` and use them in the
`@cache_page` decorator instead of relying directly on the
`CacheMiddleware`.

--
Ticket URL: <https://code.djangoproject.com/ticket/33588#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Reply all
Reply to author
Forward
0 new messages