Problem filtering objects in list viewset with custom mixin

[Agnese Camellini]

Hello to everyone, i have an issue filtering objects in my viewset (the GET method of the user endpoint).

The following is the code i used:

"""CUSTOM FILTERS"""
class MultipleFieldLookupMixin(object):
    """
    Apply this mixin to any view or viewset to get multiple field filtering
    based on a `lookup_fields` attribute, instead of the default single field filtering.
    """
    def get_object(self):
        queryset = self.get_queryset()             # Get the base queryset
        queryset = self.filter_queryset(queryset)  # Apply any filter backends
        f = {}
        for field in self.lookup_fields:
            if field in self.kwargs.keys(): # Ignore empty fields.
                f[field] = self.kwargs[field]
        obj = get_object_or_404(queryset, f)  # Lookup the object
        return obj
 
 
class UserView(MultipleFieldLookupMixin, viewsets.ModelViewSet):
    queryset = User.objects.all()
    serializer_class = UserSerializer
    lookup_fields = ['username', 'pwd', 'token_confirm', 'email', 'token_cng_pwd']

I would like to list users optionally on any of these fields..

But when i open the url

http://localhost/api/v3/user/?username=anything

It always shows me the complete list of user..

What can i do to fix the problem?

Thanks a lot

Agnese Camellini

[Agnese Camellini]

Maybe the filtering works but i'm writing the wrong address.

Can someone help?

Agnese

--
You received this message because you are subscribed to the Google Groups "Django REST framework" group.
To unsubscribe from this group and stop receiving emails from it, send an email to django-rest-fram...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/django-rest-framework/5943a785-0094-4749-b62d-6ddb18f56fafo%40googlegroups.com.

[Yezileli Ilomo]

If you want to do filtering on multiple fields why don't you use rest_framework.filters.SearchFilter  as your filter backend and on your view add

search_fields = [field1, field2, ...]

That's what rest_framework.filters.SearchFilter backend is made for.

To view this discussion on the web visit https://groups.google.com/d/msgid/django-rest-framework/CACXuh-R7GbwhtuJXS1oMTjkVghLCKxwr6Hr2-_igKRYygueHsA%40mail.gmail.com.

[Adailton Nascimento]

Firstly if you wanna use your custom mixin instead of drf filter backends you will need to do the following.

you are trying to query query param using kwargs it's wrong, instead use self.query_params. and your f is a dict()

def get_queryset(self):
    f = dict()
    for field in self.lookup_fields:
        f.update({field: self.request.query_params.get(field)})
   return # do what you want, remember, it's possible to receive more than one query param from query params, so get_object_or_404 won't work if you pass more than one param.

PS: self.query_params return a dict, so you don't need to use lookup fields instead do ...

def get_queryset(self):
    query_params = self.request.query_params
    return User.objects.filter(**query_params)

PS2:I highly recommend to use drf filter backend.

PS3: a personal tip try to use an idle that allows you to see the source code of the framework you are using. and try to adhere to the use of pdb debugging things it is much easier to identify what you want or just use print. tip: print('>>>>>', self.query_params). :D

[Agnese Camellini]

Thanks a lot Adailton

.

I have figured out by myself di use wury_params but i've made the action more static, for security reasons.

Thanks a lot however.

Agnese

--

You received this message because you are subscribed to the Google Groups "Django REST framework" group.
To unsubscribe from this group and stop receiving emails from it, send an email to django-rest-fram...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/django-rest-framework/ca259028-5a0c-47fa-a324-f56b2f750495o%40googlegroups.com.

[Adailton Nascimento]

You are welcome
Happy that you solve your problem.

Adailton do Nascimento

(11) 95493-7660

Software Engineer

    

To view this discussion on the web visit https://groups.google.com/d/msgid/django-rest-framework/CACXuh-SRtu5r2mWuxieOsnH8Qe3W9d54NU%3DQWakCCcYsUCuaPQ%40mail.gmail.com.