Fellow Reports - September 2020

151 views
Skip to first unread message

Mariusz Felisiak

unread,
Sep 7, 2020, 6:59:20 AM9/7/20
to Django developers (Contributions to Django itself)
Week ending September 6, 2020

Triaged:
    https://code.djangoproject.com/ticket/31965 - MySQL fast-delete optimizations introduced in Django 3.1 don't properly deal with aggregation and cause performance regression. (accepted)
    https://code.djangoproject.com/ticket/31944 - Use addCleanup() to register TestContextDecorator cleanups. (accepted)
    https://code.djangoproject.com/ticket/31962 - Raise a more appriopriate exception when session cannot be updated. (accepted)
    https://code.djangoproject.com/ticket/31957 - ModelAdmin method save_form not documented but being called multiple times (invalid).
    https://code.djangoproject.com/ticket/31966 - from email is not working (invalid)
    https://code.djangoproject.com/ticket/31967 - Resolving an output_field for mixed types crashes in database functions. (accepted)
    https://code.djangoproject.com/ticket/31969 - 'database' option in conf file not working (worksforme)
    https://code.djangoproject.com/ticket/31968 - Handling of no auth backend failed (wontfix)
    https://code.djangoproject.com/ticket/31972 - AuthenticationForm.UsernameField does not change field widget according to USERNAME_FIELD. (wontfix)
    https://code.djangoproject.com/ticket/31973 - TypeError loading data in JSONField if DB has native JSON support (needsinfo)
    https://code.djangoproject.com/ticket/31971 - Would like a BooleanChoiceField in Forms (wontfix)
    https://code.djangoproject.com/ticket/31975 - admin_order_field in ModelAdmin doesn't support sorting on multiple columns (invalid)
    https://code.djangoproject.com/ticket/31977 - Transforms silently don't work in F and OuterRef expressions. (duplicate)
    https://code.djangoproject.com/ticket/31978 - Include hidden username field on password reset to help password managers (accepted)
    https://code.djangoproject.com/ticket/31979 - Make new setup_databases() argument time_keeper optional (accepted)
    https://code.djangoproject.com/ticket/28073 - RemoveField.state_forwards() crashes with AttributeError: 'NoneType' object has no attribute 'is_relation' (wontfix)
    https://code.djangoproject.com/ticket/31980 - manage.py check --deploy should not throw security.W004 warning if SECURE_HSTS_SECONDS is explicitly set to 0 (invalid)
    https://code.djangoproject.com/ticket/31981 - many_to_many add() does not trigger post_save signal for the through class (invalid)
    https://code.djangoproject.com/ticket/31982 - Convert max_age to an int in set_cookie() (accepted)
    https://code.djangoproject.com/ticket/31984 - TypeError: object HttpResponse can't be used in 'await' expression. (needsinfo)

Reviewed/committed:
    https://github.com/django/django/pull/13369 - Fixed #31919 -- Resolved output_field of IntegerField subclasses combinations.
    https://github.com/django/django/pull/13368 - Fixed #31965 -- Adjusted multi-table fast-deletion on MySQL/MariaDB.
    https://github.com/django/django/pull/13356 - Fixed #31952 -- Fixed EmptyFieldListFilter crash with reverse relationships.
    https://github.com/django/django/pull/13342 - Fixed #31934 -- Added note about the default of SameSite cookie flag in modern browsers.
    https://github.com/django/django/pull/13322 - Fixed #31901 -- Prevented content overflowing in the admin changelist with navigation sidebar.
    https://github.com/django/django/pull/13374 - Refs #29887 -- Simplified memcached client instantiation.
    https://github.com/django/django/pull/13363 - Fixed #31948 -- Added tzinfo parameter to TruncDate() and TruncTime().
    https://github.com/django/django/pull/13376 - Refs #11390 -- Clarified dual-calling of ChoiceField.choices callable.
    https://github.com/django/django/pull/13378 - Refs #29887, Refs #24212 -- Added servers configuration hook for memcached backends.
    https://github.com/django/django/pull/13364 - Fixed #31858 -- Reallowed whitespaces in URL paths outside of parameters.
    https://github.com/django/django/pull/13327 - Fixed #31978 -- Added username hint to admin's password reset confirmation form.
    https://github.com/django/django/pull/13381 - Fixed #31979 -- Made django.test.utils.setup_databases()'s time_keeper argument optional.
    https://github.com/django/django/pull/12017 - Refs #21231 -- Backport urllib.parse.parse_qsl() from Python 3.8.
    https://github.com/django/django/pull/13367 - Fixed #31894 -- Added note and tests for JSONField key lookups with QuerySet.exclude().
    https://github.com/django/django/pull/13386 - Fixed #31982 -- Made HttpResponse.set_cookie() cast max_age argument to an integer.

Authored:
    https://github.com/django/django/pull/13379 - Refs #31901 -- Fixed SeleniumTests.test_list_editable_popups with headless mode.
    https://github.com/django/django/pull/13382 - Refs #31224 -- Made sync_to_async() examples with ORM calls use thread sensitive.
    https://github.com/django/django/pull/13385 - Fixed #27417 -- Made RenameField operation a noop for field name case changes on Oracle.

Best,
Mariusz

Mariusz Felisiak

unread,
Sep 14, 2020, 2:12:28 PM9/14/20
to Django developers (Contributions to Django itself)
Week ending September 13, 2020.
    
Triaged:
    https://code.djangoproject.com/ticket/31985 - salted_hmac() docstring shouldn't mention hashlib.new(). (accepted)
    https://code.djangoproject.com/ticket/31986 - Django Admin filter sidebar does not scroll. (accepted)
    https://code.djangoproject.com/ticket/31987 - Cast() crashes with DurationField on MySQL and Oracle. (accepted)
    https://code.djangoproject.com/ticket/31988 - Annotate Case(When()) duplicate objects. (duplicate)
    https://code.djangoproject.com/ticket/31991 - QuerySet.raw() method returns string instead of dict for JSONField(). (wontfix)
    https://code.djangoproject.com/ticket/31990 - QuerySet.ordered property is incorrect after annotate(). (accepted)
    https://code.djangoproject.com/ticket/31989 - Bug in posix implementation of django/core/files/locks.py (accepted)
    https://code.djangoproject.com/ticket/9433 - File locking broken on AFP mounts (fixed)
    https://code.djangoproject.com/ticket/28428 - Add support for Pathlib objects in django.core.files.storage (fixed)
    https://code.djangoproject.com/ticket/31994 - Error in Tutorial 2 (invalid)
    https://code.djangoproject.com/ticket/31995 - Unnecesarry quotes are created by TemporaryUploadedFile. (needsinfo)
    https://code.djangoproject.com/ticket/31996 - Template Mixins (wontfix)
    https://code.djangoproject.com/ticket/15249 - Provide access to a debugger within the development server (wontfix)
    https://code.djangoproject.com/ticket/31998 - Doc'd that TEST['MIRROR'] requires TransactionTestCase. (duplicate)
    https://code.djangoproject.com/ticket/31997 - Regression in Django 3 related to ORM in async tasks (OperationalError: database is locked) (invalid)
    https://code.djangoproject.com/ticket/31999 - Sqlite and datetime aggregates. (invalid)

Reviewed/committed:
    https://github.com/django/django/pull/13189 - Fixed #31791 -- Made technical 404 debug page display the tried URL patterns for Http404.
    https://github.com/django/django/pull/13391 - Fixed #31944 -- Used addCleanup() to register TestContextDecorator cleanups.
    https://github.com/django/django/pull/13394 - Fixed #31985 -- Corrected salted_hmac()'s docstring about supported algorithms.
    https://github.com/django/django/pull/13398 - Fixed #31987 -- Fixed Cast() with DurationField on MySQL.
    https://github.com/django/django/pull/13395 - Fixed #31962 -- Made SessionMiddleware raise SessionInterrupted when session destroyed while request is processing.
    https://github.com/django/djangoproject.com/pull/1021 - Sunset Django People.
    https://github.com/django/django/pull/13124 - Fixed #31750 -- Made models.Field equality compare models for inherited fields.
    https://github.com/django/django/pull/13400 - Fixed #31967 -- Doc'd consequences of resolving an output_field for Value().
    https://github.com/django/django/pull/13402 - Fixed #31992 -- Made admin password reset templates use title/content_title blocks from the base template.
    https://github.com/django/django/pull/13403 - Fixed #31993 -- Added subtitles to admin change/view pages.
    https://github.com/django/django/pull/13406 - Fixed #31943 -- Fixed recreating QuerySet.values()/values_list() when using a pickled Query.
    https://github.com/django/django/pull/13365 - Fixed #31766 -- Made GDALRaster.transform() return a clone for the same SRID and driver.
     
Reviewed:
    https://github.com/django/django/pull/13399 - Refs #23130 -- Added test for BooleanField choices generation.

Authored:
    https://github.com/django/django/pull/13404 - Refs #31956 -- Doc'd consequences of disabling psycopg2's JSONB typecaster.

Best,
Mariusz

Mariusz Felisiak

unread,
Sep 22, 2020, 12:57:59 AM9/22/20
to Django developers (Contributions to Django itself)
Week ending September 20, 2020.

Triaged:
    https://code.djangoproject.com/ticket/32003 - Signature of mocked has_perm() methods is outdated. (accepted)
    https://code.djangoproject.com/ticket/32000 - Do not override "user" variable when User model is used with generic views (wontfix)
    https://code.djangoproject.com/ticket/32001 - Pass obj to user.has_perm() in ModelAdmin (duplicate)
    https://code.djangoproject.com/ticket/32006 - QuerySet with values with annotate generates wrong SQL query on PostgreSQL. (invalid)
    https://code.djangoproject.com/ticket/32007 - QuerySet.annotate() with WhereNode() crashes with AttributeError. (accepted)
    https://code.djangoproject.com/ticket/32008 - sanitize_address() can add newlines in a header that django.core.mail.EmailMessage will refuse. (invalid)
    https://code.djangoproject.com/ticket/32009 - Deployment issue (invalid)
    https://code.djangoproject.com/ticket/32011 - Error when calling add() on ManyRelatedManager with intermediary model (invalid)
    https://code.djangoproject.com/ticket/32012 - Test runner setup_databases crashes with "TEST": {"MIGRATE": False}. (accepted)
    https://code.djangoproject.com/ticket/32013 - Field choice attribute returns different objects in forms. (invalid)
    https://code.djangoproject.com/ticket/32014 - When Upgrading Django1.11 to Django latest (invalid)
    https://code.djangoproject.com/ticket/32016 - mail_admins handler cannot be configured. (needsinfo)
    https://code.djangoproject.com/ticket/32015 - psycopg2 jsonb is not loaded with connections.cursor (duplicate)
    https://code.djangoproject.com/ticket/32017 - TypeError: check() got an unexpected keyword argument 'databases' (invalid)
    https://code.djangoproject.com/ticket/32019 - Typos DIRS value on TEMPLATES constant settings.py (invalid)
    https://code.djangoproject.com/ticket/32021 - Add support to update a JSONField with result from annotation (duplicate)
    https://code.djangoproject.com/ticket/32020 - Wrong multiple Count() annotations. (duplicate)

Reviewed/committed:
    https://github.com/django/django/pull/13416 - Removed hardcoded paths to SpatialRefSys models in tests.
    https://github.com/django/django/pull/13186 - Fixed #31789 -- Added a new headers interface to HttpResponse.
    https://github.com/django/django/pull/13419 - Fixed #32003 -- Added obj argument to has_perm() methods in tests.
    https://github.com/django/django/pull/13420 - Added DatabaseIntrospection.index_default_access_method on the PostgreSQL backend.
    https://github.com/django/django/pull/13413 - Fixed #31636 -- Made BooleanFieldListFilter respect Field.choices.
    https://github.com/django/django/pull/13410 - Fixed #31989 -- Fixed return value of django.core.files.locks.lock()/unlock() on POSIX systems.
    https://github.com/django/django/pull/13310 - Fixed #29887 -- Added a cache backend for pymemcache.
    https://github.com/django/django/pull/13371 - Fixed #31843 -- Fixed pickling named values from QuerySet.values_list().
    https://github.com/django/django/pull/13426 - Fixed #31916 -- Fixed combined queryset crash when combining with ordered combined querysets.

Reviewed:
    https://github.com/django/django/pull/13390 - Fixed #31880 -- Handled overlapping annotations and aggregations.
    https://github.com/django/django/pull/13207 - Fixed #31777 -- Added support for database collations to Char/TextFields.

Authored:
    https://github.com/django/django/pull/13417 - Fixed #31990 -- Fixed QuerySet.ordered for GROUP BY queries on models with Meta.ordering.
    https://github.com/django/django/pull/13422 - Fixed #32007 -- Fixed queryset crash with Q() annotation and aggregation.
    https://github.com/django/django/pull/13430 - Refs #32013 -- Added backward incompatibility note about ModelChoiceIterator changes.

Best,
Mariusz

Mariusz Felisiak

unread,
Sep 29, 2020, 3:53:06 AM9/29/20
to Django developers (Contributions to Django itself)
Week ending September 27, 2020.

Triaged:
    https://code.djangoproject.com/ticket/32023 - HttpRequest.headers doesn't get updated when request.META is updated. (wontfix)
    https://code.djangoproject.com/ticket/32022 - Create Pull Request Templates (invalid)
    https://code.djangoproject.com/ticket/32024 - AttributeError: 'tuple' object has no attribute 'startswith' (invalid)
    https://code.djangoproject.com/ticket/32025 - AttributeError: 'tuple' object has no attribute 'startswith' (duplicate)
    https://code.djangoproject.com/ticket/32026 - AttributeError: 'tuple' object has no attribute 'startswith' (duplicate)
    https://code.djangoproject.com/ticket/32027 - Long words overflow the .errornote area (accepted)
    https://code.djangoproject.com/ticket/32030 - Make Token Generator more universal (duplicate)
    https://code.djangoproject.com/ticket/32016 - mail_admins configuration crashes with ImproperlyConfigured. (accepted)
    https://code.djangoproject.com/ticket/32032 - Aggregate on union of querysets generates invalid SQL (duplicate)
    https://code.djangoproject.com/ticket/32034 - Removed duplicate lookup in AdminSite.app_index view (accepted)
    https://code.djangoproject.com/ticket/32028 - Top-level form rows (not stacked inlines etc.) are not aligned with the form title (wontfix)
    https://code.djangoproject.com/ticket/17943 - Too many open file descriptors while using memcache (needsinfo)
    https://code.djangoproject.com/ticket/32037 - MinValueValidator, MaxValueValidator comparisons are not compatible with there messages (invalid)
    https://code.djangoproject.com/ticket/32039 - psycop2.extras.register_default_jsonb() crashes with TypeError in Django 3.1.1. (needsinfo)
    https://code.djangoproject.com/ticket/32038 - Using EmptyFieldListFilter with GenericForeignKey crashes. (accepted)
    https://code.djangoproject.com/ticket/17955 - Uploading a file without using django forms (invalid)
    https://code.djangoproject.com/ticket/32041 - Detected MIME types can easily be wrong on Windows. (invalid)
    https://code.djangoproject.com/ticket/24723 - Migration writer errors should be more informative (duplicate)
    https://code.djangoproject.com/ticket/32042 - Incorrect messaging when validate_min/validate_max and min_num == max_num. (accepted)
    https://code.djangoproject.com/ticket/32046 - Add a postgres operation to create collations. (accepted)
    https://code.djangoproject.com/ticket/32044 - Add remove_nulls option to Postgres ArrayAgg method (wontfix)

Reviewed/committed:

    https://github.com/django/django/pull/13207 - Fixed #31777 -- Added support for database collations to Char/TextFields.
    https://github.com/django/django/pull/13449 - Fixed #31723 -- Fixed window functions crash with DecimalField on SQLite.
    https://github.com/django/django/pull/13451 - Fixed #32034 -- Removed redundant get_app_config() call in AdminSite.app_index.
    https://github.com/django/django/pull/13442 - Fixed #32027 -- Fixed wrapping of long words in admin error messages.
    https://github.com/django/django/pull/13433 - Fixed #32029 -- Removed unnecessary margin in admin CSS for horizontal radio inputs.
    https://github.com/django/django/pull/13355 - Fixed #30563 -- Optimized form Media by removing duplicated assets when adding.
    https://github.com/django/django/pull/13148 - Fixed #28009 -- Doc'd empty_value for CharField subclasses.

Reviewed:
    https://github.com/django/django/pull/13446 - Fixed #32016 -- Clarified manual logging config docs.

Authored:
    https://github.com/django/django/pull/13448 - Fixed #32012 -- Made test database creation sync apps models when migrations are disabled.
    https://github.com/django/django/pull/13454 - Fixed #32038 -- Fixed EmptyFieldListFilter crash with GenericRelation.

Best,
Mariusz

Mariusz Felisiak

unread,
Oct 7, 2020, 12:58:02 AM10/7/20
to Django developers (Contributions to Django itself)
Week ending October 2, 2020.

Triaged:
    https://code.djangoproject.com/ticket/32047 - Required mutually exclusive groups don't work with boolean arguments. (accepted)
    https://code.djangoproject.com/ticket/32051 - Animation issues with rocket on Congrats new project page. (accepted)
    https://code.djangoproject.com/ticket/32045 - Document that GenericRelation.remove()/clear() delete objects. (accepted)
    https://code.djangoproject.com/ticket/32052 - Change password link in UserAdmin is still available for the staff user's with 'change_user" permission and lack of 'change_password' one (invalid)
    https://code.djangoproject.com/ticket/32055 - Add Surrogate-Control header to the 304 response (wontfix)
    https://code.djangoproject.com/ticket/32056 - Improve assigning to the reverse side of a OneToOne relationship (duplicate)
    https://code.djangoproject.com/ticket/14660 - Using a CheckboxSelectMultiple widget on a M to M field in Admin causes 'SelectBox is not defined' JS error in RelatedObjectLookups.js (fixed)
    https://code.djangoproject.com/ticket/32058 - Add count() to RawQuerySet. (wontfix)
    https://code.djangoproject.com/ticket/32060 - Expose Random() as a function instead of an expression. (accepted)
    https://code.djangoproject.com/ticket/32041 - Document Windows caveats in mimetypes warning. (accepted)
    https://code.djangoproject.com/ticket/32062 - Add %b support to Date.strftime. (accepted)
    https://code.djangoproject.com/ticket/32063 - windowname_to_id function missing from RelatedObjectLookup.js (invalid)
    https://code.djangoproject.com/ticket/9338 - inline formset should have can_order=True when using order_with_respect_to (wontfix)
    https://code.djangoproject.com/ticket/2316 - GenericRelation and get_or_create do not work together (duplicate)
    https://code.djangoproject.com/ticket/9682 - icontains can be case-sensitive on MySQL (fixed)
    https://code.djangoproject.com/ticket/32064 - runserver sometimes hangs on Windows 10 with PostgreSQL. (invalid)
    https://code.djangoproject.com/ticket/32066 - Sporadic FileNotFoundError on source changes with runserver (needsinfo)
    https://code.djangoproject.com/ticket/32068 - Raise a descriptive error on get() with filters operation following QuerySet.union(), intersection(), and difference(). (accepted)

Reviewed/committed:
    https://github.com/django/django/pull/13458 - Fixed #32042 -- Improved error messages for the number of submitted forms in formsets.
    https://github.com/django/django/pull/13460 - Fixed #18995 -- Made blocktranslate tag raise TemplateSyntaxError when plural count is not a number.
    https://github.com/django/django/pull/13431 - Fixed #31880 -- Made QuerySet.aggregate() raise FieldError when aggregating over aggregation aliases.
    https://github.com/django/django/pull/13350 - Fixed #30422 -- Made TemporaryFileUploadHandler handle interrupted uploads.
    https://github.com/django/django/pull/13466 - Fixed #32047 -- Fixed call_command() crash if a constant option from required mutually exclusive group is passed in options.
    https://github.com/django/django/pull/13409 - Fixed #31986 -- Fixed admin filter sidebar scrolling.
    https://github.com/django/django/pull/13472 - Fixed #32057 -- Doc'd HttpResponse.get()/items().
    https://github.com/django/django/pull/13463 - Fixed #32051 -- Fixed rocket animation on the 'Congrats' page.
    https://github.com/django/django/pull/13474 - Fixed #32041 -- Doc'd how to modify served files' content types on Windows.
    https://github.com/django/django/pull/13473 - Fixed #32060 -- Added Random database function.

Authored:
    https://github.com/django/django/pull/13479 - Refs #31777 -- Doc'd Char/TextField.db_collation parameter in MySQL notes.

Best,
Mariusz
Reply all
Reply to author
Forward
0 new messages