Fellow Reports - March 2023
Mariusz Felisiak
Week ending March 12, 2023
Triaged:
https://code.djangoproject.com/ticket/34380 - Make URLField
assume "https". (accepted)
https://code.djangoproject.com/ticket/34384 -
SECRET_KEY_FALLBACKS is not used for sessions (accepted)
https://code.djangoproject.com/ticket/34389 - Django not
closing database connections on ASGI application after an upgrade
to 4.1 (needsinfo)
https://code.djangoproject.com/ticket/34390 - NoReverseMatch
at /admin/logout/ (invalid)
https://code.djangoproject.com/ticket/31626 - Add asgi support
to runserver (wontfix)
https://code.djangoproject.com/ticket/34391 - Add async
interface to contrib.auth (accepted)
https://code.djangoproject.com/ticket/34393 - A filter query
returns more items than the original queryset provides after
applying INNER JOIN (invalid)
https://code.djangoproject.com/ticket/34394 - ASGIRequest
doesn't respect settings.FORCE_SCRIPT_NAME. (accepted)
https://code.djangoproject.com/ticket/34395 - Update admin's
jQuery to 3.6.4. (created)
https://code.djangoproject.com/ticket/27559 - Admin changelist
turns GET QueryDict into dict which may lose parameters
(duplicate)
https://code.djangoproject.com/ticket/34396 - Add
Postgres+Windows to CI (wontfix)
https://code.djangoproject.com/ticket/34398 - Django should
automatically run migrations on in-memory SQLite DB (invalid)
https://code.djangoproject.com/ticket/34397 - Subclasses of
JSONField call `get_prep_value` with field as value (invalid)
https://code.djangoproject.com/ticket/34400 - ModelFormSet not
adding 'required' to fields (invalid)
https://code.djangoproject.com/ticket/34403 - max_length
argument for the CharField is not respected through shell
(duplicate)
https://code.djangoproject.com/ticket/34405 - Improper
guessing of Mime Type for "br" and "Z" file types (accepted)
https://code.djangoproject.com/ticket/34404 - Incorrect
documentation about content type set by FileResponse object
(accepted)
https://code.djangoproject.com/ticket/34407 - Report faulty
file when some static file has non-utf-8 encoding (accepted)
https://code.djangoproject.com/ticket/34401 - Inconsistent
behavior for refresh_from_db() with GenericForeignKey (duplicate)
https://code.djangoproject.com/ticket/34410 - Adding database
dynamically breaks in Django 4.1+ (invalid)
Reviewed/committed:
https://github.com/django/django/pull/16623 - Fixed #34386 --
Made SMTP backend load default system root CA certificates by
default.
https://github.com/django/django/pull/16626 - Refs #34381 --
Fixed InspectDBTransactionalTests.test_foreign_data_wrapper() on
Windows.
https://github.com/django/django/pull/16547 - Fixed #32172 --
Adapted signals to allow async handlers.
https://github.com/django/django/pull/16552 - Fixed #31920 --
Made AuthenticationMiddleware add request.auser().
https://github.com/django/django/pull/16634 - Refs #31626 --
Noted that Daphne provides a runserver command.
https://github.com/django/django/pull/16637 - Refs #32172 --
Used asgiref coroutine shim in async signals tests.
https://github.com/django/django/pull/16631 - Fixed #34384 --
Fixed session validation when rotation secret keys.
https://github.com/django/django/pull/16601 - Fixed #34370 --
Added integer fields validation as 64-bit on SQLite.
https://github.com/django/django/pull/16053 - Fixed #33985 --
Used app_config.verbose_name in ContentType.__str__().
https://github.com/django/django/pull/16599 - Fixed #27397 --
Prevented integer overflows on integer field lookups.
https://github.com/django/django/pull/16635 - Fixed #34333 --
Fixed migration operations ordering when adding index/constraint
on new foreign key.
https://github.com/django/django/pull/16645 - Corrected
example in CreateCollation() docs.
https://github.com/django/django/pull/16646 - Fixed #34407 --
Reported filename when decoding fails in collectstatic's
post_process.
Authored:
https://github.com/django/django/pull/16639 - Fixed #34395 --
Updated admin's jQuery to 3.6.4.
https://github.com/django/django/pull/16640 - Doc'd that
action descriptions are %-formatted.
https://github.com/django/django/pull/16642 - Fixed #34405 --
Fixed setting Content-Type header in FileResponse for compress and
brotli.
Best,
Mariusz
Mariusz Felisiak
Triaged:
https://code.djangoproject.com/ticket/34409 - Examples of fetching raw SQL don't work for non-unique column names. (accepted)
https://code.djangoproject.com/ticket/34402 - Admin search_fields crashes for inherited model and __iexact lookup. (accepted)
https://code.djangoproject.com/ticket/34399 - dark-mode-vars block is overwritten by extrastyles (invalid)
https://code.djangoproject.com/ticket/34411 - Update obsolete GDAL API for DataSource handling (accepted)
https://code.djangoproject.com/ticket/34414 - Connection to SMTP server not closed after exception (fixed)
https://code.djangoproject.com/ticket/34322 - ManifestStaticFilesStorage crashes on commented JavaScript import statements (accepted)
https://code.djangoproject.com/ticket/34416 - Option start_migration_name for squashmigrations do not work properly (invalid)
https://code.djangoproject.com/ticket/34418 - cache_page decorator should support async view (duplicate)
https://code.djangoproject.com/ticket/34421 - QuerySet.update() on querysets in descending order by annotations. (accepted)
https://code.djangoproject.com/ticket/34422 - inspectdb mysql databases (invalid)
https://code.djangoproject.com/ticket/34420 - Migration import ordering violates coding style and isort defaults (accepted)
https://code.djangoproject.com/ticket/34419 - Document django.contrib.admin.sites.all_sites (accepted)
Reviewed/committed:
https://github.com/django/django/pull/16652 - Refs #28329 -- Fixed Cast() with ForeignKey to integer fields on MySQL.
https://github.com/django/django/pull/16653 - Improved connection clean-up for SMTP backend.
https://github.com/django/django/pull/16644 - Fixed #34404 -- Clarified how FileResponse set Content-Type header.
https://github.com/django/django/pull/16621 - Fixed #1873 -- Handled multi-valued query parameters in admin changelist filters.
https://github.com/django/djangoproject.com/pull/1326 - Set the highest value for recaptcha test on donations page.
https://github.com/django/django/pull/16657 - Fixed #34421 -- Fixed QuerySet.update() on querysets in descending order by annotations.
Authored:
https://github.com/django/django/pull/16648 - Refs #32355 -- Bumped required version of sqlparse in setup.cfg.
https://github.com/django/django/pull/16655 - Reverted "Fixed #33213 -- Doc'd testing code coverage in parallel and used it."
https://github.com/django/django/pull/16656 - Fixed #34322 -- Made ES module support to ManifestStaticFilesStorage optional.
https://github.com/django/django/pull/16660 - [4.2.x] Updated source translation catalogs.
Mariusz
Mariusz Felisiak
Released Django 4.2rc1.
Triaged:
https://code.djangoproject.com/ticket/34423 - Migrations, UniqueConstraint lenght of identifier can be too long for Postgres/MySQL (wontfix)
https://code.djangoproject.com/ticket/34425 - @sensitive_variables doesn't work with async functions (duplicate)
https://code.djangoproject.com/ticket/34424 - SelectDateWidget can crash with OverflowError. (accepted)
https://code.djangoproject.com/ticket/10327 - Pass document.domain to popup windows in admin (wontfix)
https://code.djangoproject.com/ticket/34426 - Pass the BoundField instance to the Widget.render (duplicate)
https://code.djangoproject.com/ticket/34428 - ASGIStaticFilesHandler raises warning. (accepted)
https://code.djangoproject.com/ticket/34430 - Custom exception handler not called (invalid)
https://code.djangoproject.com/ticket/34383 - Layout error in Admin when using help_text (accepted)
https://code.djangoproject.com/ticket/34429 - Allow to set unusable password via admin UI (accepted)
https://code.djangoproject.com/ticket/28900 - QuerySet.values() and values_list() for compound queries fails with annotation. (accepted)
https://code.djangoproject.com/ticket/34433 - OneToOneField can only be saved one way (duplicate)
https://code.djangoproject.com/ticket/34434 - psycopg 3 cursor.execute no longer accepts Python tuple binding (invalid)
https://code.djangoproject.com/ticket/34431 - DateTimeField.input_formats change from Django 3.1 is documented improperly (accepted)
https://code.djangoproject.com/ticket/34435 - JSONField with string default raises fields.E010 warning. (accepted)
https://code.djangoproject.com/ticket/34436 - `makemigrations --check` fails with error code 1 if system checks identify warnings (invalid)
https://code.djangoproject.com/ticket/34437 - values() doesn't mention annotations as valid choices on resolving error (accepted)
Reviewed/committed:
https://github.com/django/django/pull/16662 - Fixed #34420 -- Corrected the order of imports in generated migration files.
https://github.com/django/django/pull/16629 - Fixed #34388 -- Allowed using choice enumeration types directly on model and form fields.
https://github.com/django/django/pull/16670 - Fixed #34428 -- Made ASGIStaticFilesHandler adapt response to async iterator.
https://github.com/django/django/pull/16667 - Fixed #34424 -- Fixed SelectDateWidget crash for inputs raising OverflowError.
https://github.com/django/django/pull/16671 - Fixed typo in docs/topics/class-based-views/mixins.txt.
https://github.com/django/django/pull/16672 - Refs #31949 -- Adjusted error reporting docs.
https://github.com/django/django/pull/16665 - Fixed #34409 -- Doc'd limitation of dictfetchall() and namedtuplefetchall() examples.
https://github.com/django/django/pull/16649 - Fixed #28553 -- Fixed annotation mismatch with QuerySet.values()/values_list() on compound queries.
https://github.com/django/django/pull/16680 - Added Django Forum to mailing lists page.
https://github.com/django/django/pull/16666 - Fixed #34077 -- Added form field rendering.
https://github.com/django/django/pull/16686 - Fixed #34437 -- Made values() resolving error mention selected annotations.
Reviewed:
https://github.com/django/django/pull/16673 - Doc'd use of asgiref.sync adapters with sensitive variables.
Authored:
https://github.com/django/djangoproject.com/pull/1329 - Updated download page for 4.2 release.
https://github.com/django/djangoproject.com/pull/1330 - Updated docs-related model fixtures for 4.2 release.
https://github.com/django/djangoproject.com/pull/1331 - Updated robots.docs.txt for Django 4.2.
https://github.com/django/django/pull/16675 - Refs #33781 -- Restored alignment for admin split-field timezone warnings for RTL languages.
https://github.com/django/django/pull/16677 - Refs #34316 -- Fixed displaying error lists in admin password change forms on small screens.
https://github.com/django/django/pull/16684 - Refs #34316 -- Fixed layout of admin password change forms and help texts for RTL languages.
https://github.com/django/django/pull/16685 - Refs #32539 -- Fixed hide counts icon for RTL languages.
Best,
Mariusz
Mariusz Felisiak
Triaged:
https://code.djangoproject.com/ticket/34438 - UserCreationForm.clean_username() crashes with a custom user model. (accepted)
https://code.djangoproject.com/ticket/34439 - mod_wsgi for django with conda environment in Windows doesn't work (invalid)
https://code.djangoproject.com/ticket/34441 - A new require_files decorator for file validation in Django Framework (wontfix)
https://code.djangoproject.com/ticket/34442 - runserver is slow to accept http connexions when running on 0.0.0.0 (needsinfo)
https://code.djangoproject.com/ticket/34443 - Filtering reverse relations against invalid lookups crashes. (created)
https://code.djangoproject.com/ticket/34444 - Summing through a One-to-Many relationship on the property of a JSONField fails (invalid)
https://code.djangoproject.com/ticket/34446 - Coding style docs should contain incorrect example for Model style. (accepted)
https://code.djangoproject.com/ticket/34447 - Support backgroup async repeat task. just like fastapi_utils.tasks.repeat_every (wontfix)
https://code.djangoproject.com/ticket/34448 - makemessages' --no-obsolete option is undocumented and untested. (accepted)
https://code.djangoproject.com/ticket/34449 - ProgrammingError: non-integer constant in GROUP BY with Case When and annotate Count (fixed)
https://code.djangoproject.com/ticket/34452 - Report the correct port when using port 0 with runserver (duplicate)
Reviewed/committed:
https://github.com/django/django/pull/16602 - Fixed #28948 -- Optimized CookieStorage performances.
https://github.com/django/django/pull/16678 - Fixed #34383 -- Fixed layout of admin fieldsets with multiple fields on the same line.
https://github.com/django/django/pull/16661 - Fixed #28384 -- Fixed ModelAdmin.lookup_allowed() for foreign keys as primary key.
https://github.com/django/django/pull/16690 - Fixed #34438 -- Reallowed extending UserCreationForm.
https://github.com/django/django/pull/16693 - Fixed #34427 -- Improved error message when context processor does not return a dict.
https://github.com/django/django/pull/16697 - Fixed overindentation of AdminURLFieldWidget.
https://github.com/django/django/pull/16706 - Fixed #34446 -- Removed unneeded and incorrect example in coding style docs.
https://github.com/django/django/pull/16707 - Fixed #34445 -- Fixed string-casting of non-string lazy objects.
Authored:
https://github.com/django/django/pull/16694 - Refs #29799 -- Added field instance lookups to suggestions in FieldErrors.
https://github.com/django/django/pull/16695 - Fixed #34443 -- Fixed filtering by transforms on reverse relations.
https://github.com/django/django/pull/16700 - Bumped versions in pre-commit and npm configurations.
https://github.com/django/django/pull/16702 - Refs #34383 -- Corrected margins in admin fieldsets with multiple fields on the same line on small screens.
https://github.com/django/django/pull/16704 - Reverted "Refs #31949 -- Enabled @sensitive_variables to work with async functions."
https://github.com/django/django/pull/16708 - Updated release process for 2.0+ release numbering and latest practices.
Best,
Mariusz