Fellow Reports - February 2021
Mariusz Felisiak
Week ending February 7, 2021
Released Django 3.1.6, 3.0.12, and 2.2.18.
Triaged:
https://code.djangoproject.com/ticket/32402 - django.urls
resolve does not resolve typed paths, like <int:pk>
(invalid)
https://code.djangoproject.com/ticket/32401 - Email template
for resetting password is missing the port the application is
running on (needsinfo)
https://code.djangoproject.com/ticket/32399 - Allow
method_decorator() to accept a list/tuple of method names.
(wontfix)
https://code.djangoproject.com/ticket/32404 - Parallel
TestRunner fails with +1 database replica reference on MacBook
Pro. (duplicate)
https://code.djangoproject.com/ticket/32405 - Inline admin -
last related item also hidden when user has no add_permission
(needsinfo)
https://code.djangoproject.com/ticket/32403 - When run test
with off postgres database got `RuntimeError: generator didn't
yield` instead of connection error (needsinfo)
https://code.djangoproject.com/ticket/32407 - Add token
generator for email verification (wontfix)
https://code.djangoproject.com/ticket/32410 - An empty list is
considered as an empty value for JSONField. (duplicate)
https://code.djangoproject.com/ticket/32411 - Case-insensitive
lookups on JSONField doesn't work on MySQL. (accepted)
https://code.djangoproject.com/ticket/32415 - Error occurs
when migrate db: relation is not existed. (invalid)
https://code.djangoproject.com/ticket/32418 - F() expressions
crash due to some interval/duration error on MySQL. (duplicate)
https://code.djangoproject.com/ticket/32414 - Syntax Error
when combining __in and F() in filter. (duplicate)
https://code.djangoproject.com/ticket/32421 - Add
@cached_property in admindocs. (accepted)
https://code.djangoproject.com/ticket/32423 - Support for
extra related lookup definitions of a field. (wontfix)
https://code.djangoproject.com/ticket/32417 -
LiveServerTestCase._tearDownClassInternal() has unneeded hasattr
check (accepted)
https://code.djangoproject.com/ticket/22382 -
ManyRelatedManager's get_prefetch_queryset doesn't validate the
prefetch types (duplicate)
Reviewed/committed:
https://github.com/django/django/pull/13964 - Fixed #32332 --
Fixed loss of parent with non-numeric pk when saving child after
parent.
https://github.com/django/django/pull/13952 - Fixed #32395 --
Allowed capturing stdout of migration signals.
https://github.com/django/django/pull/13890 - Fixed #32350 --
Fixed showmigrations crash for applied squashed migrations.
https://github.com/django/django/pull/13975 - Fixed #32420 --
Fixed detecting primary key values in deserialization when PK is
also a FK.
https://github.com/django/django/pull/13978 - Fixed #32419 --
Clarified URLconf in example of serving media files.
https://github.com/django/django/pull/13979 - Fixed #32411 --
Fixed __icontains lookup for JSONField on MySQL.
https://github.com/django/django/pull/13951 - Fixed #32394 --
Changed project template settings to use relative STATIC_URL.
Authored:
https://github.com/django/django/pull/13963 - Fixed #32403 --
Fixed re-raising DatabaseErrors when using only 'postgres'
database.
https://github.com/django/django/pull/13969 - Skipped
test_archive tests when bz2/lzma module is not installed.
Best,
Mariusz
Mariusz Felisiak
Triaged:
https://code.djangoproject.com/ticket/17498 - Add a way to register a model with the admin but prevent it from appearing on the app index page (duplicate)
https://code.djangoproject.com/ticket/32429 - Configurable "always available" InclusionNode context variables (wontfix)
https://code.djangoproject.com/ticket/32430 - Documentation for BaseCreateView, BaseUpdateView, and BaseDeleteView. (accepted)
https://code.djangoproject.com/ticket/32413 - File upload permission denied error on large files (invalid)
https://code.djangoproject.com/ticket/32432 - ModelForm does not respect ModelChoiceField's to_field_name attribute (duplicate)
https://code.djangoproject.com/ticket/32434 - Using a RadioSelect widget with ModelChoiceField results in no empty option (wontfix)
https://code.djangoproject.com/ticket/32435 - Bug in JsonField with null=False (invalid)
https://code.djangoproject.com/ticket/32436 - Unable to logout from Django Admin (invalid)
https://code.djangoproject.com/ticket/32437 - LiveServerTestCase.setUpClass() doesn't clean up fully on failure (accepted)
https://code.djangoproject.com/ticket/32440 - Copy/Paste in documentation (invalid)
Reviewed/committed:
https://github.com/django/django/pull/13968 - Fixed #32408 -- Doc'd django.views.generic.detail.BaseDetailView.
https://github.com/django/django/pull/13989 - Fixed #32430 -- Doc'd base class-based views.
https://github.com/django/django/pull/8630 - Fixed #28216 -- Added next_page/get_default_redirect_url() to LoginView.
https://github.com/django/django/pull/13982 - Fixed #32425 -- Fixed adding nullable field with default on MySQL.
https://github.com/django/django/pull/13616 - Fixed #32145 -- Improved makemessages error message when app's locale directory doesn't exist.
https://github.com/django/django/pull/13995 - Fixed #32421 -- Made admindocs ModelDetailView show model cached properties.
https://github.com/django/django/pull/13994 - Enabled build-system isolation via pip.
https://github.com/django/django/pull/13992 - Fixed #32433 -- Added error message on QuerySet.delete() following distinct().
https://github.com/django/django/pull/13998 - Refs #30944 -- Added pyproject.toml to reusable apps docs.
https://github.com/django/django/pull/14002 - Refs #32416 -- Added LiveServerThread.server_class to ease subclassing.
https://github.com/django/django/pull/14003 - Fixed #32438 -- Fixed typo in docs/topics/testing/tools.txt.
https://github.com/django/django/pull/14001 - Fixed #32437 -- Fixed cleaning up ALLOWED_HOSTS in LiveServerTestCase on setUpClass() failure.
https://github.com/django/django/pull/14000 - Simplified introspection of constraints on MySQL.
https://github.com/django/django/pull/14006 - Refs #32394 -- Rephrased release note for STATIC_URL change.
Authored:
https://github.com/django/django/pull/13988 - Used .. attribute:: directive in authentication views docs.
Best,
Mariusz
Mariusz Felisiak
Triaged:
https://code.djangoproject.com/ticket/32443 - Remove "shifted" class from main when nav-sidebar is disabled. (accepted)
https://code.djangoproject.com/ticket/32446 - Deprecate the redundant SERIALIZE test database setting. (accepted)
https://code.djangoproject.com/ticket/32445 - LiveServerThreadTest.test_closes_connections() doesn't pass with non-in-memory SQLite (accepted)
https://code.djangoproject.com/ticket/32447 - ORM query made in `request_finished` signal callback fails in ASGI (wontfix)
https://code.djangoproject.com/ticket/32448 - Django 3.1 and Django 3.0 Internationalization and localization (invalid)
https://code.djangoproject.com/ticket/32449 - Allow specifying tables in RawSQL(). (wontfix)
https://code.djangoproject.com/ticket/32451 - Management command to securely generate a secret key (duplicate)
https://code.djangoproject.com/ticket/32450 - "TypeError: cannot pickle" when applying | operator to a Q object (accepted)
https://code.djangoproject.com/ticket/32452 - Simplify storing strings/bytes in a Storage (wontfix)
https://code.djangoproject.com/ticket/32453 - Introspection doesn't return column order for unique constraints on SQLite. (created)
https://code.djangoproject.com/ticket/32454 - Header's color in django forum site. (invalid)
https://code.djangoproject.com/ticket/32457 - SeparateDatabaseAndState fails with RemoveField (invalid)
https://code.djangoproject.com/ticket/32458 - Make class based Indexes and Constraints have a consistent repr (accepted)
https://code.djangoproject.com/ticket/32459 - Admin inlines not visible on certain screensizes with sidebar open (duplicate)
https://code.djangoproject.com/ticket/32456 - Add support for PostgreSQL passfile to dbshell. (accepted)
https://code.djangoproject.com/ticket/32461 - PostgreSQL UNACCENT function not working on annotations (needsinfo)
https://code.djangoproject.com/ticket/32462 - Django ORM get_readonly_fields, action on a ONE table row (invalid)
https://code.djangoproject.com/ticket/32463 - 'Sum' aggregate function not working with Window function on SQLite. (duplicate)
Reviewed/committed:
https://github.com/django/django/pull/13987 - Fixed #32417 -- Removed unneeded hasattr() check in LiveServerTestCase._tearDownClassInternal().
https://github.com/django/django/pull/13722 - Fixed #26607 -- Allowed customizing formset kwargs with ModelAdmin.get_formset_kwargs().
https://github.com/django/django/pull/13507 - Fixed #29052 -- Made test database creation preserve alias order and prefer the "default" database.
https://github.com/django/django/pull/14014 - Fixed #32453 -- Added introspection of unique constraint field ordering on SQLite.
https://github.com/django/django/pull/13986 - Fixed #32443 -- Removed "shifted" CSS class when admin's sidebar is disabled.
https://github.com/django/django/pull/14016 - Fixed #32450 -- Fixed crash when ANDing/ORing an empty Q() with not pickleable Q().
https://github.com/django/django/pull/14017 - Fixed #32455 -- Allowed right combining Q() with boolean expressions.
https://github.com/django/django/pull/14018 - Refs #30231 -- Fixed SeleniumTests.test_inlines_verbose_name with headless mode.
https://github.com/django/django/pull/13773 - Fixed #32256 -- Fixed migration optimization crash when swapping field names.
https://github.com/django/django/pull/14019 - Fixed #32458 -- Made __repr__() for Index and BaseConstraint subclasses more consistent.
Best,
Mariusz
Mariusz Felisiak
Triaged:
https://code.djangoproject.com/ticket/32471 - Document the return value of EmailMessage.send() (accepted)
https://code.djangoproject.com/ticket/32472 - runserver prematurely closes connection for large response body (accepted)
https://code.djangoproject.com/ticket/32468 - Admin never_cache decorators needs method_decorator (accepted)
https://code.djangoproject.com/ticket/32470 - django.test.Client ignores request.urlconf when setting response.resolver_match (accepted)
https://code.djangoproject.com/ticket/32473 - no additional info is printed even runserver with --verbosity 3 (duplicate)
https://code.djangoproject.com/ticket/32474 - JSONField and register_default_jsonb all json column return as str (duplicate)
https://code.djangoproject.com/ticket/32475 - datadump and dataload subcommands documentation error (invalid)
https://code.djangoproject.com/ticket/32476 - Django Query Generating Style Error (invalid)
https://code.djangoproject.com/ticket/32479 - LocaleMiddleware not recognising properly zh-Hant-HK from the accept-language header (accepted)
https://code.djangoproject.com/ticket/32480 - Outdated docstring in permission_denied() and redundant comments in default error pages. (accepted)
https://code.djangoproject.com/ticket/32482 - Overriding model and/or application order in Admin application is complex and incosistent (duplicate)
https://code.djangoproject.com/ticket/25671 - Arrange models and apps order in Admin. (accepted)
https://code.djangoproject.com/ticket/32467 - django admin widget.attrs not work with ForeignKey (invalid)
https://code.djangoproject.com/ticket/32486 - Migration which removes UniqueTogether constraint containing a ForeignKey fails with MariaDB (MySQL) (duplicate)
https://code.djangoproject.com/ticket/32485 - Django ORM icontains Operator Performance and Response Problem (wontfix)
Reviewed/committed:
https://github.com/django/django/pull/14027 - Fixed #32469 -- Made assertQuerysetEqual() respect maxDiff when ordered=False.
https://github.com/django/django/pull/14021 - Refs #16117 -- Made @action and @display decorators importable from django.contrib.gis.admin.
https://github.com/django/django/pull/14023 - Refs #4027 -- Added Model._state.adding to docs about copying model instances.
https://github.com/django/django/pull/14012 - Fixed #32445 -- Fixed LiveServerThreadTest.test_closes_connections() for non-in-memory database on SQLite.
https://github.com/django/django/pull/14032 - Fixed #32471 -- Doc'd the return value of EmailMessage.send().
https://github.com/django/django/pull/14028 - Fixed #32470 -- Fixed ResolverMatch instance on test clients when request.urlconf is set.
https://github.com/django/django/pull/13983 - Fixed #30916 -- Added support for functional unique constraints.
https://github.com/django/django/pull/14039 - Fixed #32478 -- Included nested columns referenced by subqueries in GROUP BY on aggregations.
https://github.com/django/django/pull/14030 - Fixed #32468 -- Corrected usage of never_cache in contrib.admin.
https://github.com/django/django/pull/14010 - Fixed #32446 -- Deprecated SERIALIZE test database setting.
https://github.com/django/django/pull/14024 - Fixed #32480 -- Corrected docstring and removed redundant comments in django/views/defaults.py.
https://github.com/django/django/pull/13966 - Refs #24121 -- Added __repr__() to FilterExpression, Lexer, Parser, and Token.
https://github.com/django/django/pull/14053 - Fixed #28607 -- Prevented duplicates in HashedFilesMixin post-processing results.
https://github.com/django/django/pull/13990 - Fixed #20423 -- Doc'd that DTL variable names may not be a number.
Authored:
https://github.com/django/django/pull/14052 - Used GitHub actions for docs tests.
https://github.com/django/django/pull/14054 - Refs #32292 -- Made dbshell do not use 'postgres' database when service name is set.
Best,
Mariusz