PR review request

49 views
Skip to first unread message

William Schwartz

unread,
Jan 26, 2021, 3:01:23 PM1/26/21
to Django developers (Contributions to Django itself)
Django committers,

The docs recommend posting here if a pull request hasn't seen any action in awhile—I'm sorry if this nudge is premature! There are a couple of PRs I'd love to get merged into 3.2 before the upcoming beta release. Both PRs' tickets were approved as cleanups/optimizations before the 3.2 feature freeze.
  • More important: #32316's PR-13841, which reduces use of __file__ at the module level. The PR has already seen one round of review and fixes, so hopefully it's (close to) done.
  • Less important: #32317's PR-13842, which refactors the loaddata command. The PR has not yet been reviewed.
Thanks for working with me on these (and several other recent) PRs!

Best,
William

Tim Graham

unread,
Jan 26, 2021, 3:49:08 PM1/26/21
to Django developers (Contributions to Django itself)
Hi William, 3.2 alpha marked the feature freeze. Only non-release blocking bug fixes may be backported at this point (from https://code.djangoproject.com/wiki/Version3.2Roadmap#schedule). There are 28 other patches in the review queue, many of which have been there longer than your tickets, so for future reference, I'd say no need to write to the mailing list at this point. If you have any colleagues, you could ask them to review your patches and mark the ticket as "ready for checkin" if appropriate.  Only the final review is limited to Django's team of mergers.
Reply all
Reply to author
Forward
0 new messages