response_change method has too much dublications

67 views
Skip to first unread message

Jelena Kutalovskaja

unread,
Oct 3, 2014, 4:47:29 PM10/3/14
to django-d...@googlegroups.com
Hello,

what do You think about response_change method in django/contrib/options.py (master)? Maybe this place must be refactored? The code here is pretty much the same, so we can create one method and run each if/elif  through it.

Jelena

Tim Graham

unread,
Oct 3, 2014, 7:27:03 PM10/3/14
to django-d...@googlegroups.com
Thanks for the suggestion, Jelena. I'd be happy to look at a patch, although my initial instinct is that while there is some duplication, adding a method might actually created unneeded complexity and make things somewhat less readable. Feel free to send a pull request if you take a stab at it and think that it's an improvement.
Reply all
Reply to author
Forward
0 new messages