Fellow Reports - July 2023
Mariusz Felisiak
Week ending
July 9, 2023
Released Django 4.2.3, 4.1.10, and 3.2.20.
Triaged:
https://code.djangoproject.com/ticket/34690 - Get ContentType
object with table name in get_by_table_name method (wontfix)
https://code.djangoproject.com/ticket/34689 - Simplify usage
of InlineFormSet in Class-based generic views (duplicate)
https://code.djangoproject.com/ticket/34693 - Add method to
ContentTypeManager to support search for table_name (duplicate)
https://code.djangoproject.com/ticket/34691 - Add a system
check for unmatched URL paths' < / > (accepted)
https://code.djangoproject.com/ticket/34694 - trailing slash
is not appending (worksforme)
https://code.djangoproject.com/ticket/34692 -
django.forms.renderers.get_default_renderer()'s template loader
cache is not being reset on autoloads. (accepted)
https://code.djangoproject.com/ticket/34695 - security.E101
false positive with class-based views (worksforme)
https://code.djangoproject.com/ticket/34696 - Actions
selection counter gets cleared when using Chrome's back button
(accepted)
https://code.djangoproject.com/ticket/34698 - Allow returning
IDs in QuerySet.bulk_create() when updating conflicts.
(accepted)
https://code.djangoproject.com/ticket/34701 - Add support for
NULLS [NOT] DISTINCT to UniqueConstraint (accepted)
https://code.djangoproject.com/ticket/34700 -
ValidatedFileField (duplicate)
https://code.djangoproject.com/ticket/34703 - TypeError:
unhashable type: Netmiko Django (needsinfo)
https://code.djangoproject.com/ticket/34704 - File Size
Validator (duplicate)
Reviewed/committed:
https://github.com/django/django/pull/16897 - Fixed #33405,
Refs #7177 -- Clarified docs for filter escapejs regarding safe
and unsafe usages.
https://github.com/django/django/pull/17043 - Made some
Selenium tests less flaky by adding explicit wait.
https://github.com/django/django/pull/16920 - Fixed #32819 --
Established relationship between form fields and their help
text.
https://github.com/django/django/pull/17046 - Fixed #34639 --
Made admin changelist use distinct() instead of Exists() to
prevent duplicates.
https://github.com/django/django/pull/16950 - Fixed #32210 --
Fixed model inlines with to_field that has a default.
Authored:
https://github.com/django/django/pull/17044 - Fixed isolation
of SeleniumTests.test_search_input_filtered_page() test.
https://github.com/django/django/pull/17047 - Refs #34695 --
Added tests for check for CSRF_FAILURE_VIEW signature with valid
class-based view.
https://github.com/django/django/pull/17048 - Used
AdminSite.is_registered() where appropriate.
https://github.com/django/django/pull/17049 - Fixed #9602 --
Added AdminSite.get_model_admin().
https://github.com/django/django/pull/17050 - Refs #9602 --
Moved AlreadyRegistered/NotRegistered exceptions
django.contrib.admin.exceptions.
Best,
Mariusz
Mariusz Felisiak
Triaged:
https://code.djangoproject.com/ticket/34705 - BoundField.as_widget() ignores aria-describedby in attrs argument (accepted)
https://code.djangoproject.com/ticket/34697 - Migration serializer for sets results in non-deterministic order. (accepted)
https://code.djangoproject.com/ticket/30029 - Generate migration dependencies in a deterministic order (duplicate)
https://code.djangoproject.com/ticket/34708 - db_index=True doesn't apply on MySQL. (invalid)
https://code.djangoproject.com/ticket/34709 - charset should be ignored for the application/x-www-form-urlencoded content type. (created/accepted)
https://code.djangoproject.com/ticket/34715 - have proposal to create new orm method get_object_or_none same as get_object_or_404 (duplicate)
https://code.djangoproject.com/ticket/34713 - Add an option to disable lastmod in Sitemaps. (needsinfo)
https://code.djangoproject.com/ticket/34714 - Async support for get_object_or_404()/get_list_or_404(). (accepted)
Reviewed/committed:
https://github.com/django/django/pull/17039 - Fixed #34688 -- Removed contrib.sitemaps.ping_google() and ping_google management command.
https://github.com/django/django/pull/17055 - Refs #31949 -- Made @csrf_exempt decorator work with async functions.
https://github.com/django/django/pull/17052 - Fixed #34696 -- Updated selection counter in admin changelist on Chrome.
https://github.com/django/django/pull/17056 - Refs #31949 -- Made @vary_on_(cookie/headers) decorators work with async functions.
https://github.com/django/django/pull/17051 - Fixed #34698 -- Made QuerySet.bulk_create() retrieve primary keys when updating conflicts.
https://github.com/django/django/pull/16904 - Fixed #34309 -- Doc'd how to fully delete an app.
https://github.com/django/django/pull/17045 - Fixed #34691 -- Added system check for unmatched angle brackets in path().
https://github.com/django/django/pull/17063 - Removed redundant check from WKTWriter.__init__().
https://github.com/django/django/pull/17065 - Fixed #34705 -- Reallowed BoundField.as_widget()'s attrs argument to set aria-describedby.
https://github.com/django/django/pull/17066 - Fixed #34697 -- Fixed non-deterministic order of dependencies and sets/frozensets in migrations.
https://github.com/django/django/pull/17070 - Fixed #34448 -- Doc'd and tested --no-obsolete option of makemessages.
https://github.com/django/django/pull/17071 - Refs #30686 -- Moved related helpers/constants.
https://github.com/django/django/pull/17011 - Fixed #34677 -- Made admin password reset templates more consistent.
Authored:
https://github.com/django/django/pull/17059 - Refs #31949 -- Mentioned @sensitive_variables/sensitive_post_parameters decorators in async topic.
https://github.com/django/django/pull/17060 - Made @vary_on_cookie decorator reuse @vary_on_headers.
https://github.com/django/django/pull/17062 - Bumped versions in pre-commit and npm configurations.
https://github.com/django/django/pull/17064 - Refs #34691 -- Optimized system check for unmatched angle brackets in path().
https://github.com/django/django/pull/17067 - Refs #30116 -- Simplified tests related with dictionary order.
Best,
Mariusz Felisiak
Triaged:
https://code.djangoproject.com/ticket/34712 - Prevent misconfiguration of `STORAGES` setting (accepted)
https://code.djangoproject.com/ticket/34716 - Class methods from subclasses cannot be used as Field.default. (accepted)
https://code.djangoproject.com/ticket/34711 - Make ChoiceField auto-detect and coerce values. (wontfix)
https://code.djangoproject.com/ticket/34718 - Allow django.contrib.admin's ListFilter to render details tag collasped by default (needsinfo)
https://code.djangoproject.com/ticket/34721 - ChoiceField/TypedChoiceField: .value() has inconsistent behaviour, coercion not applied. (invalid)
https://code.djangoproject.com/ticket/34720 - BaseReloader.watch_dir() incorrectly checks for existence of path (invalid)
https://code.djangoproject.com/ticket/34724 - Allow passing kwargs to django.contrib.admin.decorators.display (wontfix)
https://code.djangoproject.com/ticket/34727 - Error in CharField with TextChoices and missing max_length parameter (invalid)
https://code.djangoproject.com/ticket/34723 - `TypeError` when loading a Django app with incorrect type of `choices` (wontfix)
https://code.djangoproject.com/ticket/34731 - Django test suite still has an occurence of assertEquals, removed in Python 3.12 (accepted)
https://code.djangoproject.com/ticket/34729 - Add explicit option to enable IF EXISTS / IF NOT EXISTS in PostgresQL index operations (wontfix)
https://code.djangoproject.com/ticket/34732 - UnicodeEncodeError on two tests in Python 3.12 (invalid)
Reviewed/committed:
https://github.com/django/django/pull/17082 - Refs #27471 -- Made admin's filter choice arrows use cursor pointers.
https://github.com/django/django/pull/17087 - Fixed #34716 -- Fixed serialization of nested class methods in migrations.
https://github.com/django/django/pull/17073 - Fixed #34036 -- Improved color contrast in admin light theme.
https://github.com/django/django/pull/17084 - Fixed #34717 -- Fixed QuerySet.aggregate() crash when referencing window functions.
https://github.com/django/django/pull/17094 - Reduced unique constraint eligibility code duplication.
https://github.com/django/django/pull/17058 - Fixed #34701 -- Added support for NULLS [NOT] DISTINCT on PostgreSQL 15+.
https://github.com/django/django/pull/17099 - Refs #34362 -- Added get_child_with_renamed_prefix() hook.
https://github.com/django/django/pull/17100 - Refs #29789 -- Added more tests for FilteredRelation with condition outside of relation name.
https://github.com/django/django/pull/17103 - Fixed #34731, Refs #34118 -- Replaced assertEquals() with assertEqual() in test_condition_with_func_and_lookup_outside_relation_name().
https://github.com/django/django/pull/17085 - Refs #24686 -- Made AlterField operation a noop when renaming related model with db_table.
Reviewed:
https://github.com/django/django/pull/17078 - Refs #34711 -- Added reference to TypedChoiceField in ChoiceField docs.
Authored:
https://github.com/django/django/pull/17079 - Refs #34118 -- Improved sanitize_address() error message for tuple with empty strings.
https://github.com/django/django/pull/17090 - Refs #33201 -- Avoided unnecessary queries when renaming models with db_table on SpatiaLite.
Best,
Mariusz
Mariusz Felisiak
Triaged:
https://code.djangoproject.com/ticket/34734 - Django admin theme box (invalid)
https://code.djangoproject.com/ticket/34733 - m2m_changed signal is unaware if .set() method is being called (wontfix)
https://code.djangoproject.com/ticket/34735 - About form validation (invalid)
https://code.djangoproject.com/ticket/34736 - Position of Delete and Save Buttons are reversed in Admin whe moving from v4.1 to v4.2 (invalid)
https://code.djangoproject.com/ticket/34730 - Add an assertMessages assertion (accepted)
https://code.djangoproject.com/ticket/34737 - SynchronousOnlyOperation is raised for non-running event loops on Python 3.7+. (invalid)
https://code.djangoproject.com/ticket/34741 - Admin flashes dark/light depending on settings (duplicate)
https://code.djangoproject.com/ticket/34740 - Admin flashes dark/light depending on settings (duplicate)
https://code.djangoproject.com/ticket/34670 - Django Admin light theme flickers on dark system (accepted)
https://code.djangoproject.com/ticket/34743 - full_clean() raises AttributeError on constraints with related IDs. (accepted)
https://code.djangoproject.com/ticket/34744 - Migration re-add constraints when check condition contains a dict_keys object. (accepted)
https://code.djangoproject.com/ticket/34747 - Django hangs on async views with asycio.gather and an async ORM call (worksforme)
https://code.djangoproject.com/ticket/34748 - __in lookup crashes with a subquery containing an unused annotation that uses explicit grouping. (accepted)
https://code.djangoproject.com/ticket/34749 - acreate function signature in docs is incorrect (accepted)
https://code.djangoproject.com/ticket/34751 - FilteredSelectMultiple ignores select optgroup (duplicate)
https://code.djangoproject.com/ticket/34750 - Fixed QuerySet.count() on querysets grouped by unused multi-valued annotations. (accepted)
https://code.djangoproject.com/ticket/34753 - Document how to properly escape `to` in email messages (invalid)
Reviewed/committed:
https://github.com/django/django/pull/17096 - Fixed #34714 -- Added aget_object_or_404()/aget_list_or_404() shortcuts.
https://github.com/django/django/pull/17107 - Fixed #34532 -- Made formset_factory() respect Form's default_renderer.
https://github.com/django/django/pull/17080 - Refs #34712 -- Doc'd that defining STORAGES overrides the default configuration.
https://github.com/django/django/pull/17115 - Simplified call_command() calls.
https://github.com/django/django/pull/17123 - Fixed #34749 -- Corrected QuerySet.acreate() signature in docs.
https://github.com/django/django/pull/17121 - Fixed #34748 -- Fixed queryset crash when grouping by a reference in a subquery.
Authored:
https://github.com/django/djangoproject.com/pull/1393 - Extended PyCharm fundraiser until July, 31th.
https://github.com/django/django/pull/17129 - Fixed warnings per flake8 6.1.0.
Best,
Mariusz