Should we backport adding support for psycopg2 2.8 to the 1.11.x and 2.1.x?

[Mariusz Felisiak]

Patch for adding support for psycopg2 2.8 is ready (see ticket #30331 and PR11171). Fix is quite straightforward and works with all supported version of psycopg2, i.e. 2.5.4+. The question is, should we backport this fix to the 1.11.x and 2.1.x? Theoretically it doesn't qualify due to our backport policy, because both are in the "extended support" time.

[Adam Johnson]

I'd say backport it. The 1.11 docs say to install 2.5.4 or higher ( https://github.com/django/django/blob/stable/1.11.x/docs/ref/databases.txt#L95 ).  So either you backport the fix or edit the old docs to say <2.8, which is just as much work?

On Thu, 4 Apr 2019 at 13:52, Mariusz Felisiak <felisiak...@gmail.com> wrote:

Patch for adding support for psycopg2 2.8 is ready (see ticket #30331 and PR11171). Fix is quite straightforward and works with all supported version of psycopg2, i.e. 2.5.4+. The question is, should we backport this fix to the 1.11.x and 2.1.x? Theoretically it doesn't qualify due to our backport policy, because both are in the "extended support" time.

--
You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email to django-develop...@googlegroups.com.
To post to this group, send email to django-d...@googlegroups.com.
Visit this group at https://groups.google.com/group/django-developers.
To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/46e34105-d7b3-4026-b275-738c8b6c7d01%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--

Adam

[Mariusz Felisiak]

The only difference is that backporting the fix has some risk of regression.

[Carlton Gibson]

OK, so for me, this should go into v2.2, but not v2.1 or v1.11. (I see you already backported to 2.2 so... 🙂)

My general take here is that we could be half-a-notch more generous backporting to the current version (e.g. 2.2 now) but should be just as strict as we are once a version is out of mainstream support. (Loosely: Given how easy the update process is these days, I don't think we do anyone any favours keep older versions on life-support...) 

C.

[Mariusz Felisiak]

Agreed. I will document that 1.11 and 2.1 require psycopg2 2.5.4 through 2.7.7 versions.

We can re-open this discussion in the future if e.g. psycopg2 2.8.x will contain some important security patch.

[אורי‎]

Don't forget 2.0.

I updated my project to use psycopg2==2.7.7 until we upgrade to Django 2.2.

אורי

u...@speedy.net

On Fri, Apr 5, 2019 at 12:35 PM Mariusz Felisiak <felisiak...@gmail.com> wrote:

Agreed. I will document that 1.11 and 2.1 require psycopg2 2.5.4 through 2.7.7 versions.

We can re-open this discussion in the future if e.g. psycopg2 2.8.x will contain some important security patch.

--

You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email to django-develop...@googlegroups.com.
To post to this group, send email to django-d...@googlegroups.com.
Visit this group at https://groups.google.com/group/django-developers.

To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/bae59229-dd3b-4690-9c06-52e322ea1f9b%40googlegroups.com.

[Mariusz Felisiak]

Django 2.0 is no longer supported.