Fellow Reports - November 2023
Mariusz Felisiak
Week ending November 12
I was in Zanzibar and participated in the DjangoCon Africa
conference.
Triaged:
https://code.djangoproject.com/ticket/34946 - Adding a field
with default and db_default drops database level DEFAULT
(accepted)
https://code.djangoproject.com/ticket/34950 - Translate text
(invalid)
https://code.djangoproject.com/ticket/34951 - Wrong word
(invalid)
https://code.djangoproject.com/ticket/34948 - USE_TZ=False
causes failure in AdminEmailHandler during DST "fall back"
(invalid)
https://code.djangoproject.com/ticket/34956 - Migration should
not be allowed for a non-deterministic GeneratedField (wontfix)
https://code.djangoproject.com/ticket/34957 - Cannot filter
over annotated "FilteredRelation" since Django 5 (needsinfo)
https://code.djangoproject.com/ticket/34954 - Improve
`output_field` resolution in `GenerateField` (accepted)
https://code.djangoproject.com/ticket/34958 - Intermittent
`messages_tests.tests.TestLevelTags.test_lazy` test failure
(worksforme)
https://code.djangoproject.com/ticket/34960 - Document how to
set nulls_last=True for admin_order_field/ordering (wontfix)
https://code.djangoproject.com/ticket/34955 - Make Concat()
use the database operator `||` on PostgreSQL. (accepted)
Reviewed/committed:
https://github.com/django/django/pull/17446 - Fixed #34946 --
Preserved db_default on combined default field addition.
https://github.com/django/django/pull/17454 - Refs #30446,
Refs #34944 -- Fixed crash when adding GeneratedField with string
Value().
Week ending November 19
Triaged:
https://code.djangoproject.com/ticket/34969 - Documentation is
misleading about SQL equivalent (duplicate)
https://code.djangoproject.com/ticket/34968 - MultiPartParser
silent large header fields size failures (accepted)
https://code.djangoproject.com/ticket/34965 -
@sensitive_variables for coroutine func are not recursive
(needsinfo)
https://code.djangoproject.com/ticket/34964 - Reversing the
order of Q objects in a CheckConstraint generates a migration
(wontfix)
https://code.djangoproject.com/ticket/34973 - Allow making
unpickling warnings an error (wontfix)
https://code.djangoproject.com/ticket/33166 - Add "field" to
the context when rendering widgets. (wontfix)
https://code.djangoproject.com/ticket/34976 - startproject and
startapp should provide feedback (accepted)
Reviewed/committed:
https://github.com/django/django/pull/17462 - Fixed #34958 --
Fixed isolation of messages_tests.tests.TestLevelTags.test_lazy.
https://github.com/django/django/pull/17468 - Fixed #34967 --
Fixed queryset crash when grouping by constants on SQLite <
3.39.
https://github.com/django/django/pull/17455 - Fixed #34919 --
Added scope attribute to admindocs model templates.
https://github.com/django/django/pull/17471 - Fixed #34955 --
Made Concat() use || operator on PostgreSQL.
https://github.com/django/django/pull/17475 - Refs #33690 --
Added missing data-theme selector to example in theming support
docs.
https://github.com/django/django/pull/17478 - Removed obsolete
sentence in custom model field docs.
https://github.com/django/django/pull/17480 - Refs #32819 --
Used auto_id instead of id_for_label as unique identifier for the
field.
https://github.com/django/django/pull/17469 - Refs #32819 --
Established relationship between form fieldsets and their help
text.
https://github.com/django/django/pull/17339 - Doc'd support
for assistive technologies in the admin.
https://github.com/django/django/pull/17487 - Fixed #34975 --
Fixed crash of conditional aggregate() over aggregations.
Authored:
https://github.com/django/django/pull/17470 - Fixed #34944 --
Made GeneratedField.output_field required.
https://github.com/django/django/pull/17484 - Removed obsolete
warnings about asgiref.sync adapters with sensitive variables.
https://github.com/django/django/pull/17488 - Refs #34118 --
Added Python 3.12 to classifiers and tox.ini, and doc'd Python
3.12 compatibility in Django 4.2.x.
https://github.com/django/django/pull/17490 - [4.2.x] Refs
#34118 -- Fixed stacklevel in complex_setting_changed on Python
3.12.
Best,
Mariusz
Mariusz Felisiak
Triaged:
https://code.djangoproject.com/ticket/34977 - Turn link to change password form in admin user change form into a button (accepted)
https://code.djangoproject.com/ticket/34978 - Annotating through an aggregate with RawSQL() raises 1056 "Can't group on" on MySQL/MariaDB. (accepted)
https://code.djangoproject.com/ticket/34980 - Changed migration operation dependencies to namedtuples. (created)
https://code.djangoproject.com/ticket/14810 - Admin inline templates need blocks (wontfix)
https://code.djangoproject.com/ticket/34982 - Visual regression for helptext with RTL languages. (created)
https://code.djangoproject.com/ticket/34986 - Fix up support for PyPy 3.10 (accepted)
https://code.djangoproject.com/ticket/34983 - Deprecate django.utils.itercompat.is_iterable(). (accepted)
https://code.djangoproject.com/ticket/34985 - Migrations raise AppRegistryNotReady when GeneratedField references incorrect fields. (accepted)
https://code.djangoproject.com/ticket/34989 - Set Content-Length where possible for HttpResponses. (accepted)
https://code.djangoproject.com/ticket/34990 - Change external link for CSRF reference docs to OWASP (accepted)
https://code.djangoproject.com/ticket/34991 - Wrong layout of pagination buttons with editable list in the admin. (accepted)
https://code.djangoproject.com/ticket/34993 - Unexpected behaviour when filtering across mult-value (aka tomany) joins. (duplicate)
https://code.djangoproject.com/ticket/34994 - Visual regression in admin checkboxes on mobile (accepted)
Reviewed/committed:
https://github.com/django/django/pull/17491 - Refs #31026 -- Simplified BaseForm.get_context().
https://github.com/django/django/pull/17485 - Added VoiceOver iOS and macOS separately in admin FAQ.
https://github.com/django/django/pull/17505 - Fixed #34984 -- Skipped GeneratedFields when remaking tables on SQLite.
https://github.com/django/django/pull/17512 - Fixed #34990 -- Changed link to OWASP in CSRF docs.
https://github.com/django/django/pull/17511 - Fixed #34987 -- Fixed queryset crash when mixing aggregate and window annotations.
https://github.com/django/django/pull/17447 - Fixed #14611 -- Added query_params argument to RequestFactory and Client classes.
https://github.com/django/django/pull/17510 - Fixed #26827 -- Improved ModelState error message when relations refer model classes.
https://github.com/django/django/pull/17305 - Fixed #34818 -- Prevented GenericIPAddressField from mutating error messages.
https://github.com/django/django/pull/17498 - Fixed #34983 -- Deprecated django.utils.itercompat.is_iterable().
https://github.com/django/django/pull/17463 - Fixed #34968 -- Made multipart parsing of headers raise an error on too long headers.
https://github.com/django/django/pull/17417 - Fixed #34925 -- Prevented Model.refresh_from_db() from mutating list of fields.
https://github.com/django/django/pull/17526 - Refs #34925 -- Avoided altering passed by reference refresh_from_db(fields).
https://github.com/django/django/pull/17525 - Refs #34380 -- Improved docs for forms.URLField.assume_scheme.
Authored:
https://github.com/django/django/pull/17494 - Fixed #34980 -- Changed migration operation dependencies to namedtuples.
https://github.com/django/django/pull/17495 - Refs #34900 -- Added Python 3.13 to daily builds.
https://github.com/django/django/pull/17497 - Refs #34900 -- Skipped argon2-cffi requirement on daily builds for Python 3.13.
https://github.com/django/django/pull/17499 - Added PyPy 3.10 to daily builds.
https://github.com/django/django/pull/17503 - Refs #34900 -- Skipped Selenium requirement on daily builds for Python 3.13.
https://github.com/django/django/pull/17504 - Refs #34986 -- Installed libmemcached-dev in PyPy 3.10 daily builds.
https://github.com/django/django/pull/17506 - Fixed #34985 -- Fixed GeneratedFields.contribute_to_class() crash when apps are not populated.
Best,
Mariusz
Mariusz Felisiak
https://code.djangoproject.com/ticket/34996 - Enhance update_or_create() method with upsert SQL. (wontfix)
https://code.djangoproject.com/ticket/28822 - Add DBCalculatedField to model to annotate models automatically (duplicate)
https://code.djangoproject.com/ticket/34998 - Raising a StopIteration in asynchronous mode hangs the request (wontfix)
https://code.djangoproject.com/ticket/34997 - The name argument is ignored when creating url path using the include() function. (invalid)
https://code.djangoproject.com/ticket/34999 - Admin search bar input doesn't have proper background color when in dark mode (worksforme)
https://code.djangoproject.com/ticket/35000 - Skip redundant defaults to allow INSTANT longtext (among others) column addition in MySQL (accepted)
https://code.djangoproject.com/ticket/35004 - Arrows between "selector available" and "selector chosen" are backwards for RTL languages (accepted)
https://code.djangoproject.com/ticket/35005 - Confirm support for GDAL 3.8 (accepted)
Reviewed/committed:
https://github.com/django/django/pull/17530 - Refs #34986 -- Avoided pickling error in DjangoUnicodeDecodeError.
https://github.com/django/django/pull/17533 - Fixed #34633 -- Made create() method of reverse many-to-one managers clear prefetch_related() cache.
https://github.com/django/django/pull/17536 - Refs #34986 -- Fixed some test assertions for PyPy.
https://github.com/django/django/pull/17531 - Refs #21442 -- Increased test coverage of requests.
https://github.com/django/django/pull/17540 - Removed link to lawrence.com in contrib.sites docs.
https://github.com/django/django/pull/17543 - Removed hard-coded expected results in SeleniumTests.test_select_multiple test.
https://github.com/django/django/pull/17541 - Refs #25778 -- Updated some links and references to HTTPS.
https://github.com/django/django/pull/17548 - Updated conditions to retrieve primary keys in bulk_create() docs.
https://github.com/django/django/pull/17551 - Removed unused GeoIP2.info property.
https://github.com/django/django/pull/17549 - Improved structure of Contributing Guide start page.
https://github.com/django/django/pull/17558 - Fixed #35003 -- Corrected margins in admin for RTL languages.
https://github.com/django/django/pull/17502 - Improved wording in auth.models.User field docs.
https://github.com/django/django/pull/17550 - Made GeoIP2.__del__() close all databases.
https://github.com/django/django/pull/17567 - Fixed #35002 -- Made UniqueConstraints with fields respect nulls_distinct.
https://github.com/django/django/pull/17569 - Removed unused CSS rules for related widget in RTL.
https://github.com/django/django/pull/17538 - Refs #34380 -- Added FORMS_URLFIELD_ASSUME_HTTPS transitional setting.
https://github.com/django/django/pull/17556 - Fixed #35004 -- Corrected the direction of arrows in admin selector boxes for RTL languages on small screens.
https://github.com/django/django/pull/17557 - Fixed #35006 -- Fixed migrations crash when altering Meta.db_table_comment on SQLite.
Mariusz