Fellow Reports - April 2021

[Mariusz Felisiak]

Week ending April 4, 2021

Rename branch "master" to "main" for:
    - django/djangosnippets.org

Triaged:
    https://code.djangoproject.com/ticket/32597 - generic inline formsets: object has no attribute 'fk' (needsinfo)
    https://code.djangoproject.com/ticket/32595 - mysql DatabaseSchemaEditor can't `quote_value` on byte strings (accepted)
    https://code.djangoproject.com/ticket/32601 - Optimize split_domain_port() by leveraging the regex (duplicate)
    https://code.djangoproject.com/ticket/32605 - Custom Middleware Error ====> WSGI application '<ProjectName>.wsgi.application' could not be loaded; Error importing module. (invalid)
    https://code.djangoproject.com/ticket/32554 - Add Q.empty(), Q.TRUE, Q.FALSE, Q.any(), and Q.all() (wontfix)
    https://code.djangoproject.com/ticket/32608 - Collation test fails on PostgreSQL on Windows due to missing locale (needsinfo)
    https://code.djangoproject.com/ticket/32610 - django.utils.version.get_git_changeset() always returns None. (created)
    https://code.djangoproject.com/ticket/32612 - CSRF tests test_https_malformed_host and test_origin_malformed_host aren't testing what they should (invalid)

Reviewed/committed:
    https://github.com/django/django/pull/14199 - Fixed #32585 -- Fixed Value() crash with DecimalField on SQLite.
    https://github.com/django/django/pull/14182 - Fixed #31487 -- Added precision argument to Round().
    https://github.com/django/django/pull/14155 - Fixed #32572 -- Improved ResolverMatch.__repr__().
    https://github.com/django/django/pull/14138 - Refs #32260 -- Made admindocs and technical 404 debug page use view_func.view_class.
    https://github.com/django/django/pull/14124 - Fixed #32260 -- Made View.as_view() do not use update_wrapper().
    https://github.com/django/django/pull/14195 - Fixed #29127 -- Prevented DiscoverRunner from hiding tagged test with syntax errors.
    https://github.com/django/django/pull/14189 - Fixed #31840 -- Added support for Cross-Origin Opener Policy header.
    https://github.com/django/django/pull/14203 - Refs #32105 -- Moved ExceptionReporter template paths to properties.
    https://github.com/django/django/pull/13873 - Fixed #32204 -- Added quick filter to admin's navigation sidebar.
    https://github.com/django/djangoproject.com/pull/1079 - Added Pycharm banners for 2021 fundraiser.
    https://github.com/django/django/pull/13841 - Fixed #32316 -- Deferred accessing __file__.
    https://github.com/django/djangoproject.com/pull/896 - Moved unsupported releases to a separate table on downloads page.
    https://github.com/django/django/pull/13938 - Fixed #32383 -- Added source map support to ManifestStaticFilesStorage.
    https://github.com/django/django/pull/14180 - Fixed #32532 -- Made DiscoverRunner raise RuntimeError when a test label is a file path.
    https://github.com/django/django/pull/14187 - Fixed #32594 -- Doc'd and tested that Signal.disconnect() with lazy references returns None.

Reviewed:
    https://github.com/django/djangoproject.com/pull/1083 - Updated robots.docs.txt for Django 3.2.
    https://github.com/django/djangoproject.com/pull/1063 - Updated model fixtures for Django 3.2.

Authored:
    https://github.com/django/django/pull/14196 - Fixed #32595 -- Fixed SchemaEditor.quote_value() crash with bytes.
    https://github.com/django/django/pull/14208 - Fixed #32610 -- Fixed get_git_changeset() on Linux.
    https://github.com/django/djangoproject.com/pull/1084 - Updated download page for 3.2 release.

Best,
Mariusz

[Mariusz Felisiak]

Week ending April 11, 2021

Triaged:
   https://code.djangoproject.com/ticket/32606 - Allow rich configuration of Selenium tests (needsinfo)
   https://code.djangoproject.com/ticket/32614 - MiddlewareSyncAsyncTests crashes with asgiref 3.3.2. (accepted)
   https://code.djangoproject.com/ticket/32615 - Autocomplete does not honor model ordering (duplicate)
   https://code.djangoproject.com/ticket/32616 - QuerySet filter() does not preserve the argument order for a WHERE clause (duplicate)
   https://code.djangoproject.com/ticket/32259 - Modernize request attribute names (wontfix)
   https://code.djangoproject.com/ticket/56 - Primary key columns should be UNSIGNED (wontfix)
   https://code.djangoproject.com/ticket/32617 - The word in the document is misspelled (invalid)
   https://code.djangoproject.com/ticket/32618 - Aggregation documentation should mention conditional aggregation (accepted)
   https://code.djangoproject.com/ticket/32619 - 'ManyToOneRel' object has no attribute 'get_limit_choices_to' (invalid)
   https://code.djangoproject.com/ticket/32620 - DEFAULT_AUTO_FIELD subclass check fails for subclasses of BigAutoField and SmallAutoField. (accepted)
   https://code.djangoproject.com/ticket/32621 - class names might follow pep8 (wontfix)
   https://code.djangoproject.com/ticket/32622 - BooleanField raises ValidationErrors when passing False (duplicate)
   https://code.djangoproject.com/ticket/32624 - Avoid using javascript for Local vars show/hide in technical 500 template. (accepted)
   https://code.djangoproject.com/ticket/32623 - Collapsible fieldsets inside inlines do not work (worksforme)
   https://code.djangoproject.com/ticket/32627 - QuerySet.values()/values_list() crash on combined querysets ordered by unannotated columns. (accepted)
   https://code.djangoproject.com/ticket/32626 - TypeError while using Selenium with Django 3.2 (needsinfo)
   https://code.djangoproject.com/ticket/32629 - Autocomplete module broken (duplicate)
   https://code.djangoproject.com/ticket/32630 - Autoreloader doesn't work on Windows 10. (needsinfo)

Reviewed/committed:
   https://github.com/django/django/pull/14216 - [3.2.x] Updated translations from Transifex.
   https://github.com/django/django/pull/14219 - Bumped versions in pre-commit configuration.
   https://github.com/django/django/pull/14212 - Fixed #32544 -- Confirmed support for GDAL 3.2 and GEOS 3.9.
   https://github.com/django/django/pull/14007 - Fixed #32442 -- Used converters on returning fields from INSERT statements.
   https://github.com/django/django/pull/14227 - Fixed #32501 -- Added support for returning fields from INSERT statements on SQLite 3.35+.
   https://github.com/django/django/pull/14234 - Dropped support for GEOS 3.5 and GDAL 2.0.
   https://github.com/django/django/pull/14213 - Fixed #32575 -- Added support for SpatiaLite 5.
   https://github.com/django/django/pull/14238 - Fixed #32620 -- Allowed subclasses of Big/SmallAutoField for DEFAULT_AUTO_FIELD.
   https://github.com/django/django/pull/14239 - Fixed #32624 -- Avoided using JavaScript for "Local vars" show/hide in technical 500 debug page.
   https://github.com/django/django/pull/14134 - Fixed #32535 -- Added note about DEBUG_PROPAGATE_EXCEPTIONS setting to middleware docs.
   https://github.com/django/django/pull/14242 - Fixed #32618 -- Added link to conditional aggregation in aggregation topic guide.
   https://github.com/django/django/pull/14233 - Fixed #31937 -- Eased translation of time strings in some languages.

Reviewed:
   https://github.com/django/django/pull/14223 - Updated asgiref dependency for 3.2 release series.

Authored:
   https://github.com/django/django/pull/14221 - Fixed #32614 -- Fixed MiddlewareSyncAsyncTests tests with asgiref 3.3.2+.
   https://github.com/django/django/pull/14228 - Refs #32074 -- Backported Enum.__repr__() from Python 3.10.
   https://github.com/django/django/pull/14235 - Refs #27488 -- Corrected detection of IsValid() support on SpatiaLite.
   https://github.com/django/django/pull/14240 - Refs #32074 -- Removed usage of Python's deprecated distutils.version package.

Best,
Mariusz

[Mariusz Felisiak]

Week ending April 18, 2021

Triaged:
   https://code.djangoproject.com/ticket/32632 - Query resolution can be at least 3x slower in 3.2 (accepted)
   https://code.djangoproject.com/ticket/32628 - Add extra data to autocomplete request (wontfix)
   https://code.djangoproject.com/ticket/32625 - JSONField with callable default reports ModelForm.has_changed() when it hasn't (invalid)
   https://code.djangoproject.com/ticket/32636 - QuerySet.values()/values_list() crashes on a combined queryset ordered by "extra" select. (created)
   https://code.djangoproject.com/ticket/32634 - AlterField drops contraints in the wrong order when performed as reverse migration (invalid)
   https://code.djangoproject.com/ticket/32637 - Technical 404 debug page doesn't display Http404's message in Django 3.2. (accepted)
   https://code.djangoproject.com/ticket/32638 - threading.Thread.setDaemon has been deprecated in Python 3.10 (duplicate)
   https://code.djangoproject.com/ticket/32639 - ADMINS and MANAGERS may contain invalid email addreses (wontfix)
   https://code.djangoproject.com/ticket/32641 - Log the number of tests found in DiscoverRunner.build_suite() (accepted)
   https://code.djangoproject.com/ticket/32642 - RuntimeError: 'apps.core.apps' declares more than one default AppConfig on custom admin setup (invalid)
   https://code.djangoproject.com/ticket/32646 - add request.json() shortcut (duplicate)
   https://code.djangoproject.com/ticket/32644 - TemplateDoesNotExist for templates in local apps (invalid)
   https://code.djangoproject.com/ticket/32648 - New sitemap 'alternates' generation feature is bugged using default values. (accepted)
   https://code.djangoproject.com/ticket/32649 - ModelAdmin.search_fields crashes for a search term with unbalanced quotes. (accepted)
   https://code.djangoproject.com/ticket/32645 - order_by().update() with joined fields crashes on MySQL/MariaDB. (accepted)
   https://code.djangoproject.com/ticket/32643 - CookieStorage for contrib.messages crashes after upgrade to django 3.2 (accepted)
   https://code.djangoproject.com/ticket/32651 - Combining Q with a Q containing Exists crashes (duplicate)
   https://code.djangoproject.com/ticket/32656 - Broken link (invalid)
   https://code.djangoproject.com/ticket/32657 - Combining an empty Q with a negated Exists un-negates the Exists lookup (accepted).
   https://code.djangoproject.com/ticket/32653 - Quoting names in the Oracle backend is not consistent with the db_table generation. (accepted)
   https://code.djangoproject.com/ticket/19159 - loaddata reports DeserializationError instead of MemoryError (invalid)
   https://code.djangoproject.com/ticket/32659 - Autocomplete field: The results could not be loaded. (needsinfo)

Reviewed/committed:
   https://github.com/django/django/pull/14011 - Fixed #32416 -- Made ThreadedWSGIServer close connections after each thread.
   https://github.com/django/django/pull/14241 - Fixed #32627 -- Fixed QuerySet.values()/values_list() crash on combined querysets ordered by unannotated columns.
   https://github.com/django/django/pull/14142 - Reduced the garbage collection frequency in runtests.py.
   https://github.com/django/django/pull/14255 - Fixed #32635 -- Fixed system check crash for reverse o2o relations in CheckConstraint.check and UniqueConstraint.condition.
   https://github.com/django/django/pull/14266 - Fixed #32643 -- Fixed decoding of messages in the pre-Django 3.2 format.
   https://github.com/django/django/pull/14264 - Removed obsolete version check in setup.py.
   https://github.com/django/django/pull/14261 - Fixed #32641 -- Made DiscoverRunner print the number of found tests.
   https://github.com/django/django/pull/12688 - Fixed #29899 -- Made autodetector use model states instead of model classes.

Reviewed:
   https://github.com/django/django/pull/14259 - Fixed #32648 -- Fixed VariableDoesNotExist rendering sitemaps template.
   https://github.com/django/django/pull/14269 - Fixed #32652 -- Fixed links to new contributors FAQ.

Authored:
   https://github.com/django/django/pull/14252 - Fixed #32637 -- Restored exception message on technical 404 debug page.
   https://github.com/django/django/pull/14262 - Fixed #32649 -- Fixed ModelAdmin.search_fields crash when searching against phrases with unbalanced quotes.

Best,

Mariusz

[Mariusz Felisiak]

Week ending April 25, 2021

Triaged:
   https://code.djangoproject.com/ticket/32636 - QuerySet.values()/values_list() crashes on a combined queryset ordered by "extra" select. (wontfix)
   https://code.djangoproject.com/ticket/32663 - Remove Error raising on annotation & distinct call (wontfix)
   https://code.djangoproject.com/ticket/32661 - An exception should be raised when trying to save an aware time object. (accepted)
   https://code.djangoproject.com/ticket/32662 - Refactor a generator out from part of SQLCompiler.get_order_by() (accepted)
   https://code.djangoproject.com/ticket/32584 - OrderBy.as_sql() overwrites template, creating invalid syntax for certain database backends (wontfix)
   https://code.djangoproject.com/ticket/32658 - Subquery ignores query ordering (invalid)
   https://code.djangoproject.com/ticket/32664 - Cannot run makemigrations management command without a SECRET_KEY (accepted)
   https://code.djangoproject.com/ticket/32665 - caches.W002 check does not support tuples in STATICFILES_DIRS (accepted)
   https://code.djangoproject.com/ticket/32666 - Clarify mysite/urls.py location for tutorial-01 (invalid)
   https://code.djangoproject.com/ticket/31543 - Default output buffering on in tests (wontfix)
   https://code.djangoproject.com/ticket/18596 - Documentation of JavaScriptCatalog isn't very clear (fixed)
   https://code.djangoproject.com/ticket/32667 - Clarify about tags on BaseCommand.require_system_checks (accepted)
   https://code.djangoproject.com/ticket/21993 - Messages documentation is topic style, there is no ref (needsinfo)
   https://code.djangoproject.com/ticket/21859 - clarify Django docs re: email addresses and ascii (invalid)
   https://code.djangoproject.com/ticket/24822 - Autodetector crashes on add/removal of tzinfo from DateTimeField default (invalid)
   https://code.djangoproject.com/ticket/32669 - Allow autoreloading of `python -m custom_module runserver` (accepted)
   https://code.djangoproject.com/ticket/32670 - django.contrib.gis.GDALRaster support for vsi filesystems (accepted)
   https://code.djangoproject.com/ticket/27534 - Add CSRF_COOKIE_HTTPONLY note to CSRF AJAX docs (duplicate)
   https://code.djangoproject.com/ticket/25012 - Migrations don't make foreign key type changes (fixed)
   https://code.djangoproject.com/ticket/32675 - Migration autodetector detects unnecessary changes. (created)
   https://code.djangoproject.com/ticket/32676 - Migration autodetector changes related_name for self-referential ManyToManyField. (created)
   https://code.djangoproject.com/ticket/32674 - DEFAULT_AUTO_FIELD changes should be detected for PKs of auto-created intermediate M2M models. (accepted)
   https://code.djangoproject.com/ticket/32677 - django.db.models.fields.related.relatedfield not described in the documentation (invalid)
   https://code.djangoproject.com/ticket/32679 - Django model not updating image field correctly (Raw content) (invalid)
   https://code.djangoproject.com/ticket/32683 - class-based view to deal with modelformsets and formsets (duplicate)
   https://code.djangoproject.com/ticket/32684 - Annotate query with Subquery with None value cannot be reliably filtered (or excluded) (duplicate)
   https://code.djangoproject.com/ticket/32681 - Variable lookup errors are logged rendering the admin index page if subtitle is not defined. (accepted)

Reviewed/committed:
   https://github.com/django/django/pull/14230 - Fixed #32611 -- Prevented unecessary setup()/teardown() calls when using --bisect/--pair runtests options.
   https://github.com/django/django/pull/14276 - Refs #32609 -- Simplified test_labels_set construction in runtests.py's setup().
   https://github.com/django/django/pull/14256 - Fixed #32574 -- Confirmed support for PROJ 8.x.
   https://github.com/django/django/pull/14282 - Fixed #32664 -- Made PasswordResetTokenGenerator.secret validation lazy.
   https://github.com/django/django/pull/14237 - Refs #25287 -- Added support for multiplying and dividing DurationField by scalar values on SQLite.
   https://github.com/django/django/pull/14271 - Fixed #32650 -- Fixed handling subquery aliasing on queryset combination.
   https://github.com/django/django/pull/14292 - Fixed #32662 -- Refactored a generator out of SQLCompiler.get_order_by().
   https://github.com/django/django/pull/14295 - Fixed #32667 -- Added link to labeling checks in BaseCommand.requires_system_checks docs.
   https://github.com/django/django/pull/14302 - Fixed #32673 -- Fixed lookups crash when comparing against lookups on PostgreSQL.

Reviewed:
   https://github.com/django/django/pull/14288 - Fixed #32647 -- Restored multi-row select with shift-modifier in admin changelist.

Authored:
   https://github.com/django/django/pull/14291 - Fixed #32665 -- Fixed caches system check crash when STATICFILES_DIRS is a list of 2-tuples.
   https://github.com/django/django/pull/14300 - Fixed isolation of test_showmigrations_unmigrated_app().

   https://github.com/django/django/pull/14304 - Refs #32673 -- Fixed lookups crash when comparing against lookups on Oracle.

Best,
Mariusz

[Mariusz Felisiak]

Week ending May 2, 2021

Triaged:
   https://code.djangoproject.com/ticket/32682 - Deleting objects after searching related many to many field crashes the admin page (accepted)
   https://code.djangoproject.com/ticket/32685 - Add feature to preserve order in .filter(field__in=list) query (wontfix)
   https://code.djangoproject.com/ticket/32680 - Add an option to display inlines as a table without forms. (wontfix)
   https://code.djangoproject.com/ticket/32688 - The ON CONFLICT sql suffix creates a syntax error on m2m inserts (invalid)
   https://code.djangoproject.com/ticket/29168 - Document how to write a custom lookup where the rhs comes before the lhs (invalid)
   https://code.djangoproject.com/ticket/32690 - Q object __or__ appears to get all dunder related's default columns and queryset raises ProgrammingError. (accepted)
   https://code.djangoproject.com/ticket/26368 - Order of &-ing Q objects affects results in edge case (duplicate)
   https://code.djangoproject.com/ticket/32691 - Django 3.2 boolean field SQL output is causing a performance regression in MySQL. (invalid)
   https://code.djangoproject.com/ticket/32692 - Django 3.2 automatic AppConfig discovery breaks projects working in 3.1.8 (invalid)
   https://code.djangoproject.com/ticket/32689 - Infinite AlterField Migrations due to default callable object missmatch (invalid)
   https://code.djangoproject.com/ticket/32696 - Display Changed Value in History Form Django Admin (invalid)
   https://code.djangoproject.com/ticket/32697 - Older versions of Django insist on converting BigAutoField back to AutoField (invalid)
   https://code.djangoproject.com/ticket/32698 - Move HttpRequest.get_raw_uri() to ExceptionReporter._get_raw_insecure_uri(). (accepted)
   https://code.djangoproject.com/ticket/32695 - Create Permissions with create() instead of bulk_create() to send signal (wontfix)
   https://code.djangoproject.com/ticket/23572 - Exception on Custom Lookups when right value is None. (fixed)

Reviewed/committed:
   https://github.com/django/django/pull/14308 - Fixed #32681 -- Fixed VariableDoesNotExist when rendering some admin template.
   https://github.com/django/django/pull/14314 - Fixed #32686 -- Removed unnecessary semicolon on collected multiline SQL for RunSQL.
   https://github.com/django/django/pull/14315 - Fixed #32687 -- Restored passing process’ environment to underlying tool in dbshell on PostgreSQL.
   https://github.com/django/django/pull/14309 - Fixed #32632, Fixed #32657 -- Removed flawed support for Subquery deconstruction.
   https://github.com/django/django/pull/14320 - Cleaned up handling of alias reuse with filtered relations.
   https://github.com/django/django/pull/14323 - Fixed #32675 -- Doc'd that autodector changes might cause generation of no-op migrations.
   https://github.com/django/django/pull/14330 - Fixed capitalization of "ECMAScript" and "JavaScript".
   https://github.com/django/django/pull/14317 - Refs #32178 -- Doc'd DatabaseFeatures.django_test_skips/django_test_expected_failures in contributing guide.
   https://github.com/django/django/pull/14331 - Fixed #32698 -- Moved HttpRequest.get_raw_uri() to ExceptionReporter._get_raw_insecure_uri().
   https://github.com/django/django/pull/14306 - Fixed #32678 -- Removed SECURE_BROWSER_XSS_FILTER setting.

Reviewed:
   https://github.com/django/django/pull/14328 - Refs #32674 -- Noted that auto-created through table PKs cannot be automatically migrated.

Authored:
   https://github.com/django/django/pull/14312 - Refs 32637 -- Made technical 404 debug page display exception message when URL is resolved.
   https://github.com/django/django/pull/14313 - Fixed #32682 -- Made admin changelist use Exists() instead of distinct() for preventing duplicates.
   https://github.com/django/django/pull/14329 - Refs #32682 -- Renamed lookup_needs_distinct() to lookup_spawns_duplicates().
   https://github.com/django/django/pull/14335 - Fixed #32653 -- Made quoting names in the Oracle backend consistent with db_table.

Best,
Mariusz