CITextField base class

[Sean Brant]

I noticed the new postgres citext[1] field is a subclass of CharField. Wouldn't it be more correct to subclass TextField? Subclassing CharField means we need to add a max_length which is ignored in the db.

[1] https://github.com/django/django/blob/master/django/contrib/postgres/fields/citext.py

[Adam Johnson]

Sounds legit, make a ticket

On 8 February 2017 at 00:37, Sean Brant <brant...@gmail.com> wrote:

I noticed the new postgres citext[1] field is a subclass of CharField. Wouldn't it be more correct to subclass TextField? Subclassing CharField means we need to add a max_length which is ignored in the db.

[1] https://github.com/django/django/blob/master/django/contrib/postgres/fields/citext.py

--
You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscribe@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.
Visit this group at https://groups.google.com/group/django-developers.
To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/0e50eae1-8806-47fc-b223-9cac7152bf1e%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--

Adam

[Mads Jensen]

On Wednesday, February 8, 2017 at 11:32:22 AM UTC+1, Adam Johnson wrote:

Sounds legit, make a ticket

Shouldn't https://code.djangoproject.com/ticket/26610 just be reopened?
 

On 8 February 2017 at 00:37, Sean Brant <brant...@gmail.com> wrote:

I noticed the new postgres citext[1] field is a subclass of CharField. Wouldn't it be more correct to subclass TextField? Subclassing CharField means we need to add a max_length which is ignored in the db.

[1] https://github.com/django/django/blob/master/django/contrib/postgres/fields/citext.py

--
You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group.

To unsubscribe from this group and stop receiving emails from it, send an email to django-develop...@googlegroups.com.
To post to this group, send email to django-d...@googlegroups.com.

Visit this group at https://groups.google.com/group/django-developers.
To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/0e50eae1-8806-47fc-b223-9cac7152bf1e%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--

Adam

[Florian Apolloner]

On Wednesday, February 8, 2017 at 12:00:23 PM UTC+1, Mads Jensen wrote:

Shouldn't https://code.djangoproject.com/ticket/26610 just be reopened?

Nope, since that ticket indeed got fixed. A bug in something that got committed usually also means new ticket.

[Adam Johnson]

Pretty sure this is a new ticket since it's effectively a bug report

To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscribe@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.

Visit this group at https://groups.google.com/group/django-developers.

To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/e2be5fd6-3fc0-44d5-8d07-da713eb58db4%40googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

--

Adam

[Tim Graham]

Since that's a release blocker for a feature that hasn't been released yet, it's fine to reference/reopen the original ticket rather than create a new one. I've created a PR, https://github.com/django/django/pull/8034.

On Wednesday, February 8, 2017 at 7:40:02 AM UTC-5, Adam Johnson wrote:

Pretty sure this is a new ticket since it's effectively a bug report

On 8 February 2017 at 11:00, Mads Jensen <m...@inducks.org> wrote:

On Wednesday, February 8, 2017 at 11:32:22 AM UTC+1, Adam Johnson wrote:

Sounds legit, make a ticket

Shouldn't https://code.djangoproject.com/ticket/26610 just be reopened?
 

On 8 February 2017 at 00:37, Sean Brant <brant...@gmail.com> wrote:

I noticed the new postgres citext[1] field is a subclass of CharField. Wouldn't it be more correct to subclass TextField? Subclassing CharField means we need to add a max_length which is ignored in the db.

[1] https://github.com/django/django/blob/master/django/contrib/postgres/fields/citext.py

--
You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email to django-develop...@googlegroups.com.
To post to this group, send email to django-d...@googlegroups.com.
Visit this group at https://groups.google.com/group/django-developers.
To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/0e50eae1-8806-47fc-b223-9cac7152bf1e%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--

Adam

--
You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email to django-develop...@googlegroups.com.
To post to this group, send email to django-d...@googlegroups.com.
Visit this group at https://groups.google.com/group/django-developers.

To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/e2be5fd6-3fc0-44d5-8d07-da713eb58db4%40googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

--

Adam

[Sean Brant]

Thanks Tim. I re-opened the ticket.

To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscribe@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.

Visit this group at https://groups.google.com/group/django-developers.

To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/cac9ac5f-cdcd-4e33-bba3-b1a9de700365%40googlegroups.com.

[Jon Dufresne]

I believe this will also change the default form widget from <input type="text"> to <textarea>. Is that also desired? IME, I most often use citext with short text inputs, such as email.

To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscribe@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.

Visit this group at https://groups.google.com/group/django-developers.

To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/cac9ac5f-cdcd-4e33-bba3-b1a9de700365%40googlegroups.com.

[Sean Brant]

Does it make sense to add a CICharField for these cases or you can just override the form/admin.

To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CADhq2b6%3Dc7EAzbjP%3DFxDb%3D7O2-8x6V4jOoQhx2OTvcAH1P_xEg%40mail.gmail.com.

[Jon Dufresne]

> Does it make sense to add a CICharField for these cases or you can just override the form/admin.

In a past Django developers discussion, Aymeric suggested building this functionality with a mixin so the citext type could apply to multiple DB fields which would then affect how the form field is rendered. Personally, I like this idea and believe it would provide the most flexibility such that a TextField, CharField, EmailField, etc. could all be backed by the citext type.

https://groups.google.com/d/msg/django-developers/SW7_qI81G58/i6aJVRnJBAAJ

From Aymeric in the previous thread:

---

I'm forseeing a small difficulty in terms of API. This is a behavior I'd like

to "mix in" to some fields but I can't say if that will be easy to implement.

The general ideas would be:

# A mixin

class CITextField(TextField):

    # ...

# Case-insensitive versions of some built-in Django default fields

# (if we consider that makes sense)

class CIEmailField(CITextField, EmailField):

    pass

# The possibility for users to make custom fields case insensitive

class CITagField(CITextField, TagField):

    pass

---

[Tim Graham]

I thought the mixin idea was good but everyone else (including Aymeric) reviewed the pull request and ignored your comment about that so I assumed no one else saw its merits. Considering a CITextField that uses CharField still has some usefulness as you mentioned, I'm in favor of CITextField not inheriting anything and requiring its use as a mixin -- unless there are some unforeseen problems with that.

[Mads Jensen]

I had the use case for shorter text strings in mind when I did the PR.

https://github.com/atombrella/django/commit/ae8fe50f34329cbc969c5ac5bd368efd5b42b177 <- would this be a better approach?

[Tim Graham]

That looks good to me.

[Aymeric Augustin]

Hello,

I’m not a fan of having every project that needs case-insensitive fields declare:

class CICharField(CIText, CharField):

    pass

class CITextField(CIText, TextField):

    pass

class CIEmailField(CIText, EmailField):

    pass

Could Django take care of providing these classes? (And perhaps other useful ones?)

Best regards,

-- 

Aymeric.

-- 
You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email to django-develop...@googlegroups.com.
To post to this group, send email to django-d...@googlegroups.com.
Visit this group at https://groups.google.com/group/django-developers.

To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/827e4af1-2431-4216-95e2-0e72afe0ce70%40googlegroups.com.

[Adam Johnson]

I agree with Aymeric that the framework should contain any boilerplate rather than force projects to implement it themselves.

Hello,

-- 

Aymeric.

To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsub...@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.

Visit this group at https://groups.google.com/group/django-developers.
To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/827e4af1-2431-4216-95e2-0e72afe0ce70%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--
You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group.

To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscribe@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.

Visit this group at https://groups.google.com/group/django-developers.

To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/79B14592-6C40-46AB-94AB-638EF2D378DE%40polytechnique.org.

For more options, visit https://groups.google.com/d/optout.

--

Adam